patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Ruifeng Wang <ruifeng.wang@arm.com>
Cc: David Marchand <david.marchand@redhat.com>,
	Akhil Goyal <akhil.goyal@nxp.com>, dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'crypto/armv8: use dedicated log type' has been queued to LTS release 18.11.10
Date: Fri, 28 Aug 2020 11:12:52 +0100	[thread overview]
Message-ID: <20200828101308.223767-26-ktraynor@redhat.com> (raw)
In-Reply-To: <20200828101308.223767-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to LTS release 18.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/02/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/16147e7969ad44f020c1ed320869866816c6453a

Thanks.

Kevin.

---
From 16147e7969ad44f020c1ed320869866816c6453a Mon Sep 17 00:00:00 2001
From: Ruifeng Wang <ruifeng.wang@arm.com>
Date: Tue, 28 Jul 2020 17:24:05 +0800
Subject: [PATCH] crypto/armv8: use dedicated log type

[ upstream commit 28b0514504cf0f71f822f0aed5aacc83eb8ada12 ]

armv8 crypto PMD used CRYPTODEV general log type.
Create a dedicated log type for the PMD to not pollute CRYPTODEV log type.

Typo in crypto dev name macro caused unexpected device name in log.
Fixed the typo to log with correct device name.

Fixes: 169ca3db550c ("crypto/armv8: add PMD optimized for ARMv8 processors")

Suggested-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 drivers/crypto/armv8/rte_armv8_pmd.c         |  2 ++
 drivers/crypto/armv8/rte_armv8_pmd_private.h | 23 ++++++++++++--------
 2 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c
index efdde399de..440417c65f 100644
--- a/drivers/crypto/armv8/rte_armv8_pmd.c
+++ b/drivers/crypto/armv8/rte_armv8_pmd.c
@@ -851,4 +851,6 @@ static struct rte_vdev_driver armv8_crypto_pmd_drv = {
 static struct cryptodev_driver armv8_crypto_drv;
 
+RTE_LOG_REGISTER(crypto_armv8_log_type, pmd.crypto.armv8, ERR);
+
 RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_ARMV8_PMD, armv8_crypto_pmd_drv);
 RTE_PMD_REGISTER_ALIAS(CRYPTODEV_NAME_ARMV8_PMD, cryptodev_armv8_pmd);
diff --git a/drivers/crypto/armv8/rte_armv8_pmd_private.h b/drivers/crypto/armv8/rte_armv8_pmd_private.h
index 04ce1cc0e4..daad14b8da 100644
--- a/drivers/crypto/armv8/rte_armv8_pmd_private.h
+++ b/drivers/crypto/armv8/rte_armv8_pmd_private.h
@@ -9,17 +9,22 @@
 /**< ARMv8 Crypto PMD device name */
 
-#define ARMV8_CRYPTO_LOG_ERR(fmt, args...) \
-	RTE_LOG(ERR, CRYPTODEV, "[%s] %s() line %u: " fmt "\n",  \
-			RTE_STR(CRYPTODEV_NAME_ARMV8_CRYPTO_PMD), \
+extern int crypto_armv8_log_type;
+
+#define ARMV8_CRYPTO_LOG_ERR(fmt, args...)			\
+	rte_log(RTE_LOG_ERR, crypto_armv8_log_type,		\
+			"[%s] %s() line %u: " fmt "\n",		\
+			RTE_STR(CRYPTODEV_NAME_ARMV8_PMD),	\
 			__func__, __LINE__, ## args)
 
-#define ARMV8_CRYPTO_LOG_INFO(fmt, args...) \
-	RTE_LOG(INFO, CRYPTODEV, "[%s] %s() line %u: " fmt "\n", \
-			RTE_STR(CRYPTODEV_NAME_ARMV8_CRYPTO_PMD), \
+#define ARMV8_CRYPTO_LOG_INFO(fmt, args...)			\
+	rte_log(RTE_LOG_INFO, crypto_armv8_log_type,		\
+			"[%s] %s() line %u: " fmt "\n",		\
+			RTE_STR(CRYPTODEV_NAME_ARMV8_PMD),	\
 			__func__, __LINE__, ## args)
 
-#define ARMV8_CRYPTO_LOG_DBG(fmt, args...) \
-	RTE_LOG(DEBUG, CRYPTODEV, "[%s] %s() line %u: " fmt "\n", \
-			RTE_STR(CRYPTODEV_NAME_ARMV8_CRYPTO_PMD), \
+#define ARMV8_CRYPTO_LOG_DBG(fmt, args...)			\
+	rte_log(RTE_LOG_DEBUG, crypto_armv8_log_type,		\
+			"[%s] %s() line %u: " fmt "\n",		\
+			RTE_STR(CRYPTODEV_NAME_ARMV8_PMD),	\
 			__func__, __LINE__, ## args)
 
-- 
2.26.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-08-28 11:03:26.544052543 +0100
+++ 0026-crypto-armv8-use-dedicated-log-type.patch	2020-08-28 11:03:25.951955670 +0100
@@ -1 +1 @@
-From 28b0514504cf0f71f822f0aed5aacc83eb8ada12 Mon Sep 17 00:00:00 2001
+From 16147e7969ad44f020c1ed320869866816c6453a Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 28b0514504cf0f71f822f0aed5aacc83eb8ada12 ]
+
@@ -13 +14,0 @@
-Cc: stable@dpdk.org
@@ -19,2 +20,2 @@
- drivers/crypto/armv8/armv8_pmd_private.h | 23 ++++++++++++++---------
- drivers/crypto/armv8/rte_armv8_pmd.c     |  2 ++
+ drivers/crypto/armv8/rte_armv8_pmd.c         |  2 ++
+ drivers/crypto/armv8/rte_armv8_pmd_private.h | 23 ++++++++++++--------
@@ -23,5 +24,16 @@
-diff --git a/drivers/crypto/armv8/armv8_pmd_private.h b/drivers/crypto/armv8/armv8_pmd_private.h
-index 19940809bc..709b3d5360 100644
---- a/drivers/crypto/armv8/armv8_pmd_private.h
-+++ b/drivers/crypto/armv8/armv8_pmd_private.h
-@@ -11,17 +11,22 @@
+diff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c
+index efdde399de..440417c65f 100644
+--- a/drivers/crypto/armv8/rte_armv8_pmd.c
++++ b/drivers/crypto/armv8/rte_armv8_pmd.c
+@@ -851,4 +851,6 @@ static struct rte_vdev_driver armv8_crypto_pmd_drv = {
+ static struct cryptodev_driver armv8_crypto_drv;
+ 
++RTE_LOG_REGISTER(crypto_armv8_log_type, pmd.crypto.armv8, ERR);
++
+ RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_ARMV8_PMD, armv8_crypto_pmd_drv);
+ RTE_PMD_REGISTER_ALIAS(CRYPTODEV_NAME_ARMV8_PMD, cryptodev_armv8_pmd);
+diff --git a/drivers/crypto/armv8/rte_armv8_pmd_private.h b/drivers/crypto/armv8/rte_armv8_pmd_private.h
+index 04ce1cc0e4..daad14b8da 100644
+--- a/drivers/crypto/armv8/rte_armv8_pmd_private.h
++++ b/drivers/crypto/armv8/rte_armv8_pmd_private.h
+@@ -9,17 +9,22 @@
@@ -59,11 +70,0 @@
-diff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c
-index 8b212772fa..a2b08d8180 100644
---- a/drivers/crypto/armv8/rte_armv8_pmd.c
-+++ b/drivers/crypto/armv8/rte_armv8_pmd.c
-@@ -862,4 +862,6 @@ static struct rte_vdev_driver armv8_crypto_pmd_drv = {
- static struct cryptodev_driver armv8_crypto_drv;
- 
-+RTE_LOG_REGISTER(crypto_armv8_log_type, pmd.crypto.armv8, ERR);
-+
- RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_ARMV8_PMD, armv8_crypto_pmd_drv);
- RTE_PMD_REGISTER_ALIAS(CRYPTODEV_NAME_ARMV8_PMD, cryptodev_armv8_pmd);


  parent reply	other threads:[~2020-08-28 10:14 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-28 10:12 [dpdk-stable] patch 'net/bonding: fix error code on device creation' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/af_packet: fix check of file descriptors' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/af_packet: fix memory leak on init failure' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/af_packet: fix munmap " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/bonding: fix MAC address when switching active port' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/bonding: fix MAC address when one port resets' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/i40e: fix flow director Rx writeback packet' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/ixgbe: fix MAC control frame forward' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/ixgbe: fix flow control status' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/bonding: delete redundant code' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/i40e: report VLAN filter capability' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/e1000: report VLAN extend " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/e1000: fix crash on Tx done clean up' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'vhost: fix double-free with zero-copy' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net: fix pedantic build' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'doc: fix some typos in Linux guide' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'doc: fix typo in bbdev test " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'bus/vdev: fix a typo in doxygen comment' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'hash: fix out-of-memory handling in hash creation' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'test/cycles: restore default delay callback' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'event/dpaa: remove dead code' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'app/eventdev: fix capability check in pipeline ATQ test' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'event/dpaa2: add all-types queue capability flag' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'common/qat: fix uninitialized variable' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'crypto/armv8: remove debug option' " Kevin Traynor
2020-08-28 10:12 ` Kevin Traynor [this message]
2020-08-28 10:12 ` [dpdk-stable] patch 'net/mlx5: fix flow items size calculation' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/mlx5: fix crash in NVGRE item translation' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/mlx4: optimize stack memory size in probe' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/i40e: fix binding interrupt without MSI-X vector' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/i40e: fix flow director MSI-X resource allocation' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/qede: remove dead code' " Kevin Traynor
2020-08-28 10:12 ` [dpdk-stable] patch 'net/virtio-user: fix status management' " Kevin Traynor
2020-08-28 10:13 ` [dpdk-stable] patch 'net/virtio-user: check tap system call setting' " Kevin Traynor
2020-08-28 10:13 ` [dpdk-stable] patch 'net/kni: set packet input port in Rx' " Kevin Traynor
2020-08-28 10:13 ` [dpdk-stable] patch 'examples/packet_ordering: use proper exit method' " Kevin Traynor
2020-08-28 10:13 ` [dpdk-stable] patch 'net/netvsc: fix crash during Tx' " Kevin Traynor
2020-08-28 10:13 ` [dpdk-stable] patch 'doc: fix ethtool app path' " Kevin Traynor
2020-08-28 10:13 ` [dpdk-stable] patch 'net/bonding: fix dead loop on RSS RETA update' " Kevin Traynor
2020-08-28 10:13 ` [dpdk-stable] patch 'net/i40e: remove duplicate tunnel type check' " Kevin Traynor
2020-08-28 10:13 ` [dpdk-stable] patch 'kni: fix reference to master/slave process' " Kevin Traynor
2020-08-28 10:13 ` [dpdk-stable] patch 'doc: fix reference to master " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200828101308.223767-26-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=akhil.goyal@nxp.com \
    --cc=david.marchand@redhat.com \
    --cc=ruifeng.wang@arm.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).