From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04B1CA04B1 for ; Fri, 28 Aug 2020 12:14:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EF779A3; Fri, 28 Aug 2020 12:14:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 396F41C119 for ; Fri, 28 Aug 2020 12:14:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598609668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JPg7oScYPjX06w75Odn+EzWWZKnxPCQ8ZFrgxyafBmQ=; b=D6bQUDKTn+weLjEfuf3U9czlHAvhVfYcR0ad9rp2dA/ooj/819Y8AgfP81ZaZrfxMA6hxd AVwqvsEy/lz60x57EOXCjVp3EdHFvQvmatNT50Mdy8/lRRzwN0+wC0NpyyYSwDoLK6wzmQ gSBHIWqgWmSbfN28n7JTdYyZ2y9TJ4k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-184-WbOND48UOrSp9sfaG0y8gg-1; Fri, 28 Aug 2020 06:14:25 -0400 X-MC-Unique: WbOND48UOrSp9sfaG0y8gg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0DDC41006702; Fri, 28 Aug 2020 10:14:24 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE20119D7D; Fri, 28 Aug 2020 10:14:22 +0000 (UTC) From: Kevin Traynor To: Yunjian Wang Cc: Rasesh Mody , dpdk stable Date: Fri, 28 Aug 2020 11:12:58 +0100 Message-Id: <20200828101308.223767-32-ktraynor@redhat.com> In-Reply-To: <20200828101308.223767-1-ktraynor@redhat.com> References: <20200828101308.223767-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/qede: remove dead code' has been queued to LTS release 18.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/02/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/3eccb8b4fb75988a0130a6eab6b5fc8d152d415c Thanks. Kevin. --- >From 3eccb8b4fb75988a0130a6eab6b5fc8d152d415c Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Fri, 17 Jul 2020 19:16:23 +0800 Subject: [PATCH] net/qede: remove dead code [ upstream commit d123f83c43085d03e0c2e37f8174577189711fdb ] This patch removes logically dead code reported by coverity. Coverity issue: 261777, 261778 Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") Signed-off-by: Yunjian Wang Acked-by: Rasesh Mody --- drivers/net/qede/qede_rxtx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index a72c9aa333..0ccfea4912 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -648,6 +648,4 @@ int qede_alloc_fp_resc(struct qede_dev *qdev) for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) { fp = &qdev->fp_array[sb_idx]; - if (!fp) - continue; fp->sb_info = rte_calloc("sb", 1, sizeof(struct ecore_sb_info), RTE_CACHE_LINE_SIZE); @@ -679,6 +677,4 @@ void qede_dealloc_fp_resc(struct rte_eth_dev *eth_dev) for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) { fp = &qdev->fp_array[sb_idx]; - if (!fp) - continue; DP_INFO(edev, "Free sb_info index 0x%x\n", fp->sb_info->igu_sb_id); -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-08-28 11:03:26.698000089 +0100 +++ 0032-net-qede-remove-dead-code.patch 2020-08-28 11:03:25.984955920 +0100 @@ -1 +1 @@ -From d123f83c43085d03e0c2e37f8174577189711fdb Mon Sep 17 00:00:00 2001 +From 3eccb8b4fb75988a0130a6eab6b5fc8d152d415c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d123f83c43085d03e0c2e37f8174577189711fdb ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 9878ba50ea..ea264f59d7 100644 +index a72c9aa333..0ccfea4912 100644