From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D93FA04B1 for ; Fri, 28 Aug 2020 12:14:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 441801C11B; Fri, 28 Aug 2020 12:14:39 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 47388A3 for ; Fri, 28 Aug 2020 12:14:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598609675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GCVmA2ZoRDhjNX4CNSXcX3+olZoqzcADAdHIopWjdh0=; b=YwaSK8Dw0ZnSRT636mxB2RAyjv0sL09jLpJu6EaxY4GnwWBM1eHN39ZoQylIE+tWLVFzji rqbmj4s1Ny8q4ZkyJ8i7AoUtv+7UpOTrDTzna2IjCgaELoPlHj9wX77Z5p0plR1hVNaSns ovSErafSO12carmnYwfsUwwS5/yLvok= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-233-oavStFNHM9KNc5IofsPcBQ-1; Fri, 28 Aug 2020 06:14:33 -0400 X-MC-Unique: oavStFNHM9KNc5IofsPcBQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2D1038015A8; Fri, 28 Aug 2020 10:14:32 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7436019D7C; Fri, 28 Aug 2020 10:14:31 +0000 (UTC) From: Kevin Traynor To: Sarosh Arif Cc: dpdk stable Date: Fri, 28 Aug 2020 11:13:02 +0100 Message-Id: <20200828101308.223767-36-ktraynor@redhat.com> In-Reply-To: <20200828101308.223767-1-ktraynor@redhat.com> References: <20200828101308.223767-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'examples/packet_ordering: use proper exit method' has been queued to LTS release 18.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/02/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/08e79f9cf4c987b0cb6a94dcf398c538d084ef1a Thanks. Kevin. --- >From 08e79f9cf4c987b0cb6a94dcf398c538d084ef1a Mon Sep 17 00:00:00 2001 From: Sarosh Arif Date: Fri, 5 Jun 2020 16:48:28 +0500 Subject: [PATCH] examples/packet_ordering: use proper exit method [ upstream commit d74fab8e7cc36acaf2abf83888809fd1e40c932a ] rte_exit should be called when the application exits due to invalid EAL or application arguments. Fixes: 850f3733f840 ("examples/packet_ordering: new sample app") Signed-off-by: Sarosh Arif --- examples/packet_ordering/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c index 149bfdd02c..df64158847 100644 --- a/examples/packet_ordering/main.c +++ b/examples/packet_ordering/main.c @@ -622,5 +622,5 @@ main(int argc, char **argv) ret = rte_eal_init(argc, argv); if (ret < 0) - return -1; + rte_exit(EXIT_FAILURE, "Invalid EAL arguments\n"); argc -= ret; @@ -630,5 +630,5 @@ main(int argc, char **argv) ret = parse_args(argc, argv); if (ret < 0) - return -1; + rte_exit(EXIT_FAILURE, "Invalid packet_ordering arguments\n"); /* Check if we have enought cores */ -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-08-28 11:03:26.779969729 +0100 +++ 0036-examples-packet_ordering-use-proper-exit-method.patch 2020-08-28 11:03:25.987955943 +0100 @@ -1 +1 @@ -From d74fab8e7cc36acaf2abf83888809fd1e40c932a Mon Sep 17 00:00:00 2001 +From 08e79f9cf4c987b0cb6a94dcf398c538d084ef1a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d74fab8e7cc36acaf2abf83888809fd1e40c932a ] + @@ -17 +19 @@ -index 5c654c11c6..b5fc6c54be 100644 +index 149bfdd02c..df64158847 100644 @@ -20 +22 @@ -@@ -673,5 +673,5 @@ main(int argc, char **argv) +@@ -622,5 +622,5 @@ main(int argc, char **argv) @@ -27 +29 @@ -@@ -681,5 +681,5 @@ main(int argc, char **argv) +@@ -630,5 +630,5 @@ main(int argc, char **argv)