patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] crypto/scheduler: fix header install with meson
@ 2020-09-17 15:09 David Marchand
  2020-09-17 15:29 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: David Marchand @ 2020-09-17 15:09 UTC (permalink / raw)
  To: dev; +Cc: stable, Fan Zhang, Luca Boccassi

The headers variable is only used in lib/meson.build context.
For drivers, an explicit install_headers() is necessary.

Reproduced while compiling the l2fwd-crypto example out of meson
(which can be done by adding it in devtools/test-meson-builds.sh
examples build test).

Fixes: cd2b6458a1cb ("crypto/scheduler: add in meson build")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/crypto/scheduler/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/scheduler/meson.build b/drivers/crypto/scheduler/meson.build
index c5ba2d6804..cb0f3a8ba9 100644
--- a/drivers/crypto/scheduler/meson.build
+++ b/drivers/crypto/scheduler/meson.build
@@ -13,7 +13,7 @@ sources = files(
 	'scheduler_roundrobin.c',
 )
 
-headers = files(
+install_headers(
 	'rte_cryptodev_scheduler.h',
 	'rte_cryptodev_scheduler_operations.h',
 )
-- 
2.23.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/scheduler: fix header install with meson
  2020-09-17 15:09 [dpdk-stable] [PATCH] crypto/scheduler: fix header install with meson David Marchand
@ 2020-09-17 15:29 ` Bruce Richardson
  2020-09-17 15:33   ` David Marchand
  2020-09-17 15:29 ` Bruce Richardson
  2020-10-22  7:55 ` [dpdk-stable] [PATCH v2 1/2] " David Marchand
  2 siblings, 1 reply; 6+ messages in thread
From: Bruce Richardson @ 2020-09-17 15:29 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, stable, Fan Zhang, Luca Boccassi

On Thu, Sep 17, 2020 at 05:09:17PM +0200, David Marchand wrote:
> The headers variable is only used in lib/meson.build context.
> For drivers, an explicit install_headers() is necessary.
> 
> Reproduced while compiling the l2fwd-crypto example out of meson
> (which can be done by adding it in devtools/test-meson-builds.sh
> examples build test).
> 
> Fixes: cd2b6458a1cb ("crypto/scheduler: add in meson build")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/crypto/scheduler/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Originally I only put the "headers" variable in the "lib" folder
meson.build because it was not expected that many drivers should have
private headers. However, perhaps it's worthwhile adding it now:
a) because private headers, while not common, are not unusual
b) for consistency and ease of use.

Thoughts?

/Bruce

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/scheduler: fix header install with meson
  2020-09-17 15:09 [dpdk-stable] [PATCH] crypto/scheduler: fix header install with meson David Marchand
  2020-09-17 15:29 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
@ 2020-09-17 15:29 ` Bruce Richardson
  2020-10-22  7:55 ` [dpdk-stable] [PATCH v2 1/2] " David Marchand
  2 siblings, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2020-09-17 15:29 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, stable, Fan Zhang, Luca Boccassi

On Thu, Sep 17, 2020 at 05:09:17PM +0200, David Marchand wrote:
> The headers variable is only used in lib/meson.build context.
> For drivers, an explicit install_headers() is necessary.
> 
> Reproduced while compiling the l2fwd-crypto example out of meson
> (which can be done by adding it in devtools/test-meson-builds.sh
> examples build test).
> 
> Fixes: cd2b6458a1cb ("crypto/scheduler: add in meson build")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/scheduler: fix header install with meson
  2020-09-17 15:29 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
@ 2020-09-17 15:33   ` David Marchand
  2020-09-17 15:46     ` Bruce Richardson
  0 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2020-09-17 15:33 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: dev, dpdk stable, Fan Zhang, Luca Boccassi

On Thu, Sep 17, 2020 at 5:29 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Thu, Sep 17, 2020 at 05:09:17PM +0200, David Marchand wrote:
> > The headers variable is only used in lib/meson.build context.
> > For drivers, an explicit install_headers() is necessary.
> >
> > Reproduced while compiling the l2fwd-crypto example out of meson
> > (which can be done by adding it in devtools/test-meson-builds.sh
> > examples build test).
> >
> > Fixes: cd2b6458a1cb ("crypto/scheduler: add in meson build")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> >  drivers/crypto/scheduler/meson.build | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> Originally I only put the "headers" variable in the "lib" folder
> meson.build because it was not expected that many drivers should have
> private headers. However, perhaps it's worthwhile adding it now:
> a) because private headers, while not common, are not unusual
> b) for consistency and ease of use.
>
> Thoughts?

Yep, I can do it in a followup patch now, still looking at your RFC
series though.. :-)


-- 
David Marchand


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/scheduler: fix header install with meson
  2020-09-17 15:33   ` David Marchand
@ 2020-09-17 15:46     ` Bruce Richardson
  0 siblings, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2020-09-17 15:46 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, dpdk stable, Fan Zhang, Luca Boccassi

On Thu, Sep 17, 2020 at 05:33:23PM +0200, David Marchand wrote:
> On Thu, Sep 17, 2020 at 5:29 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > On Thu, Sep 17, 2020 at 05:09:17PM +0200, David Marchand wrote:
> > > The headers variable is only used in lib/meson.build context.
> > > For drivers, an explicit install_headers() is necessary.
> > >
> > > Reproduced while compiling the l2fwd-crypto example out of meson
> > > (which can be done by adding it in devtools/test-meson-builds.sh
> > > examples build test).
> > >
> > > Fixes: cd2b6458a1cb ("crypto/scheduler: add in meson build")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > ---
> > >  drivers/crypto/scheduler/meson.build | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > Originally I only put the "headers" variable in the "lib" folder
> > meson.build because it was not expected that many drivers should have
> > private headers. However, perhaps it's worthwhile adding it now:
> > a) because private headers, while not common, are not unusual
> > b) for consistency and ease of use.
> >
> > Thoughts?
> 
> Yep, I can do it in a followup patch now, still looking at your RFC
> series though.. :-)
>
No rush, what we have now has worked reasonably well for the last few
years! :-)
If you don't get to it, I can always look at it post-19.11.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-stable] [PATCH v2 1/2] crypto/scheduler: fix header install with meson
  2020-09-17 15:09 [dpdk-stable] [PATCH] crypto/scheduler: fix header install with meson David Marchand
  2020-09-17 15:29 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
  2020-09-17 15:29 ` Bruce Richardson
@ 2020-10-22  7:55 ` David Marchand
  2 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2020-10-22  7:55 UTC (permalink / raw)
  To: dev; +Cc: bruce.richardson, stable, Fan Zhang, Luca Boccassi

The headers variable is only used in lib/meson.build context.
For drivers, an explicit install_headers() is necessary.

Reproduced while compiling the l2fwd-crypto example out of meson
(which can be done by adding it in devtools/test-meson-builds.sh
examples build test).

Fixes: cd2b6458a1cb ("crypto/scheduler: add in meson build")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/crypto/scheduler/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/scheduler/meson.build b/drivers/crypto/scheduler/meson.build
index 2209c50232..df8f3fe7b7 100644
--- a/drivers/crypto/scheduler/meson.build
+++ b/drivers/crypto/scheduler/meson.build
@@ -13,7 +13,7 @@ sources = files(
 	'scheduler_roundrobin.c',
 )
 
-headers = files(
+install_headers(
 	'rte_cryptodev_scheduler.h',
 	'rte_cryptodev_scheduler_operations.h',
 )
-- 
2.23.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-10-22  7:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 15:09 [dpdk-stable] [PATCH] crypto/scheduler: fix header install with meson David Marchand
2020-09-17 15:29 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2020-09-17 15:33   ` David Marchand
2020-09-17 15:46     ` Bruce Richardson
2020-09-17 15:29 ` Bruce Richardson
2020-10-22  7:55 ` [dpdk-stable] [PATCH v2 1/2] " David Marchand

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git