From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 435E3A04B1 for ; Wed, 23 Sep 2020 15:26:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 853B41DCF5; Wed, 23 Sep 2020 15:26:08 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 960981DBDE for ; Wed, 23 Sep 2020 15:25:51 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200923132551euoutp01b4502c94a3c9e3d887ba1d8d9f234cb2~3bI5pMOLC1163311633euoutp01a for ; Wed, 23 Sep 2020 13:25:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200923132551euoutp01b4502c94a3c9e3d887ba1d8d9f234cb2~3bI5pMOLC1163311633euoutp01a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600867551; bh=gFZ/BC5QS8r9vYAoQsykBlxn+BSZtg1dnO8kDQnIEds=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=grPY9O+5fQ94EeAMSg1Qo5z/PnrJwJOlggYLmrQKAIH+HRvOzd/PQk/Vg1EGyMrBp F2LHvnzznelqYshvAkdf3uRuqoYccjmpHGsJT5hWrV5AK3z+KcO4HR9Ss81QQRLT2p Q3vPfKr1oBXbok9xhOB6kFd40I8AEkNr79K7NNK8= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200923132551eucas1p2f3aa70cc8efbc49c297f4d023c81d47e~3bI5eZq6f1223012230eucas1p2r; Wed, 23 Sep 2020 13:25:51 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id F7.84.05997.FDC4B6F5; Wed, 23 Sep 2020 14:25:51 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200923132550eucas1p1ce21011562d0a00cccfd4ae3f0be4ff9~3bI5IU3bT0406104061eucas1p1J; Wed, 23 Sep 2020 13:25:50 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200923132550eusmtrp2d610dda061e1269c4ba350b182cb5bcc~3bI5HyfcS2233622336eusmtrp2a; Wed, 23 Sep 2020 13:25:50 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-66-5f6b4cdf1beb Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 10.B9.06314.EDC4B6F5; Wed, 23 Sep 2020 14:25:50 +0100 (BST) Received: from Padamandas.fritz.box (unknown [106.210.88.70]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200923132550eusmtip22163b935587d07dc17727f180385d49f~3bI4fUesA2715827158eusmtip2X; Wed, 23 Sep 2020 13:25:50 +0000 (GMT) From: Lukasz Wojciechowski To: David Hunt , Bruce Richardson Cc: dev@dpdk.org, l.wojciechow@partner.samsung.com, stable@dpdk.org Date: Wed, 23 Sep 2020 15:25:40 +0200 Message-Id: <20200923132541.21417-8-l.wojciechow@partner.samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200923132541.21417-1-l.wojciechow@partner.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGIsWRmVeSWpSXmKPExsWy7djP87r3fbLjDdYs4Le4screom/SRyaL d5+2M1k861nHaPGv4w+7A6vHrwVLWT0W73nJ5HHw3R6mAOYoLpuU1JzMstQifbsEroye3RfY Cq5wV8y/voqlgfExZxcjJ4eEgInEqvnLGLsYuTiEBFYwSnxdsBPK+cIo8aplEZTzmVFizY43 zDAtm971QiWWM0qc+72cBcL5xCjx4MMJdpAqNgFbiSMzv7KC2CICYRLNzXuBijg4mAWcJZ58 ZQMJCwu4SZw8spcVJMwioCqx8S7YfF4BV4mLJ16wQ+ySl1i94QBYnBOo/MOP92B7JQQus0l8 X7kO6iAXielL/rBB2MISr45vgWqWkfi/cz4TRMM2Romrv39Cde9nlLjeuwKqylri8L/fbBDH aUqs36UPEXaUuHTzLRNIWEKAT+LGW0GQMDOQOWnbdGaIMK9ER5sQRLWexNOeqYwwa/+sfcIC UeIh8edZIiR0rjJKfF+6g2kCo/wshF0LGBlXMYqnlhbnpqcWG+WllusVJ+YWl+al6yXn525i BMb+6X/Hv+xg3PUn6RCjAAejEg8vh252vBBrYllxZe4hRgkOZiURXqezp+OEeFMSK6tSi/Lj i0pzUosPMUpzsCiJ8xovehkrJJCeWJKanZpakFoEk2Xi4JRqYOyqrZ5mFzxBW+SAxoTfP2fz m7g7bSp6LfF0E++B0E+LhDqDwgV36r/b8O+mukyA4Pqg7DuKDUVXv52JmHsoUf5n2cy3Wleq WXIrI6t8Zp5d80Yj4MGcOWGSse1OzYzHmnZtjlnBerZ/baNFkNPTPt767/NbLCPdl/esqFtc 9unNlBmTsyqatyqxFGckGmoxFxUnAgB5D6uA+QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGLMWRmVeSWpSXmKPExsVy+t/xe7r3fLLjDQ7tMrW4screom/SRyaL d5+2M1k861nHaPGv4w+7A6vHrwVLWT0W73nJ5HHw3R6mAOYoPZui/NKSVIWM/OISW6VoQwsj PUNLCz0jE0s9Q2PzWCsjUyV9O5uU1JzMstQifbsEvYye3RfYCq5wV8y/voqlgfExZxcjJ4eE gInEpne9jCC2kMBSRondj8W6GDmA4jISHy4JQJQIS/y51sXWxcgFVPKBUeLh0SmsIAk2AVuJ IzO/soLUiwiESZxY6Q8SZhZwl9iyeCoziC0s4CZx8shesBIWAVWJjXfBwrwCrhIXT7xghxgv L7F6wwGwOCdQ+Ycf7xkhVjUySmx828Y4gZFvASPDKkaR1NLi3PTcYkO94sTc4tK8dL3k/NxN jMAw3Hbs5+YdjJc2Bh9iFOBgVOLh5dDNjhdiTSwrrsw9xCjBwawkwut09nScEG9KYmVValF+ fFFpTmrxIUZToKMmMkuJJucDYySvJN7Q1NDcwtLQ3Njc2MxCSZy3Q+BgjJBAemJJanZqakFq EUwfEwenVANj3LEYtcA0qwU6L/ecVq3lc+fa+77tR9CRBbv4piio3OLQ/3B08cLIrrid8YKf mN/EP5fa1C86QdsiZnbq1wnJLjxx/6VXHun6bDB9q3tiCsNeNsdd5RY3K2L2xK3l3bT8aBX7 qrSHpl2FC9/fblZZ9+xKjd0lkU8VTxuv3zqhE7XRzvHNP5+VSizFGYmGWsxFxYkAITnUzlkC AAA= X-CMS-MailID: 20200923132550eucas1p1ce21011562d0a00cccfd4ae3f0be4ff9 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200923132550eucas1p1ce21011562d0a00cccfd4ae3f0be4ff9 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200923132550eucas1p1ce21011562d0a00cccfd4ae3f0be4ff9 References: <20200923014713.16932-1-l.wojciechow@partner.samsung.com> <20200923132541.21417-1-l.wojciechow@partner.samsung.com> Subject: [dpdk-stable] [PATCH v3 7/8] distributor: do not use oldpkt when not needed X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" rte_distributor_request_pkt and rte_distributor_get_pkt dereferenced oldpkt parameter when in RTE_DIST_ALG_SINGLE even if number of returned buffers from worker to distributor was 0. This patch passes NULL to the legacy API when number of returned buffers is 0. This allows passing NULL as oldpkt parameter. Fixes: 775003ad2f96 ("distributor: add new burst-capable library") Cc: david.hunt@intel.com Cc: stable@dpdk.org Signed-off-by: Lukasz Wojciechowski --- lib/librte_distributor/rte_distributor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c index 12b3db33c..b720abe03 100644 --- a/lib/librte_distributor/rte_distributor.c +++ b/lib/librte_distributor/rte_distributor.c @@ -42,7 +42,7 @@ rte_distributor_request_pkt(struct rte_distributor *d, if (unlikely(d->alg_type == RTE_DIST_ALG_SINGLE)) { rte_distributor_request_pkt_single(d->d_single, - worker_id, oldpkt[0]); + worker_id, count ? oldpkt[0] : NULL); return; } @@ -134,7 +134,7 @@ rte_distributor_get_pkt(struct rte_distributor *d, if (unlikely(d->alg_type == RTE_DIST_ALG_SINGLE)) { if (return_count <= 1) { pkts[0] = rte_distributor_get_pkt_single(d->d_single, - worker_id, oldpkt[0]); + worker_id, return_count ? oldpkt[0] : NULL); return (pkts[0]) ? 1 : 0; } else return -EINVAL; -- 2.17.1