* [dpdk-stable] [PATCH v2 1/8] bus/fslmc: fix atomic queues on nxp lx2 platform [not found] <20200911083520.24020-1-sachin.saxena@oss.nxp.com> @ 2020-09-11 8:35 ` Sachin Saxena (OSS) 2020-09-14 10:25 ` Hemant Agrawal [not found] ` <20200924040209.32719-1-sachin.saxena@oss.nxp.com> 1 sibling, 1 reply; 4+ messages in thread From: Sachin Saxena (OSS) @ 2020-09-11 8:35 UTC (permalink / raw) To: dev, ferruh.yigit; +Cc: stable From: Youri Querry <youri.querry_1@nxp.com> Traffic was stalling after few packet while running l2fwd-event in atomic mode on LX2 platform. It was due to wrong dca setting while enqueuing packets to EQCR. This patch fixes the issue by writing correct dca setting. Fixes: 1b49352f41be ("bus/fslmc: rename portal pi index to consumer index") Cc: stable@dpdk.org Signed-off-by: Youri Querry <youri.querry_1@nxp.com> Signed-off-by: Rohit Raj <rohit.raj@nxp.com> --- drivers/bus/fslmc/qbman/qbman_portal.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_portal.c index 0a2af7be4..77c9d508c 100644 --- a/drivers/bus/fslmc/qbman/qbman_portal.c +++ b/drivers/bus/fslmc/qbman/qbman_portal.c @@ -1201,6 +1201,8 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s, QBMAN_CENA_SWP_EQCR(eqcr_pi & half_mask)); memcpy(&p[1], &cl[1], 28); memcpy(&p[8], &fd[i], sizeof(*fd)); + p[0] = cl[0] | s->eqcr.pi_vb; + if (flags && (flags[i] & QBMAN_ENQUEUE_FLAG_DCA)) { struct qbman_eq_desc *d = (struct qbman_eq_desc *)p; @@ -1208,7 +1210,6 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s, ((flags[i]) & QBMAN_EQCR_DCA_IDXMASK); } eqcr_pi++; - p[0] = cl[0] | s->eqcr.pi_vb; if (!(eqcr_pi & half_mask)) s->eqcr.pi_vb ^= QB_VALID_BIT; -- 2.28.0 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH v2 1/8] bus/fslmc: fix atomic queues on nxp lx2 platform 2020-09-11 8:35 ` [dpdk-stable] [PATCH v2 1/8] bus/fslmc: fix atomic queues on nxp lx2 platform Sachin Saxena (OSS) @ 2020-09-14 10:25 ` Hemant Agrawal 0 siblings, 0 replies; 4+ messages in thread From: Hemant Agrawal @ 2020-09-14 10:25 UTC (permalink / raw) To: Sachin Saxena (OSS), dev, ferruh.yigit; +Cc: stable Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20200924040209.32719-1-sachin.saxena@oss.nxp.com>]
* [dpdk-stable] [PATCH v3 1/6] bus/fslmc: fix atomic queues on nxp lx2 platform [not found] ` <20200924040209.32719-1-sachin.saxena@oss.nxp.com> @ 2020-09-24 4:02 ` Sachin Saxena (OSS) 2020-09-24 4:02 ` [dpdk-stable] [PATCH v3 3/6] net/dpaa2: fix check for key size Sachin Saxena (OSS) 1 sibling, 0 replies; 4+ messages in thread From: Sachin Saxena (OSS) @ 2020-09-24 4:02 UTC (permalink / raw) To: dev, ferruh.yigit; +Cc: stable From: Youri Querry <youri.querry_1@nxp.com> Traffic was stalling after few packet while running l2fwd-event in atomic mode on LX2 platform. It was due to wrong dca setting while enqueuing packets to EQCR. This patch fixes the issue by writing correct dca setting. Fixes: 1b49352f41be ("bus/fslmc: rename portal pi index to consumer index") Cc: stable@dpdk.org Signed-off-by: Youri Querry <youri.querry_1@nxp.com> Signed-off-by: Rohit Raj <rohit.raj@nxp.com> --- drivers/bus/fslmc/qbman/qbman_portal.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_portal.c index 0a2af7be4..77c9d508c 100644 --- a/drivers/bus/fslmc/qbman/qbman_portal.c +++ b/drivers/bus/fslmc/qbman/qbman_portal.c @@ -1201,6 +1201,8 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s, QBMAN_CENA_SWP_EQCR(eqcr_pi & half_mask)); memcpy(&p[1], &cl[1], 28); memcpy(&p[8], &fd[i], sizeof(*fd)); + p[0] = cl[0] | s->eqcr.pi_vb; + if (flags && (flags[i] & QBMAN_ENQUEUE_FLAG_DCA)) { struct qbman_eq_desc *d = (struct qbman_eq_desc *)p; @@ -1208,7 +1210,6 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s, ((flags[i]) & QBMAN_EQCR_DCA_IDXMASK); } eqcr_pi++; - p[0] = cl[0] | s->eqcr.pi_vb; if (!(eqcr_pi & half_mask)) s->eqcr.pi_vb ^= QB_VALID_BIT; -- 2.28.0 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH v3 3/6] net/dpaa2: fix check for key size [not found] ` <20200924040209.32719-1-sachin.saxena@oss.nxp.com> 2020-09-24 4:02 ` [dpdk-stable] [PATCH v3 1/6] " Sachin Saxena (OSS) @ 2020-09-24 4:02 ` Sachin Saxena (OSS) 1 sibling, 0 replies; 4+ messages in thread From: Sachin Saxena (OSS) @ 2020-09-24 4:02 UTC (permalink / raw) To: dev, ferruh.yigit; +Cc: stable From: Apeksha Gupta <apeksha.gupta@nxp.com> DPAA2 has support for raw flow classification, which can be used for any protocol rules. This change fixes flow key pattern length match boundary condition with spec length. Fixes: 3f881f8d6eb0 ("net/dpaa2: support raw flow classification") Cc: stable@dpdk.org Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com> --- drivers/net/dpaa2/dpaa2_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/dpaa2/dpaa2_flow.c index 843021335..29f1f2e65 100644 --- a/drivers/net/dpaa2/dpaa2_flow.c +++ b/drivers/net/dpaa2/dpaa2_flow.c @@ -2901,7 +2901,7 @@ dpaa2_configure_flow_raw(struct rte_flow *flow, flow->tc_id = group; flow->tc_index = attr->priority; - if (prev_key_size < spec->length) { + if (prev_key_size <= spec->length) { ret = dpaa2_flow_extract_add_raw(&priv->extract.qos_key_extract, spec->length); if (ret) { -- 2.28.0 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-24 4:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200911083520.24020-1-sachin.saxena@oss.nxp.com>
2020-09-11 8:35 ` [dpdk-stable] [PATCH v2 1/8] bus/fslmc: fix atomic queues on nxp lx2 platform Sachin Saxena (OSS)
2020-09-14 10:25 ` Hemant Agrawal
[not found] ` <20200924040209.32719-1-sachin.saxena@oss.nxp.com>
2020-09-24 4:02 ` [dpdk-stable] [PATCH v3 1/6] " Sachin Saxena (OSS)
2020-09-24 4:02 ` [dpdk-stable] [PATCH v3 3/6] net/dpaa2: fix check for key size Sachin Saxena (OSS)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).