From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B062AA04BB for ; Tue, 6 Oct 2020 13:23:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A5AABA69; Tue, 6 Oct 2020 13:23:54 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id DB7E7A69 for ; Tue, 6 Oct 2020 13:23:51 +0200 (CEST) IronPort-SDR: PGZWHig53kQ+3plqgSgRrCwK8F93OPuXwlSj/cBdbwJs0QC8s897aV3JpqWmDs5hxvtAJ0Lkva /RyvXvhG5vLw== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="228586587" X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="228586587" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 04:23:50 -0700 IronPort-SDR: mNibX+qU1Abm8T2MrCh59Nph4BkyluSXhaBJtXRLpwVYXF5WAiCm1N62yjXjH+BTMfkJDamJ3u V/tCU9WoW8Wg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="342201606" Received: from silpixa00400352.ir.intel.com ([10.237.213.132]) by fmsmga004.fm.intel.com with ESMTP; 06 Oct 2020 04:23:49 -0700 From: David Coyle To: david.coyle@intel.com, davidcoyle0@gmail.com Cc: stable@dpdk.org Date: Tue, 6 Oct 2020 12:23:47 +0100 Message-Id: <20201006112347.52351-1-david.coyle@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-stable] [PATCH v2] crypto/aesni_mb: fix incorrect clearing of security session X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" When destroying a security session, the AESNI-MB PMD attempted to clear the private aesni_mb session object to remove any key material. However, the function aesni_mb_pmd_sec_sess_destroy() cleared the security session object instead of the private session object. This patch fixes this issue by now clearing the private session object. Fixes: fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol") Cc: stable@dpdk.org Signed-off-by: David Coyle Acked-by: Pablo de Lara --- v2: * CC'ing stable@dpdk.org drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c index 2362f0c3c..b11d7f12b 100644 --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c @@ -911,7 +911,7 @@ aesni_mb_pmd_sec_sess_destroy(void *dev __rte_unused, if (sess_priv) { struct rte_mempool *sess_mp = rte_mempool_from_obj(sess_priv); - memset(sess, 0, sizeof(struct aesni_mb_session)); + memset(sess_priv, 0, sizeof(struct aesni_mb_session)); set_sec_session_private_data(sess, NULL); rte_mempool_put(sess_mp, sess_priv); } -- 2.17.1