From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1009A04BC for ; Thu, 8 Oct 2020 07:24:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 05A151BAA0; Thu, 8 Oct 2020 07:24:02 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 553561B704 for ; Thu, 8 Oct 2020 07:23:44 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20201008052343euoutp01eed892baefeca113b1a7149b9c54a78c~77POII1bj2268722687euoutp01e for ; Thu, 8 Oct 2020 05:23:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20201008052343euoutp01eed892baefeca113b1a7149b9c54a78c~77POII1bj2268722687euoutp01e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1602134623; bh=d2Ivz18BZBFcd9qsptaPD2eCpo7338aFKgdxjhU4CdA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cYqJb/zedW3Z8WoQika2ezWCNwkCRixeJ2EqyjY2Zna5YM7agwbyYj0UHxzzqy8kV 1HVfXj8u/e1FUuyNDZa23yXf6v0/fVr8k6y4MXJeHpFU/UYejJx5oUVyzJCZgbn/l/ TASbJiZeZAor5cloEzLenG7Ip6vVuQ96BJkIdp1Q= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20201008052342eucas1p29ce813c686d9bb5e11d35aaf76d09cb1~77PN1fWSv2346323463eucas1p25; Thu, 8 Oct 2020 05:23:42 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 42.93.06456.E52AE7F5; Thu, 8 Oct 2020 06:23:42 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20201008052342eucas1p2376e75d9ac38f5054ca393b0ef7e663d~77PNIlyse2346323463eucas1p24; Thu, 8 Oct 2020 05:23:42 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20201008052342eusmtrp1d1f37767640eb7ae86714f1313e4b35f~77PNIDmFJ2941629416eusmtrp1T; Thu, 8 Oct 2020 05:23:42 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-46-5f7ea25e6e84 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id B7.89.06314.D52AE7F5; Thu, 8 Oct 2020 06:23:41 +0100 (BST) Received: from Padamandas.fritz.box (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201008052341eusmtip1d707103c1ceac909f7acd97722e17a55~77PMf2LCr2786627866eusmtip1b; Thu, 8 Oct 2020 05:23:41 +0000 (GMT) From: Lukasz Wojciechowski To: David Hunt , Bruce Richardson Cc: dev@dpdk.org, l.wojciechow@partner.samsung.com, stable@dpdk.org Date: Thu, 8 Oct 2020 07:23:15 +0200 Message-Id: <20201008052323.11547-8-l.wojciechow@partner.samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201008052323.11547-1-l.wojciechow@partner.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCIsWRmVeSWpSXmKPExsWy7djP87pxi+riDf4/NrC4screom/SRyaL d5+2M1k861nHaPGv4w+7A6vHrwVLWT0W73nJ5HHw3R6mAOYoLpuU1JzMstQifbsErozOXSfY C55yVVy5HtXA2M3ZxcjJISFgIjFt7me2LkYuDiGBFYwSrS3b2CGcL4wSm6Y9Y4RwPjNKrFy3 hhmm5cDpBqjEckaJQ18OsYAkhAQ+MUpM+2oIYrMJ2EocmfmVFcQWEQiTaG7eC1TDwcEs4Czx 5CsbiCks4CXROjcCpIJFQFXiQ+NsZpAwr4CrxI3/2hCb5CVWbzgAtpVTwE3i7P+7rCBbJQSu s0m0rXjOBFHkIvFr3jsWCFtY4tXxLewQtozE6ck9LBAN2xglrv7+yQjh7GeUuN67AqrKWuLw v99sELdpSqzfpQ8RdpR4uXUr2EESAnwSN94KgoSZgcxJ26ZDhXklOtqEIKr1JJ72TGWEWftn 7ROoczwkVt+ZzQoJqauMEjtuT2WcwCg/C2HZAkbGVYziqaXFuempxYZ5qeV6xYm5xaV56XrJ +bmbGIFxf/rf8U87GL9eSjrEKMDBqMTDa3C0Nl6INbGsuDL3EKMEB7OSCK/T2dNxQrwpiZVV qUX58UWlOanFhxilOViUxHmNF72MFRJITyxJzU5NLUgtgskycXBKNTCacYQ+ijm/7Pd3rdw6 mw3VNZ9/Mm7QKEzZo+S5ZG/uXe3iW8yynKcFbl8w7p25pU8t1OfsbMcl62S09bKf3VwQofBX l/PqqWkCX67vEFtSsroxq8J037V1Dy8mJHQdzFUKe8Ji5nB+UefOrpBpLfznru78uFNhZso2 5YPFdqp7RB6+4T87V1BRiaU4I9FQi7moOBEAn9TBOfcCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKLMWRmVeSWpSXmKPExsVy+t/xu7qxi+riDWbNsrG4screom/SRyaL d5+2M1k861nHaPGv4w+7A6vHrwVLWT0W73nJ5HHw3R6mAOYoPZui/NKSVIWM/OISW6VoQwsj PUNLCz0jE0s9Q2PzWCsjUyV9O5uU1JzMstQifbsEvYzOXSfYC55yVVy5HtXA2M3ZxcjJISFg InHgdANjFyMXh5DAUkaJg6u2snUxcgAlZCQ+XBKAqBGW+HOtiw2i5gOjRP/33ewgCTYBW4kj M7+ygtSLCIRJnFjpDxJmFnCX2LJ4KjNIWFjAS6J1bgRImEVAVeJD42ywMK+Aq8SN/9oQ0+Ul Vm84wAxicwq4SZz9f5cVYlMjo8TN8zPZJjDyLWBkWMUoklpanJueW2yoV5yYW1yal66XnJ+7 iREYhNuO/dy8g/HSxuBDjAIcjEo8vAZHa+OFWBPLiitzDzFKcDArifA6nT0dJ8SbklhZlVqU H19UmpNafIjRFOioicxSosn5wAjJK4k3NDU0t7A0NDc2NzazUBLn7RA4GCMkkJ5YkpqdmlqQ WgTTx8TBKdXAyFf99OHJxQ+3P3BbGiGkzb2g+1rRjKamGTX5Tw22f/3feenPic/zW5sXRUQL PT5YvGlxDU/lKb3+iNXOPdem3rP6nnrsrIiCgZ9f1ItZ8y9VXYnYyj71mE/LkY3rv8er2e2q ip39outd/vZVJ/Jf75xnW+X8dmlFyhzfg6qNncs6XONZU1bu4VZiKc5INNRiLipOBABuWY+1 WAIAAA== X-CMS-MailID: 20201008052342eucas1p2376e75d9ac38f5054ca393b0ef7e663d X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20201008052342eucas1p2376e75d9ac38f5054ca393b0ef7e663d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20201008052342eucas1p2376e75d9ac38f5054ca393b0ef7e663d References: <20200925224209.12173-1-l.wojciechow@partner.samsung.com> <20201008052323.11547-1-l.wojciechow@partner.samsung.com> Subject: [dpdk-stable] [PATCH v5 07/15] distributor: fix return pkt calls in single mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" In the single legacy version of the distributor synchronization requires continues exchange of buffers between distributor and workers. Empty buffers are sent if only handshake synchronization is required. However calls to the rte_distributor_return_pkt() with 0 buffers in single mode were ignored and not passed to the legacy algorithm implementation causing lack of synchronization. This patch fixes this issue by passing NULL as buffer which is a valid way of sending just synchronization handshakes in single mode. Fixes: 775003ad2f96 ("distributor: add new burst-capable library") Cc: david.hunt@intel.com Cc: stable@dpdk.org Signed-off-by: Lukasz Wojciechowski --- lib/librte_distributor/rte_distributor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c index 115443fc0..9fd7dcab7 100644 --- a/lib/librte_distributor/rte_distributor.c +++ b/lib/librte_distributor/rte_distributor.c @@ -168,6 +168,9 @@ rte_distributor_return_pkt(struct rte_distributor *d, if (num == 1) return rte_distributor_return_pkt_single(d->d_single, worker_id, oldpkt[0]); + else if (num == 0) + return rte_distributor_return_pkt_single(d->d_single, + worker_id, NULL); else return -EINVAL; } -- 2.17.1