From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 704A3A04B1 for ; Sat, 10 Oct 2020 18:06:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 613071D970; Sat, 10 Oct 2020 18:06:02 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 3D0131D95E for ; Sat, 10 Oct 2020 18:05:58 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20201010160548euoutp02d55740bceb19aa3b80311246542307ac~8rSZyT5a72851128511euoutp02c for ; Sat, 10 Oct 2020 16:05:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20201010160548euoutp02d55740bceb19aa3b80311246542307ac~8rSZyT5a72851128511euoutp02c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1602345948; bh=faTZS3uOROPHkE9n9BxhsWOgeJZpgrOtfleCwr1/fg8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h6cTNrEK58ZU3KEpM4VfIH5p3WuS3MBh+FEOUq7ONVZZW+oFMPRuscF1SRApzhcjI G23clIShnd85104E72y64ouCfLcQ8fEzSPvHczm/+g1u3r8yi4aolZqYd2aifGESg3 CsBULehjACBYF0iHKNRg+rUKX/B7zB0mSqdFRuXY= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20201010160539eucas1p2f8973a2196b1de2edab58cd0f37e7c26~8rSR5qrbz0179501795eucas1p2t; Sat, 10 Oct 2020 16:05:39 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id FE.B2.06318.3DBD18F5; Sat, 10 Oct 2020 17:05:39 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20201010160538eucas1p19298667f236209cfeaa4745f9bb3aae6~8rSQuNB8P2235322353eucas1p1G; Sat, 10 Oct 2020 16:05:38 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20201010160538eusmtrp25c3e7337650d92e3e8f28bce568dfc72~8rSQtsAUp1692616926eusmtrp2G; Sat, 10 Oct 2020 16:05:38 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-cc-5f81dbd3872a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 55.5A.06314.2DBD18F5; Sat, 10 Oct 2020 17:05:38 +0100 (BST) Received: from Padamandas.fritz.box (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201010160537eusmtip1f95b3e3ada6ed1b790c89bc925c32530~8rSP6H0YZ2442224422eusmtip13; Sat, 10 Oct 2020 16:05:37 +0000 (GMT) From: Lukasz Wojciechowski To: David Hunt , Bruce Richardson Cc: dev@dpdk.org, l.wojciechow@partner.samsung.com, stable@dpdk.org Date: Sat, 10 Oct 2020 18:05:00 +0200 Message-Id: <20201010160508.19709-10-l.wojciechow@partner.samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201010160508.19709-1-l.wojciechow@partner.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGIsWRmVeSWpSXmKPExsWy7djPc7qXbzfGGzT9kbW4screom/SRyaL d5+2M1k861nHaPGv4w+7A6vHrwVLWT0W73nJ5HHw3R6mAOYoLpuU1JzMstQifbsErowvt5uY Cl7wVLw7fJ6pgfEVVxcjJ4eEgIlEe+9C5i5GLg4hgRWMElMnnmSEcL4wShxZ08sE4XxmlJj1 6gUTTMvm0xPAbCGB5YwSu1blQBR9YpRYd/AOO0iCTcBW4sjMr6wgtohAmERz816WLkYODmYB Z4knX9lATGEBB4nra2NBKlgEVCWWv/wCNpJXwE1i8uPnUKvkJVZvOMAMYnMCxc92HWQDWSUh cJ1NYuvEdqgiF4mWDVtZIWxhiVfHt7BD2DIS/3fOZ4Jo2MYocfX3T0YIZz+jxPXeFVBV1hKH //1mgzhOU2L9Ln2IsKPEqo8XGUHCEgJ8EjfeCoKEmYHMSdumM0OEeSU62oQgqvUknvZMZYRZ +2ftExYI20Pi8Olp0DC8yiixoLOXcQKj/CyEZQsYGVcxiqeWFuempxYb56WW6xUn5haX5qXr JefnbmIExv7pf8e/7mDc9yfpEKMAB6MSD++B443xQqyJZcWVuYcYJTiYlUR4nc6ejhPiTUms rEotyo8vKs1JLT7EKM3BoiTOa7zoZayQQHpiSWp2ampBahFMlomDU6qBcf2XUz/bVVedOPX2 4aOQr0FlwQkb53pxhoccajq2MKO5UVvLNOl6ac6upzfKgu2/vDSPWZR4hCnz5jvflhM7s9Nm 820O06lav+bz9OofW5etDmP+VSty+uhFXZ11wv16T6deLkpTvc3Q+/TQiwsVHdM2ut28YmF5 eMXxPZHPtflXtDoJrHxy6LASS3FGoqEWc1FxIgAuAqoA+QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOLMWRmVeSWpSXmKPExsVy+t/xu7qXbjfGG7y+KGxxY5W9Rd+kj0wW 7z5tZ7J41rOO0eJfxx92B1aPXwuWsnos3vOSyePguz1MAcxRejZF+aUlqQoZ+cUltkrRhhZG eoaWFnpGJpZ6hsbmsVZGpkr6djYpqTmZZalF+nYJehlfbjcxFbzgqXh3+DxTA+Mrri5GTg4J AROJzacnMHUxcnEICSxllFhzvJOti5EDKCEj8eGSAESNsMSfa11sEDUfGCVWLtvABpJgE7CV ODLzKytIvYhAmMSJlf4gYWYBd4kti6cyg4SFBRwkrq+NBQmzCKhKLH/5hQnE5hVwk5j8+DkT xHh5idUbDjCD2JxA8bNdB6FWNTJKnLh9k20CI98CRoZVjCKppcW56bnFhnrFibnFpXnpesn5 uZsYgYG47djPzTsYL20MPsQowMGoxMMrcaoxXog1say4MvcQowQHs5IIr9PZ03FCvCmJlVWp RfnxRaU5qcWHGE2BrprILCWanA+MkrySeENTQ3MLS0NzY3NjMwslcd4OgYMxQgLpiSWp2amp BalFMH1MHJxSDYxs2bs6zrq+vXyobJrd13Ph+5KnvlgT6zn763+vuN51VbG7q1lflh1WnMCm oPy4/hPzeq0o5aVbf5dPDjoSebzKrKX+XkriWssJbgENnkUPVm7NTy9xWGoY+PvnBdGl7x9M 1bt3hP1drubHtLRJ/CtXuSephb3x/rvo/S69d44CGaevBvWmBrxVYinOSDTUYi4qTgQAD7Vj HVoCAAA= X-CMS-MailID: 20201010160538eucas1p19298667f236209cfeaa4745f9bb3aae6 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20201010160538eucas1p19298667f236209cfeaa4745f9bb3aae6 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20201010160538eucas1p19298667f236209cfeaa4745f9bb3aae6 References: <20201009220202.20834-1-l.wojciechow@partner.samsung.com> <20201010160508.19709-1-l.wojciechow@partner.samsung.com> Subject: [dpdk-stable] [PATCH v7 09/16] test/distributor: collect return mbufs X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" During quit_workers function distributor's main core processes some packets to wake up pending worker cores so they can quit. As quit_workers acts also as a cleanup procedure for next test case it should also collect these packages returned by workers' handlers, so the cyclic buffer with returned packets in distributor remains empty. Fixes: c3eabff124e6 ("distributor: add unit tests") Cc: bruce.richardson@intel.com Fixes: c0de0eb82e40 ("distributor: switch over to new API") Cc: david.hunt@intel.com Cc: stable@dpdk.org Signed-off-by: Lukasz Wojciechowski Acked-by: David Hunt --- app/test/test_distributor.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c index 06e01ff9d..ed03040d1 100644 --- a/app/test/test_distributor.c +++ b/app/test/test_distributor.c @@ -590,6 +590,7 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p) const unsigned num_workers = rte_lcore_count() - 1; unsigned i; struct rte_mbuf *bufs[RTE_MAX_LCORE]; + struct rte_mbuf *returns[RTE_MAX_LCORE]; if (rte_mempool_get_bulk(p, (void *)bufs, num_workers) != 0) { printf("line %d: Error getting mbufs from pool\n", __LINE__); return; @@ -605,6 +606,10 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p) rte_distributor_flush(d); rte_eal_mp_wait_lcore(); + while (rte_distributor_returned_pkts(d, returns, RTE_MAX_LCORE)) + ; + + rte_distributor_clear_returns(d); rte_mempool_put_bulk(p, (void *)bufs, num_workers); quit = 0; -- 2.17.1