From: "Gaëtan Rivet" <grive@u256.net>
To: Long Li <longli@linuxonhyperv.com>
Cc: dev@dpdk.org, Long Li <longli@microsoft.com>, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/failsafe: check correct error code while handling sub-device add
Date: Thu, 15 Oct 2020 12:11:42 +0200 [thread overview]
Message-ID: <20201015101142.or6nuf675qtwgmws@u256.net> (raw)
In-Reply-To: <1601683308-18738-1-git-send-email-longli@linuxonhyperv.com>
On 02/10/20 17:01 -0700, Long Li wrote:
> From: Long Li <longli@microsoft.com>
>
> When adding a sub-device, it's possible that the sub-device is configured
> successfully but later fails to start. This error should not be masked.
> The driver needs to check the error status to prevent endless loop of
> trying to start the sub-device.
>
> fixes (ae80146c5a1b net/failsafe: fix removed device handling)
>
> cc: stable@dpdk.org
> Signed-off-by: Long Li <longli@microsoft.com>
> ---
> drivers/net/failsafe/failsafe_private.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h
> index 651578a..c58c0de 100644
> --- a/drivers/net/failsafe/failsafe_private.h
> +++ b/drivers/net/failsafe/failsafe_private.h
> @@ -497,7 +497,7 @@ int failsafe_eth_new_event_callback(uint16_t port_id,
> fs_err(struct sub_device *sdev, int err)
> {
> /* A device removal shouldn't be reported as an error. */
> - if (sdev->remove == 1 || err == -EIO)
> + if (sdev->remove == 1 && err == -EIO)
> return rte_errno = 0;
> return err;
> }
> --
> 1.8.3.1
>
This bug has been fixed by the following commit:
http://mails.dpdk.org/archives/dev/2020-October/185921.html
Thanks for validating this other fix Li, it has been
integrated.
This patch can be dropped (nack).
--
Gaëtan
prev parent reply other threads:[~2020-10-15 10:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 0:01 Long Li
2020-10-05 9:42 ` Gaëtan Rivet
2020-10-09 16:20 ` [dpdk-stable] [dpdk-dev] " Gaëtan Rivet
2020-10-09 20:30 ` Long Li
2020-10-12 14:22 ` Gaëtan Rivet
2020-10-13 17:14 ` Long Li
2020-10-15 10:11 ` Gaëtan Rivet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015101142.or6nuf675qtwgmws@u256.net \
--to=grive@u256.net \
--cc=dev@dpdk.org \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).