From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10E41A04DB for ; Fri, 16 Oct 2020 11:06:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE2141EBC6; Fri, 16 Oct 2020 11:06:26 +0200 (CEST) Received: from relay.smtp-ext.broadcom.com (saphodev.broadcom.com [192.19.232.172]) by dpdk.org (Postfix) with ESMTP id 9D52D1EB9A for ; Fri, 16 Oct 2020 11:06:24 +0200 (CEST) Received: from dhcp-10-123-153-22.dhcp.broadcom.net (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 988E5829C for ; Fri, 16 Oct 2020 02:06:22 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 988E5829C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1602839183; bh=60vjm6KHfhVgVY65RaDDvDDPSYwRZwqfgSJHHDPwsg8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=E+SA3DWJhSoHqN08Qxrqr732U9id2O412zTr64Gl+zUi+uJAXQDAkB1m5I0Qpd09f S6s+mbBRoU08f/vP+vYHZdr5jHQkNvDFRdLo3Mc2v9fXyVl/ra3syLQy9DbU6pKdq/ H/41XIFDpoDManz1fmkU/Ynq1zbW3cLVB7j/RA2c= From: Kalesh A P To: stable@dpdk.org Date: Fri, 16 Oct 2020 14:50:47 +0530 Message-Id: <20201016092047.30846-4-kalesh-anakkur.purayil@broadcom.com> X-Mailer: git-send-email 2.10.1 In-Reply-To: <20201016092047.30846-1-kalesh-anakkur.purayil@broadcom.com> References: <20201016092047.30846-1-kalesh-anakkur.purayil@broadcom.com> Subject: [dpdk-stable] [PATCH 18.11 3/3] net/bnxt: fix flow error on filter creation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" From: Kalesh AP [ upstream commit 87aefef133e3d670be365efdaa620f36d97ee4bd ] If set_em_filter/set_ntuple_filter cmds fails for some reason, driver is not filling the "rte_flow_error" string buffer. This leads to a crash in testpmd while trying to print the error message. Fixes: 5c1171c97216 ("net/bnxt: refactor filter/flow") Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_flow.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index df962d9..8d0483b 100644 --- a/drivers/net/bnxt/bnxt_flow.c +++ b/drivers/net/bnxt/bnxt_flow.c @@ -1055,12 +1055,24 @@ bnxt_flow_create(struct rte_eth_dev *dev, filter->enables |= HWRM_CFA_EM_FLOW_ALLOC_INPUT_ENABLES_L2_FILTER_ID; ret = bnxt_hwrm_set_em_filter(bp, filter->dst_id, filter); + if (ret != 0) { + rte_flow_error_set(error, -ret, + RTE_FLOW_ERROR_TYPE_HANDLE, NULL, + "Failed to create EM filter"); + goto free_filter; + } } if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER) { filter->enables |= HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_L2_FILTER_ID; ret = bnxt_hwrm_set_ntuple_filter(bp, filter->dst_id, filter); + if (ret != 0) { + rte_flow_error_set(error, -ret, + RTE_FLOW_ERROR_TYPE_HANDLE, NULL, + "Failed to create ntuple filter"); + goto free_filter; + } } for (i = 0; i < bp->nr_vnics; i++) { -- 2.10.1