* [dpdk-stable] [PATCH 03/15] mbuf: fix typo in dynamic field convention note
[not found] <20201026052105.1561859-1-thomas@monjalon.net>
@ 2020-10-26 5:20 ` Thomas Monjalon
2020-10-26 14:26 ` Andrew Rybchenko
[not found] ` <20201026222013.2147904-1-thomas@monjalon.net>
` (4 subsequent siblings)
5 siblings, 1 reply; 7+ messages in thread
From: Thomas Monjalon @ 2020-10-26 5:20 UTC (permalink / raw)
To: dev
Cc: ferruh.yigit, david.marchand, bruce.richardson, olivier.matz,
andrew.rybchenko, akhil.goyal, stable, Konstantin Ananyev
Replace "in a in PMD" with "in a PMD".
Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/librte_mbuf/rte_mbuf_dyn.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_mbuf/rte_mbuf_dyn.h b/lib/librte_mbuf/rte_mbuf_dyn.h
index 8407230ecf..0ebac88b83 100644
--- a/lib/librte_mbuf/rte_mbuf_dyn.h
+++ b/lib/librte_mbuf/rte_mbuf_dyn.h
@@ -62,7 +62,7 @@
* conventions than function names in dpdk:
* - "rte_mbuf_dynfield_<name>" if defined in mbuf library
* - "rte_<libname>_dynfield_<name>" if defined in another library
- * - "rte_net_<pmd>_dynfield_<name>" if defined in a in PMD
+ * - "rte_net_<pmd>_dynfield_<name>" if defined in a PMD
* - any name that does not start with "rte_" in an application
*/
--
2.28.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [PATCH 03/15] mbuf: fix typo in dynamic field convention note
2020-10-26 5:20 ` [dpdk-stable] [PATCH 03/15] mbuf: fix typo in dynamic field convention note Thomas Monjalon
@ 2020-10-26 14:26 ` Andrew Rybchenko
0 siblings, 0 replies; 7+ messages in thread
From: Andrew Rybchenko @ 2020-10-26 14:26 UTC (permalink / raw)
To: Thomas Monjalon, dev
Cc: ferruh.yigit, david.marchand, bruce.richardson, olivier.matz,
akhil.goyal, stable, Konstantin Ananyev
On 10/26/20 8:20 AM, Thomas Monjalon wrote:
> Replace "in a in PMD" with "in a PMD".
>
> Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-stable] [PATCH v2 03/15] mbuf: fix typo in dynamic field convention note
[not found] ` <20201026222013.2147904-1-thomas@monjalon.net>
@ 2020-10-26 22:20 ` Thomas Monjalon
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2020-10-26 22:20 UTC (permalink / raw)
To: dev
Cc: ferruh.yigit, david.marchand, bruce.richardson, olivier.matz,
andrew.rybchenko, akhil.goyal, stable, Konstantin Ananyev
Replace "in a in PMD" with "in a PMD".
Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
lib/librte_mbuf/rte_mbuf_dyn.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_mbuf/rte_mbuf_dyn.h b/lib/librte_mbuf/rte_mbuf_dyn.h
index 8407230ecf..0ebac88b83 100644
--- a/lib/librte_mbuf/rte_mbuf_dyn.h
+++ b/lib/librte_mbuf/rte_mbuf_dyn.h
@@ -62,7 +62,7 @@
* conventions than function names in dpdk:
* - "rte_mbuf_dynfield_<name>" if defined in mbuf library
* - "rte_<libname>_dynfield_<name>" if defined in another library
- * - "rte_net_<pmd>_dynfield_<name>" if defined in a in PMD
+ * - "rte_net_<pmd>_dynfield_<name>" if defined in a PMD
* - any name that does not start with "rte_" in an application
*/
--
2.28.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-stable] [PATCH v3 03/15] mbuf: fix typo in dynamic field convention note
[not found] ` <20201027210115.2529025-1-thomas@monjalon.net>
@ 2020-10-27 21:01 ` Thomas Monjalon
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2020-10-27 21:01 UTC (permalink / raw)
To: dev
Cc: ferruh.yigit, david.marchand, bruce.richardson, olivier.matz,
andrew.rybchenko, akhil.goyal, stable, Konstantin Ananyev
Replace "in a in PMD" with "in a PMD".
Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
lib/librte_mbuf/rte_mbuf_dyn.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_mbuf/rte_mbuf_dyn.h b/lib/librte_mbuf/rte_mbuf_dyn.h
index 8407230ecf..0ebac88b83 100644
--- a/lib/librte_mbuf/rte_mbuf_dyn.h
+++ b/lib/librte_mbuf/rte_mbuf_dyn.h
@@ -62,7 +62,7 @@
* conventions than function names in dpdk:
* - "rte_mbuf_dynfield_<name>" if defined in mbuf library
* - "rte_<libname>_dynfield_<name>" if defined in another library
- * - "rte_net_<pmd>_dynfield_<name>" if defined in a in PMD
+ * - "rte_net_<pmd>_dynfield_<name>" if defined in a PMD
* - any name that does not start with "rte_" in an application
*/
--
2.28.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-stable] [PATCH v4 03/15] mbuf: fix typo in dynamic field convention note
[not found] ` <20201028102640.3191964-1-thomas@monjalon.net>
@ 2020-10-28 10:26 ` Thomas Monjalon
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2020-10-28 10:26 UTC (permalink / raw)
To: dev
Cc: ferruh.yigit, david.marchand, bruce.richardson, olivier.matz,
andrew.rybchenko, akhil.goyal, stable, Konstantin Ananyev
Replace "in a in PMD" with "in a PMD".
Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
lib/librte_mbuf/rte_mbuf_dyn.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_mbuf/rte_mbuf_dyn.h b/lib/librte_mbuf/rte_mbuf_dyn.h
index 8407230ecf..0ebac88b83 100644
--- a/lib/librte_mbuf/rte_mbuf_dyn.h
+++ b/lib/librte_mbuf/rte_mbuf_dyn.h
@@ -62,7 +62,7 @@
* conventions than function names in dpdk:
* - "rte_mbuf_dynfield_<name>" if defined in mbuf library
* - "rte_<libname>_dynfield_<name>" if defined in another library
- * - "rte_net_<pmd>_dynfield_<name>" if defined in a in PMD
+ * - "rte_net_<pmd>_dynfield_<name>" if defined in a PMD
* - any name that does not start with "rte_" in an application
*/
--
2.28.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-stable] [PATCH v5 07/15] net/mlx5: fix dynamic mbuf offset lookup check
[not found] ` <20201030172940.1073558-1-thomas@monjalon.net>
@ 2020-10-30 17:29 ` Thomas Monjalon
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2020-10-30 17:29 UTC (permalink / raw)
To: dev
Cc: ferruh.yigit, david.marchand, bruce.richardson, olivier.matz,
andrew.rybchenko, akhil.goyal, jerinj, stable, Matan Azrad,
Shahaf Shuler, Viacheslav Ovsiienko, Ori Kam
The functions rte_mbuf_dynfield_lookup() and rte_mbuf_dynflag_lookup()
can return an offset starting with 0 or a negative error code.
In reality the first offsets are probably reserved forever,
but for the sake of strict API compliance,
the checks which considered 0 as an error are fixed.
Fixes: efa79e68c8cd ("net/mlx5: support fine grain dynamic flag")
Fixes: 3172c471b86f ("net/mlx5: prepare Tx queue structures to support timestamp")
Fixes: 0febfcce3693 ("net/mlx5: prepare Tx to support scheduling")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/net/mlx5/mlx5_rxtx.c | 4 ++--
drivers/net/mlx5/mlx5_trigger.c | 2 +-
drivers/net/mlx5/mlx5_txq.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index b530ff421f..e86468b67a 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -5661,9 +5661,9 @@ mlx5_select_tx_function(struct rte_eth_dev *dev)
}
if (tx_offloads & DEV_TX_OFFLOAD_SEND_ON_TIMESTAMP &&
rte_mbuf_dynflag_lookup
- (RTE_MBUF_DYNFLAG_TX_TIMESTAMP_NAME, NULL) > 0 &&
+ (RTE_MBUF_DYNFLAG_TX_TIMESTAMP_NAME, NULL) >= 0 &&
rte_mbuf_dynfield_lookup
- (RTE_MBUF_DYNFIELD_TIMESTAMP_NAME, NULL) > 0) {
+ (RTE_MBUF_DYNFIELD_TIMESTAMP_NAME, NULL) >= 0) {
/* Offload configured, dynamic entities registered. */
olx |= MLX5_TXOFF_CONFIG_TXPP;
}
diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c
index 7735f022a3..917b433c4a 100644
--- a/drivers/net/mlx5/mlx5_trigger.c
+++ b/drivers/net/mlx5/mlx5_trigger.c
@@ -302,7 +302,7 @@ mlx5_dev_start(struct rte_eth_dev *dev)
DRV_LOG(DEBUG, "port %u starting device", dev->data->port_id);
fine_inline = rte_mbuf_dynflag_lookup
(RTE_PMD_MLX5_FINE_GRANULARITY_INLINE, NULL);
- if (fine_inline > 0)
+ if (fine_inline >= 0)
rte_net_mlx5_dynf_inline_mask = 1UL << fine_inline;
else
rte_net_mlx5_dynf_inline_mask = 0;
diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
index af84f5f72b..8ed2bcff7b 100644
--- a/drivers/net/mlx5/mlx5_txq.c
+++ b/drivers/net/mlx5/mlx5_txq.c
@@ -1305,7 +1305,7 @@ mlx5_txq_dynf_timestamp_set(struct rte_eth_dev *dev)
(RTE_MBUF_DYNFLAG_TX_TIMESTAMP_NAME, NULL);
off = rte_mbuf_dynfield_lookup
(RTE_MBUF_DYNFIELD_TIMESTAMP_NAME, NULL);
- if (nbit > 0 && off >= 0 && sh->txpp.refcnt)
+ if (nbit >= 0 && off >= 0 && sh->txpp.refcnt)
mask = 1ULL << nbit;
for (i = 0; i != priv->txqs_n; ++i) {
data = (*priv->txqs)[i];
--
2.28.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-stable] [PATCH v6 03/15] mbuf: fix typo in dynamic field convention note
[not found] ` <20201030174441.1076264-1-thomas@monjalon.net>
@ 2020-10-30 17:44 ` Thomas Monjalon
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2020-10-30 17:44 UTC (permalink / raw)
To: dev
Cc: ferruh.yigit, david.marchand, bruce.richardson, olivier.matz,
andrew.rybchenko, akhil.goyal, jerinj, stable,
Konstantin Ananyev
Replace "in a in PMD" with "in a PMD".
Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
lib/librte_mbuf/rte_mbuf_dyn.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_mbuf/rte_mbuf_dyn.h b/lib/librte_mbuf/rte_mbuf_dyn.h
index 8407230ecf..0ebac88b83 100644
--- a/lib/librte_mbuf/rte_mbuf_dyn.h
+++ b/lib/librte_mbuf/rte_mbuf_dyn.h
@@ -62,7 +62,7 @@
* conventions than function names in dpdk:
* - "rte_mbuf_dynfield_<name>" if defined in mbuf library
* - "rte_<libname>_dynfield_<name>" if defined in another library
- * - "rte_net_<pmd>_dynfield_<name>" if defined in a in PMD
+ * - "rte_net_<pmd>_dynfield_<name>" if defined in a PMD
* - any name that does not start with "rte_" in an application
*/
--
2.28.0
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-30 17:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201026052105.1561859-1-thomas@monjalon.net>
2020-10-26 5:20 ` [dpdk-stable] [PATCH 03/15] mbuf: fix typo in dynamic field convention note Thomas Monjalon
2020-10-26 14:26 ` Andrew Rybchenko
[not found] ` <20201026222013.2147904-1-thomas@monjalon.net>
2020-10-26 22:20 ` [dpdk-stable] [PATCH v2 " Thomas Monjalon
[not found] ` <20201027210115.2529025-1-thomas@monjalon.net>
2020-10-27 21:01 ` [dpdk-stable] [PATCH v3 " Thomas Monjalon
[not found] ` <20201028102640.3191964-1-thomas@monjalon.net>
2020-10-28 10:26 ` [dpdk-stable] [PATCH v4 " Thomas Monjalon
[not found] ` <20201030172940.1073558-1-thomas@monjalon.net>
2020-10-30 17:29 ` [dpdk-stable] [PATCH v5 07/15] net/mlx5: fix dynamic mbuf offset lookup check Thomas Monjalon
[not found] ` <20201030174441.1076264-1-thomas@monjalon.net>
2020-10-30 17:44 ` [dpdk-stable] [PATCH v6 03/15] mbuf: fix typo in dynamic field convention note Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).