From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C89CA04DD for ; Wed, 28 Oct 2020 11:51:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 73632CA06; Wed, 28 Oct 2020 11:51:58 +0100 (CET) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by dpdk.org (Postfix) with ESMTP id 4FEC5CA06 for ; Wed, 28 Oct 2020 11:51:56 +0100 (CET) Received: by mail-wm1-f41.google.com with SMTP id c16so4310226wmd.2 for ; Wed, 28 Oct 2020 03:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aiXH1eHXagOBtW9hT2xsnXdCXtYZzm0MOlYLsYqaLws=; b=U2O9vwb2BROxbLrryUhANJ7lKW23B0dOSuDSKOvMqrBxsbOmIgyk/kECjuDAuK2Sjp 7oEuHmkeFH0bh45+dHg/zBj2mAYnTl7EKHn/nPEJ9+7e6t34DjON+WL5n21OmhedBQl8 32Daec6LLfmzO7ycZf+MMaKqA55PInuNR0PMDek1/n90hOx+hBO/PPiNHbTmlpmZkp2I EET61zDSGy6MEKRlo+YrEKofr46XHUeHfnQYcG6p6LJY+0aED3phZquOtqNTvxJWuwgB ZuMs+zH6NWQNyGtLokG0BxGPldklW5wKVDnqi0j4oxZCKCxdPYc60Ql2EMJvFzK9+l3v pWZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aiXH1eHXagOBtW9hT2xsnXdCXtYZzm0MOlYLsYqaLws=; b=T3RBkNdCCHmmbPrNtaTLsK4uRtpiayxgjO4KUJjfLYY89bEJBMx30nI97o/a3fZoMd BR5lXZQLdkTl5rOGgvj7oN1WpEKSdRADQV60Mj/rqYExYlxUZ46C1KPBAj4DLr1++/s7 N1uSrOdmqW67Nd0jnn0jWiwDVfdT9Q3NKgl8ujy6jwTlhF5zBPGue8Fi6ydRpVqbE9Vv IDRV8TFq3z/mXHabIr3WDDzJlPQsjGJN0P1YkFwY3qAQvs/VBKbRvyfctjahBTcTdCAv eYE92CRWT5u5rKtaxNkXI8jlDcBlMN/QCEwFM9GSqSncpjasF7hQGP7DgF1GaH3dpLUZ clNQ== X-Gm-Message-State: AOAM530o9E0CF2MhS/0zUMb0Qi6c+P3ppefbaU2oIT23pVlgTAM0HIaJ b9eFZ3gM1+KQy4wAZbliIYU= X-Google-Smtp-Source: ABdhPJzoJZUIZLR5ULkft076/O8cD54ULFCSgHIRQYB/rABjJmJdQ6sQ7azdmCb6u1f9u9gDvIMhqQ== X-Received: by 2002:a7b:cc85:: with SMTP id p5mr7284368wma.24.1603882315036; Wed, 28 Oct 2020 03:51:55 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id s2sm6119550wmf.45.2020.10.28.03.51.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:51:54 -0700 (PDT) From: luca.boccassi@gmail.com To: Lukasz Wojciechowski Cc: Hemant Agrawal , dpdk stable Date: Wed, 28 Oct 2020 10:44:29 +0000 Message-Id: <20201028104606.3504127-110-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'raw/skeleton: reset test statistics' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From d8d56bd8c2c7c1053226fb124f9976bea516f22d Mon Sep 17 00:00:00 2001 From: Lukasz Wojciechowski Date: Mon, 21 Sep 2020 23:44:19 +0200 Subject: [PATCH] raw/skeleton: reset test statistics [ upstream commit 22b5c63ed13fbae5934a312cba657ec1901f7539 ] Statistics: passed, failed, unsupported and total are kept in global static variables. As global variables they are initiated with zeroes. However running test multiple times cumulates results from previous calls. This patch resets statistics with zeroes in testsuite_setup(). To reproduce issue fixed by this patch, run rawdev_autotest command in dpdk-test app multiple times. Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") Signed-off-by: Lukasz Wojciechowski Acked-by: Hemant Agrawal --- drivers/raw/skeleton/skeleton_rawdev_test.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/raw/skeleton/skeleton_rawdev_test.c b/drivers/raw/skeleton/skeleton_rawdev_test.c index 9ecfdee818..1190e28bb7 100644 --- a/drivers/raw/skeleton/skeleton_rawdev_test.c +++ b/drivers/raw/skeleton/skeleton_rawdev_test.c @@ -42,6 +42,12 @@ static int testsuite_setup(void) { uint8_t count; + + total = 0; + passed = 0; + failed = 0; + unsupported = 0; + count = rte_rawdev_count(); if (!count) { SKELDEV_TEST_INFO("\tNo existing rawdev; " -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:15.181852064 +0000 +++ 0110-raw-skeleton-reset-test-statistics.patch 2020-10-28 10:35:11.664832379 +0000 @@ -1,8 +1,10 @@ -From 22b5c63ed13fbae5934a312cba657ec1901f7539 Mon Sep 17 00:00:00 2001 +From d8d56bd8c2c7c1053226fb124f9976bea516f22d Mon Sep 17 00:00:00 2001 From: Lukasz Wojciechowski Date: Mon, 21 Sep 2020 23:44:19 +0200 Subject: [PATCH] raw/skeleton: reset test statistics +[ upstream commit 22b5c63ed13fbae5934a312cba657ec1901f7539 ] + Statistics: passed, failed, unsupported and total are kept in global static variables. As global variables they are initiated with zeroes. However running test multiple times cumulates results @@ -14,7 +16,6 @@ in dpdk-test app multiple times. Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") -Cc: stable@dpdk.org Signed-off-by: Lukasz Wojciechowski Acked-by: Hemant Agrawal @@ -23,7 +24,7 @@ 1 file changed, 6 insertions(+) diff --git a/drivers/raw/skeleton/skeleton_rawdev_test.c b/drivers/raw/skeleton/skeleton_rawdev_test.c -index bb4b6efe40..1405df080d 100644 +index 9ecfdee818..1190e28bb7 100644 --- a/drivers/raw/skeleton/skeleton_rawdev_test.c +++ b/drivers/raw/skeleton/skeleton_rawdev_test.c @@ -42,6 +42,12 @@ static int