From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8059A04DD for ; Wed, 28 Oct 2020 11:54:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D01FACA37; Wed, 28 Oct 2020 11:54:33 +0100 (CET) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 3AAFDCA37 for ; Wed, 28 Oct 2020 11:54:31 +0100 (CET) Received: by mail-wr1-f65.google.com with SMTP id t9so5133276wrq.11 for ; Wed, 28 Oct 2020 03:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hwk7E7H7TEdl+At/9dheT3jTA1Y5IoZOsbSYinIsCz0=; b=oBrtTyqCFyPnjNCs6bmchIOMNvUgfX4N8yXb12PG4H7fgvcmFYr9ZznfYIgiqELflT bevz3+1aik5BPULzm9PPTib9MogGNCatBbHFMN7aksr4kl4ACT1uDqFSFw9IJexfWPGN DbJb/wQZX6YQVeZomA7ymTduNw0xN+kLm5biegk66bDKd6Zyao5s8tZBZhTlomlm9Mn0 DKYQChwwi23zqFcNnk3RnWLk0DHJ+7NK6pPxA/mtQNiDx/QSXCN+oaxssbpqidfpQadI 8PGntYyfJaUrKXDW3JBZQ0IzRYzT8ig25A4H7snlFSc9Zv7RvDWozX8u6oIk6qkqjC8o UIWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hwk7E7H7TEdl+At/9dheT3jTA1Y5IoZOsbSYinIsCz0=; b=s3CAzok/GVPqJ4fBwCxRIkQW+rKELkW1ApdzMTUU8i8f7DF+cVRmtz78E5VfEHeStv yB+PgoCTPLuHwy0TAa1czQud/SGqJ1rNhw0sdjMk8VAE0iJ/Z4D7GpHrx9n7WUbRvvJg IXoA4PItirYSEMXqd+1YAqnoiNWbU9giYYCkgU1oQECONH300uSZWwz9kV8G1YBtP6Ag frgDwSwzL6Gy3D7jJHtpsdKnzj03mDbStGKSp+PfD5JoVLZ3cd/wOu6uvugHcFbjP0V6 L7cxzuvLgG+1zx356wgMw0rJeC71I8zS+eWzv/Q1rzwL1fbxS+EQamSkv82/IdT0poVX J45A== X-Gm-Message-State: AOAM532AzadZSaB+WIhIxospY93XImG8EQ0sKIP9tr1vVjfuJuA0a4bx k9nAgC9gTWRhKlms3V9APGA= X-Google-Smtp-Source: ABdhPJy1bNWhBy0Xw2mje0SgRhJXM7mfhdxp80ZdnV45tzCoQvUepv0xsEM+W4WdPZeE6+YogpEJLg== X-Received: by 2002:a5d:5701:: with SMTP id a1mr8078679wrv.414.1603882470955; Wed, 28 Oct 2020 03:54:30 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id e5sm6100153wrw.93.2020.10.28.03.54.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:54:30 -0700 (PDT) From: luca.boccassi@gmail.com To: Yunjian Wang Cc: Nipun Gupta , dpdk stable Date: Wed, 28 Oct 2020 10:45:16 +0000 Message-Id: <20201028104606.3504127-157-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'event/dpaa2: fix dereference before null check' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From ace6739983f23a71f7a61757544413fcd19b3e6d Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Wed, 26 Aug 2020 21:07:40 +0800 Subject: [PATCH] event/dpaa2: fix dereference before null check [ upstream commit db5e0e7aea5e256c43489a3b272a4318b6ddca9f ] Coverity flags that 'portal' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 323516 Fixes: 4ab57b042e7c ("event/dpaa2: affine portal at runtime during I/O") Signed-off-by: Yunjian Wang Acked-by: Nipun Gupta --- drivers/event/dpaa2/dpaa2_eventdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index ede7b01618..5ae76d4d9d 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/drivers/event/dpaa2/dpaa2_eventdev.c @@ -567,14 +567,14 @@ dpaa2_eventdev_port_release(void *port) EVENTDEV_INIT_FUNC_TRACE(); + if (portal == NULL) + return; + /* TODO: Cleanup is required when ports are in linked state. */ if (portal->is_port_linked) DPAA2_EVENTDEV_WARN("Event port must be unlinked before release"); - if (portal) - rte_free(portal); - - portal = NULL; + rte_free(portal); } static int -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:16.609168481 +0000 +++ 0157-event-dpaa2-fix-dereference-before-null-check.patch 2020-10-28 10:35:11.752833674 +0000 @@ -1,14 +1,15 @@ -From db5e0e7aea5e256c43489a3b272a4318b6ddca9f Mon Sep 17 00:00:00 2001 +From ace6739983f23a71f7a61757544413fcd19b3e6d Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Wed, 26 Aug 2020 21:07:40 +0800 Subject: [PATCH] event/dpaa2: fix dereference before null check +[ upstream commit db5e0e7aea5e256c43489a3b272a4318b6ddca9f ] + Coverity flags that 'portal' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 323516 Fixes: 4ab57b042e7c ("event/dpaa2: affine portal at runtime during I/O") -Cc: stable@dpdk.org Signed-off-by: Yunjian Wang Acked-by: Nipun Gupta @@ -17,10 +18,10 @@ 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c -index 3ae4441ee3..f7383ca738 100644 +index ede7b01618..5ae76d4d9d 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/drivers/event/dpaa2/dpaa2_eventdev.c -@@ -569,14 +569,14 @@ dpaa2_eventdev_port_release(void *port) +@@ -567,14 +567,14 @@ dpaa2_eventdev_port_release(void *port) EVENTDEV_INIT_FUNC_TRACE();