From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29D4CA04DD for ; Wed, 28 Oct 2020 11:55:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 19B0ECA9B; Wed, 28 Oct 2020 11:55:08 +0100 (CET) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by dpdk.org (Postfix) with ESMTP id BDB11CA8F for ; Wed, 28 Oct 2020 11:55:05 +0100 (CET) Received: by mail-wm1-f41.google.com with SMTP id k21so3006203wmi.1 for ; Wed, 28 Oct 2020 03:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QFk1fjqXX8jaC4/mo03s78QpnkzVPHVvp5Ep2VYM7WY=; b=isUgihalz3xNIi0Mj7z3mxNW62UIFBJJAjRkrf5kszz95VTeoKVq9dyI12NExEB7Yv JGa7t1NixMfOdZxTJNxWpLK7AfPZZi4+ZpV+j7oxTRYXmQXUw1NWCwLIW7mMZLBcY+HP s0ym/AJ4YnuAt5w4Hqdo+aNHKmQRhm8zpnUIc3xtnqlTUzz0XugxOV/MB/WhibFhuLtu lybOlAbe/IS+IZQfiMM7b1+lgy0ZLhsbXmN0ru+jIfjgAaMZ5yYxJc/hNRxJkYsHQv2y /iNKxSoyIfs9+SVk+BsmY7ze7aEg2VZFBwS4+b/PV5crsh3yYN8B64FTWbEkZiR7d7/X UuHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QFk1fjqXX8jaC4/mo03s78QpnkzVPHVvp5Ep2VYM7WY=; b=EzMjvnTb/CakbkCN7U2Oi2lQrxzehSUzuvBxiTbLZzX9FwvalkHm7ElerE+F1M1mSY C6jl8j9/9m1KwQFJ9QSxJ/+vPZq662oJdYJjzsq2MP6pBC0M+OtEQWyw2Nl0Igxm2/d1 HTZYLrwckDFaC0vCEVE3Q+Gvyr5aImkZXHus+Cpsa2TSUVHGvLeqRA21HMnPqF5H1oXi 996GAba+aXE5R++vl+sVhWfvyq9d6qTISRGRTHB6Pbb8STALVwWOyC4fU7e51ycgkmqU z+qKYU28jRrfnCWSrVWdbIktoVoX2ED+WrXZzrysbes3h1+c6/o8Wz6y/IT7Y/gpwpuM vLcw== X-Gm-Message-State: AOAM532IQ5Ux9sdh1Bd2x5fD3Dp1CxoBz+IPHzWnuEBWAoeNh5Gt1M15 Q/mEb2Z/syduszGwV45rYqQ= X-Google-Smtp-Source: ABdhPJzPVDzxB9qLZj2ysFBcSTrwPDaqA6uW4b/cTyvqt0h3ujRdaZdyPPktEHOAMZSxOh+3PQnJjQ== X-Received: by 2002:a05:600c:242:: with SMTP id 2mr7817518wmj.165.1603882505533; Wed, 28 Oct 2020 03:55:05 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id e2sm4557147wrr.85.2020.10.28.03.55.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:55:04 -0700 (PDT) From: luca.boccassi@gmail.com To: Honnappa Nagarahalli Cc: Phil Yang , Ruifeng Wang , Jakub Grajciar , dpdk stable Date: Wed, 28 Oct 2020 10:45:28 +0000 Message-Id: <20201028104606.3504127-169-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/memif: relax load of ring tail for M2S ring' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 863291558d1067b389c0c97827f46c8c385f94a5 Mon Sep 17 00:00:00 2001 From: Honnappa Nagarahalli Date: Mon, 28 Sep 2020 14:03:28 -0500 Subject: [PATCH] net/memif: relax load of ring tail for M2S ring [ upstream commit 827660278032e94541aa8f9363aa16afe6ad0964 ] For M2S rings, ring->tail is updated by the sender and eth_memif_tx function is called in the context of sending thread. The loads in the sender do not need to synchronize with its own stores. Fixes: a2aafb9aa651 ("net/memif: optimize with one-way barrier") Signed-off-by: Honnappa Nagarahalli Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Jakub Grajciar --- drivers/net/memif/rte_eth_memif.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index 1c41988069..3b377bc54c 100644 --- a/drivers/net/memif/rte_eth_memif.c +++ b/drivers/net/memif/rte_eth_memif.c @@ -566,7 +566,13 @@ eth_memif_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) n_free = ring_size - slot + __atomic_load_n(&ring->tail, __ATOMIC_ACQUIRE); } else { - slot = __atomic_load_n(&ring->tail, __ATOMIC_ACQUIRE); + /* For M2S queues ring->tail is updated by the sender and + * this function is called in the context of sending thread. + * The loads in the sender do not need to synchronize with + * its own stores. Hence, the following load can be a + * relaxed load. + */ + slot = __atomic_load_n(&ring->tail, __ATOMIC_RELAXED); n_free = __atomic_load_n(&ring->head, __ATOMIC_ACQUIRE) - slot; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:16.972530616 +0000 +++ 0169-net-memif-relax-load-of-ring-tail-for-M2S-ring.patch 2020-10-28 10:35:11.776834028 +0000 @@ -1,14 +1,15 @@ -From 827660278032e94541aa8f9363aa16afe6ad0964 Mon Sep 17 00:00:00 2001 +From 863291558d1067b389c0c97827f46c8c385f94a5 Mon Sep 17 00:00:00 2001 From: Honnappa Nagarahalli Date: Mon, 28 Sep 2020 14:03:28 -0500 Subject: [PATCH] net/memif: relax load of ring tail for M2S ring +[ upstream commit 827660278032e94541aa8f9363aa16afe6ad0964 ] + For M2S rings, ring->tail is updated by the sender and eth_memif_tx function is called in the context of sending thread. The loads in the sender do not need to synchronize with its own stores. Fixes: a2aafb9aa651 ("net/memif: optimize with one-way barrier") -Cc: stable@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Phil Yang @@ -19,10 +20,10 @@ 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c -index d749b5b16c..b72e24932e 100644 +index 1c41988069..3b377bc54c 100644 --- a/drivers/net/memif/rte_eth_memif.c +++ b/drivers/net/memif/rte_eth_memif.c -@@ -585,7 +585,13 @@ eth_memif_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) +@@ -566,7 +566,13 @@ eth_memif_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) n_free = ring_size - slot + __atomic_load_n(&ring->tail, __ATOMIC_ACQUIRE); } else {