From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF0FEA04DD for ; Wed, 28 Oct 2020 11:49:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2567649E0; Wed, 28 Oct 2020 11:49:16 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id C7274C9D6 for ; Wed, 28 Oct 2020 11:49:14 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id i1so5185810wro.1 for ; Wed, 28 Oct 2020 03:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=a6wtRtGo1jvBYA4tX+55LbTHzUNb7DxtmYMFQCJgJg8=; b=XU3GBFkWrASHWMh9Gm+IpofOkMCsacLLGaA7T39S8RzKadt9FMssBkKdUHVyyShPPE 7dLd5ChBkBGGL6BIEk0CzkqrBpvcy9mIY8nxguwYwWQoX/BOYfkHwOt0C3yOBXwLGwuO OrQNGw4u1UiY291/DPWkmCgb/+IzS8gPgy9aEL4Z8YHghOccrLz0HMP7797n9/wK5gYT jGuuzAjvA/1tFP4pUaHoK6Asel3w8LIdoQsFpjHTpNt6BaIZh1S32xPwZ9PtvkXK5GYx fUFjP8XJtcsWzgx5DWwuh1z1/EV6e/3J9JNz0Hqi48rPX13cBrUIGkHEU7ZgplPDVF/i rqeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a6wtRtGo1jvBYA4tX+55LbTHzUNb7DxtmYMFQCJgJg8=; b=UTIFxndYb6XULTxVHtTiq8mp5DP7SHlD9cKbXWb8exGryqTwbA0CByIxWNxnpw8+I/ mj4uVYDNjJUsabvrPtz6rludIBodnoxy6wmtoIZdY1eO4RTmhI6KKBxxQJQBMYhi3WFt FukyKSGTntQW/vyqmlqZwRJk3YzPhY8tt0JqyA7uajeKptWCYkZDy72vtWc0PUGBENoq LPCvm+hYyokEQTYXk9wgp3xmaGBCaLBTXU/3MgaWO7kTuXihmqWewkplqnlTlqbAYIMD XmkL73rMS/yRJVy9UHNJHzBShywAiYcLfOj8IEiVAR6aLDzG0VxlmxJW8a379TKWFCFL 8VNg== X-Gm-Message-State: AOAM530H2cQr38JPxd2YIHvIkdQ6WpgNLv8MjISxEZ4/ShFeZ9vMUfu2 uY2cee3dOuzqHutqA16RqFA= X-Google-Smtp-Source: ABdhPJyBwr7sSJH+xXUrjs9NOg9FeWmlPJtx3ckJIYAKnIbz7sUM3DOPEzPhz3QdcL4WGs/e0Jpb9Q== X-Received: by 2002:adf:f3c4:: with SMTP id g4mr8594504wrp.207.1603882153573; Wed, 28 Oct 2020 03:49:13 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id d3sm5851061wre.91.2020.10.28.03.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:49:12 -0700 (PDT) From: luca.boccassi@gmail.com To: Yunjian Wang Cc: David Marchand , dpdk stable Date: Wed, 28 Oct 2020 10:43:39 +0000 Message-Id: <20201028104606.3504127-60-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'stack: fix uninitialized variable' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 7b19e1c122b85081cd05d9bd96f3805925bbf03d Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Fri, 25 Sep 2020 13:00:50 +0800 Subject: [PATCH] stack: fix uninitialized variable [ upstream commit d1ca6cfd3c9d7626d43e01a6c14686d48dadf46b ] This patch fixes an issue that uninitialized 'success' is used to be compared with '0'. Coverity issue: 337676 Fixes: 3340202f5954 ("stack: add lock-free implementation") Signed-off-by: Yunjian Wang Reviewed-by: David Marchand --- lib/librte_stack/rte_stack_lf_generic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_stack/rte_stack_lf_generic.h b/lib/librte_stack/rte_stack_lf_generic.h index 3abbb53428..4850a05ee7 100644 --- a/lib/librte_stack/rte_stack_lf_generic.h +++ b/lib/librte_stack/rte_stack_lf_generic.h @@ -78,7 +78,7 @@ __rte_stack_lf_pop_elems(struct rte_stack_lf_list *list, struct rte_stack_lf_elem **last) { struct rte_stack_lf_head old_head; - int success; + int success = 0; /* Reserve num elements, if available */ while (1) { -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:13.640315870 +0000 +++ 0060-stack-fix-uninitialized-variable.patch 2020-10-28 10:35:11.524830318 +0000 @@ -1,14 +1,15 @@ -From d1ca6cfd3c9d7626d43e01a6c14686d48dadf46b Mon Sep 17 00:00:00 2001 +From 7b19e1c122b85081cd05d9bd96f3805925bbf03d Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Fri, 25 Sep 2020 13:00:50 +0800 Subject: [PATCH] stack: fix uninitialized variable +[ upstream commit d1ca6cfd3c9d7626d43e01a6c14686d48dadf46b ] + This patch fixes an issue that uninitialized 'success' is used to be compared with '0'. Coverity issue: 337676 Fixes: 3340202f5954 ("stack: add lock-free implementation") -Cc: stable@dpdk.org Signed-off-by: Yunjian Wang Reviewed-by: David Marchand