From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E219A04DD for ; Wed, 28 Oct 2020 11:51:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 50A542C2A; Wed, 28 Oct 2020 11:51:22 +0100 (CET) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by dpdk.org (Postfix) with ESMTP id 014BD2C2A for ; Wed, 28 Oct 2020 11:51:19 +0100 (CET) Received: by mail-wm1-f47.google.com with SMTP id k18so4301858wmj.5 for ; Wed, 28 Oct 2020 03:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Nyp7heK/PY2B0qz2moKAXW8nhrFChzlj0PV7ywzWEnQ=; b=j7ROUiX2WL5gFJHM6y9i8nOlsnnmcajwKYVc44+MIhCUpsGJ2H/Dmq4oLmpvThhiFX agSKAI5jasrlA3X1CsGZ0ZCssLHG7RIYLs2HoPbmh2ZOdFXFyX9vVYbuFtMuswm2q04i 6/7wKZODmfP01Cadk4mtr4xSoBtm34cre4Tm2OHpq4OxUpiMOfnURrRWsDAjvR8GBEdd mjJeetjrcOCn7zw3a2C4eXbFW5AxemOGuKWqJcoAplqdFR8R5DeE/2IlkJ8OZFgfqSaT vgBGBIeoEkTupCWV0yLS0hlX5Di2aIXBqChpYhA13stgBndpgYemj43wGbcq6FUQWxcO GmWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Nyp7heK/PY2B0qz2moKAXW8nhrFChzlj0PV7ywzWEnQ=; b=HzOUFW7IgU3CpDbHJFbXTLbmkYyxpyPgo0Rd5f2GztnWQrBxAMEe6dN/FiLMVU86Zs KVKgWHzuGmqLXk3zhKu4R4cq57lvrMTsrngdCYhwy9t2sbuwqR0QNTrogy+FxfX67hLE z4v7mbmZECQ9+hQLOln9d6ZSjt/mZI0NWA1Da7DkVLCNYP5M/3jSFStMfe1xA5L1PI7b kqCwsSPIgXYS/h7YRVgcVju5nQxWe90PTG+44xM4wjjzlHyXVSUQ9wfslUj0b2hKS9L2 vFz4rdSu/N1IVwqpaslpfWFmD1Yit2pwJrKFshLlZ+K6drVs1klTq0juYRijlqh17X7+ nKFQ== X-Gm-Message-State: AOAM532bw5Ol/HTia8XnvLyd8zew/f4oyrWZU8/74Bbyn0RFtsfQB5RN F3hEmL4GJNbDKJxx3AEfwmw= X-Google-Smtp-Source: ABdhPJyziKMWEN5wLPyXM1oukzDg8YXZSyJIP5n/bgb1yB1LyROweCyF0XYXAWWUzu3iVlDHf6b9iA== X-Received: by 2002:a05:600c:209:: with SMTP id 9mr3791614wmi.89.1603882279694; Wed, 28 Oct 2020 03:51:19 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 24sm5526592wmf.44.2020.10.28.03.51.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:51:19 -0700 (PDT) From: luca.boccassi@gmail.com To: Yunjian Wang Cc: Chenbo Xia , dpdk stable Date: Wed, 28 Oct 2020 10:44:16 +0000 Message-Id: <20201028104606.3504127-97-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'examples/vhost_blk: check driver start failure' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From abe125b262bf316c05576f549a0bfc47e396b140 Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Fri, 25 Sep 2020 19:22:06 +0800 Subject: [PATCH] examples/vhost_blk: check driver start failure [ upstream commit dc9e658013d9c2be798f9ff43b8cd2c63c844f17 ] This checks the return value from the function rte_vhost_driver_start. Coverity issue: 362027 Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") Signed-off-by: Yunjian Wang Reviewed-by: Chenbo Xia --- examples/vhost_blk/vhost_blk.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c index b757c9228b..32c88628c4 100644 --- a/examples/vhost_blk/vhost_blk.c +++ b/examples/vhost_blk/vhost_blk.c @@ -1082,7 +1082,11 @@ int main(int argc, char *argv[]) return -1; } - rte_vhost_driver_start(dev_pathname); + ret = rte_vhost_driver_start(dev_pathname); + if (ret < 0) { + fprintf(stderr, "Failed to start vhost driver.\n"); + return -1; + } /* loop for exit the application */ while (1) -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:14.798644296 +0000 +++ 0097-examples-vhost_blk-check-driver-start-failure.patch 2020-10-28 10:35:11.648832144 +0000 @@ -1,14 +1,15 @@ -From dc9e658013d9c2be798f9ff43b8cd2c63c844f17 Mon Sep 17 00:00:00 2001 +From abe125b262bf316c05576f549a0bfc47e396b140 Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Fri, 25 Sep 2020 19:22:06 +0800 Subject: [PATCH] examples/vhost_blk: check driver start failure +[ upstream commit dc9e658013d9c2be798f9ff43b8cd2c63c844f17 ] + This checks the return value from the function rte_vhost_driver_start. Coverity issue: 362027 Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") -Cc: stable@dpdk.org Signed-off-by: Yunjian Wang Reviewed-by: Chenbo Xia @@ -17,12 +18,12 @@ 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c -index f4c59437a0..8f5d61a589 100644 +index b757c9228b..32c88628c4 100644 --- a/examples/vhost_blk/vhost_blk.c +++ b/examples/vhost_blk/vhost_blk.c -@@ -877,7 +877,11 @@ int main(int argc, char *argv[]) - - signal(SIGINT, signal_handler); +@@ -1082,7 +1082,11 @@ int main(int argc, char *argv[]) + return -1; + } - rte_vhost_driver_start(dev_pathname); + ret = rte_vhost_driver_start(dev_pathname);