From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91C0BA04B1 for ; Thu, 5 Nov 2020 13:41:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7306DC800; Thu, 5 Nov 2020 13:41:06 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 3DECDC802 for ; Thu, 5 Nov 2020 13:41:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604580062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HtH9k47T9SYr2eiAokQaKQymBNZ7P8kS6AXRehLg2fE=; b=ZBaS9d5izQ0V1LdgLJujRd3ZKNFAZkFg0QvJ5Awfh/fYdUHtPL1szyNmiZK4n+T2+hdg1Z vN9M3UeMp6LiqVWRDQn8Jh9dSVm3LQIJV3rdEplhMs+U+ccdlKvety68gQ03CkY2BkvjeL mlWeiqwOXGJVdNI1lyLRb8nO3bCk/EE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-555-4s0brgkIO-2FVdM8cRizGg-1; Thu, 05 Nov 2020 07:40:59 -0500 X-MC-Unique: 4s0brgkIO-2FVdM8cRizGg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9676A186DD22; Thu, 5 Nov 2020 12:40:58 +0000 (UTC) Received: from rh.redhat.com (ovpn-113-249.ams2.redhat.com [10.36.113.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8B5A15C3E1; Thu, 5 Nov 2020 12:40:57 +0000 (UTC) From: Kevin Traynor To: Heinrich Kuhn Cc: Simon Horman , dpdk stable Date: Thu, 5 Nov 2020 12:39:24 +0000 Message-Id: <20201105124015.306404-17-ktraynor@redhat.com> In-Reply-To: <20201105124015.306404-1-ktraynor@redhat.com> References: <20201105124015.306404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'doc: improve multiport PF in nfp guide' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/10/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/be901baabdff54ccc044a4deb0b3b89564de5554 Thanks. Kevin. --- >From be901baabdff54ccc044a4deb0b3b89564de5554 Mon Sep 17 00:00:00 2001 From: Heinrich Kuhn Date: Thu, 3 Sep 2020 13:23:51 +0200 Subject: [PATCH] doc: improve multiport PF in nfp guide [ upstream commit 979f2bae0714c18899e5bbb3d472842b0ce20060 ] The Agilio CX family of smartNIC's generally have a 1:many mapping of PF to physical ports. Elaborate on this mapping in the PF multiport section of the NFP PMD documentation. Fixes: d625beafc8be ("doc: update NFP with PF support information") Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- doc/guides/nics/nfp.rst | 39 ++++++++++++++++++++++++++++----------- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/doc/guides/nics/nfp.rst b/doc/guides/nics/nfp.rst index 927c03c63b..aff9d1553d 100644 --- a/doc/guides/nics/nfp.rst +++ b/doc/guides/nics/nfp.rst @@ -129,20 +129,37 @@ more than one SmartNIC, same type of SmartNIC or different ones, and to upload a different firmware to each SmartNIC. + .. Note:: + Currently the NFP PMD supports using the PF with Agilio Basic Firmware. See + https://help.netronome.com/support/solutions for more information on the + various firmwares supported by the Netronome Agilio CX smartNIC. PF multiport support -------------------- -Some NFP cards support several physical ports with just one single PCI device. -The DPDK core is designed with a 1:1 relationship between PCI devices and DPDK -ports, so NFP PMD PF support requires handling the multiport case specifically. -During NFP PF initialization, the PMD will extract the information about the -number of PF ports from the firmware and will create as many DPDK ports as -needed. - -Because the unusual relationship between a single PCI device and several DPDK -ports, there are some limitations when using more than one PF DPDK port: there -is no support for RX interrupts and it is not possible either to use those PF -ports with the device hotplug functionality. +The NFP PMD can work with up to 8 ports on the same PF device. The number of +available ports is firmware and hardware dependent, and the driver looks for a +firmware symbol during initialization to know how many can be used. +DPDK apps work with ports, and a port is usually a PF or a VF PCI device. +However, with the NFP PF multiport there is just one PF PCI device. Supporting +this particular configuration requires the PMD to create ports in a special way, +although once they are created, DPDK apps should be able to use them as normal +PCI ports. + +NFP ports belonging to same PF can be seen inside PMD initialization with a +suffix added to the PCI ID: wwww:xx:yy.z_port_n. For example, a PF with PCI ID +0000:03:00.0 and four ports is seen by the PMD code as: + + .. code-block:: console + + 0000:03:00.0_port_0 + 0000:03:00.0_port_1 + 0000:03:00.0_port_2 + 0000:03:00.0_port_3 + + .. Note:: + + There are some limitations with multiport support: RX interrupts and + device hot-plugging are not supported. System configuration -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-05 12:38:54.583868872 +0000 +++ 0017-doc-improve-multiport-PF-in-nfp-guide.patch 2020-11-05 12:38:54.180895973 +0000 @@ -1 +1 @@ -From 979f2bae0714c18899e5bbb3d472842b0ce20060 Mon Sep 17 00:00:00 2001 +From be901baabdff54ccc044a4deb0b3b89564de5554 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 979f2bae0714c18899e5bbb3d472842b0ce20060 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 5f2a0698f6..020e37d131 100644 +index 927c03c63b..aff9d1553d 100644 @@ -23 +24 @@ -@@ -103,20 +103,37 @@ more than one SmartNIC, same type of SmartNIC or different ones, and to upload a +@@ -129,20 +129,37 @@ more than one SmartNIC, same type of SmartNIC or different ones, and to upload a @@ -71 +72 @@ - PF multiprocess support + System configuration