From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44F68A04B1 for ; Thu, 5 Nov 2020 13:41:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3CDC7C31D; Thu, 5 Nov 2020 13:41:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id ED1A7C31D for ; Thu, 5 Nov 2020 13:41:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604580080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LK2Rn+QoSVzHdVO/9GiKWcipPg3A0S3kTrKa806fImE=; b=XOf5WKTBU15CR5BxB5wwqQM2mJny/yWQtcs/mvSQhBwn8mVdk+WOH5nLO/3NK/cM9wA5DZ GUw8oMdnR1zzOWIanMQUllztoGeq8Tbz20JeCjFLnENVsLSNQPIcHET91vBMdLgE9KFsmb TYUH4A3ggIrAgKorzQaBpGgpD46uoxE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-2pGTSEEiOqO1Kjc0P3WuvQ-1; Thu, 05 Nov 2020 07:41:17 -0500 X-MC-Unique: 2pGTSEEiOqO1Kjc0P3WuvQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 487A18015C3; Thu, 5 Nov 2020 12:41:16 +0000 (UTC) Received: from rh.redhat.com (ovpn-113-249.ams2.redhat.com [10.36.113.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF32F5C3E1; Thu, 5 Nov 2020 12:41:14 +0000 (UTC) From: Kevin Traynor To: Somnath Kotur Cc: Venkat Duvvuru , Ajit Khaparde , dpdk stable Date: Thu, 5 Nov 2020 12:39:33 +0000 Message-Id: <20201105124015.306404-26-ktraynor@redhat.com> In-Reply-To: <20201105124015.306404-1-ktraynor@redhat.com> References: <20201105124015.306404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'net/bnxt: fix shift operation' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/10/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/124b1ca01534fe197355c1aed55d694bf5dd747b Thanks. Kevin. --- >From 124b1ca01534fe197355c1aed55d694bf5dd747b Mon Sep 17 00:00:00 2001 From: Somnath Kotur Date: Tue, 22 Sep 2020 12:36:27 +0530 Subject: [PATCH] net/bnxt: fix shift operation [ upstream commit affb4d5c212957f3844a7bbd00a5f2ba703b8a33 ] In page_roundup() left shifting by more than 31 bits could have undefined behavior as the return value is int and in page_getenum() it is possible to return a value as high as 63. Fix that to cap the return value to less than 32. Coverity issue: 343463 Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") Signed-off-by: Somnath Kotur Reviewed-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 01ddf4443a..cf6f6d2923 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -53,5 +53,5 @@ static int page_getenum(size_t size) return 30; PMD_DRV_LOG(ERR, "Page size %zu out of range\n", size); - return sizeof(void *) * 8 - 1; + return sizeof(int) * 8 - 1; } -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-05 12:38:54.749421127 +0000 +++ 0026-net-bnxt-fix-shift-operation.patch 2020-11-05 12:38:54.205895993 +0000 @@ -1 +1 @@ -From affb4d5c212957f3844a7bbd00a5f2ba703b8a33 Mon Sep 17 00:00:00 2001 +From 124b1ca01534fe197355c1aed55d694bf5dd747b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit affb4d5c212957f3844a7bbd00a5f2ba703b8a33 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index d0b820f149..577c5d1352 100644 +index 01ddf4443a..cf6f6d2923 100644