From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D10F3A04B1 for ; Thu, 5 Nov 2020 13:41:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9DB3BC7EE; Thu, 5 Nov 2020 13:41:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id B9C35C804 for ; Thu, 5 Nov 2020 13:41:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604580112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NXIs4Ffhd+D7VRXBcb2b3OoGZD+xBd0WI1zmyz3BHEo=; b=YFDQRnb0jxigphR+xgd996O6iCcnftBNW75wMRcbNjB/almb4umvrPCnu4fH9gOTKMemY0 O+HY5qj6lM9DtVB9ZbAeTCUCfca9eF+PkLE8jkga0QWxRxs+DDabe03zx8aNYl8I2S4VhX JN+22toN7qoGPgTJeRoT8cjoNRSU7uU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-TNfnUwq3OoydwxSj0NQ1lw-1; Thu, 05 Nov 2020 07:41:47 -0500 X-MC-Unique: TNfnUwq3OoydwxSj0NQ1lw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CFF0C57241; Thu, 5 Nov 2020 12:41:46 +0000 (UTC) Received: from rh.redhat.com (ovpn-113-249.ams2.redhat.com [10.36.113.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id C4DCE5C3E1; Thu, 5 Nov 2020 12:41:45 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: John McNamara , dpdk stable Date: Thu, 5 Nov 2020 12:39:49 +0000 Message-Id: <20201105124015.306404-42-ktraynor@redhat.com> In-Reply-To: <20201105124015.306404-1-ktraynor@redhat.com> References: <20201105124015.306404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'doc: fix formatting of notes in meson guide' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/10/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/fb7bce81c5dbb7366764588d25130ac3f88a6f6c Thanks. Kevin. --- >From fb7bce81c5dbb7366764588d25130ac3f88a6f6c Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Thu, 3 Sep 2020 15:00:33 +0100 Subject: [PATCH] doc: fix formatting of notes in meson guide [ upstream commit 1509ef9350671ee13381ce8e3c1741c2effc28b1 ] The "note" callouts in the chapter describing the meson build were incorrectly formatted, so adjust to use the correct markdown syntax. Fixes: 9c3adc289c5e ("doc: add instructions on build using meson") Signed-off-by: Bruce Richardson Acked-by: John McNamara --- doc/build-sdk-meson.txt | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt index 29a8bd387f..057734795e 100644 --- a/doc/build-sdk-meson.txt +++ b/doc/build-sdk-meson.txt @@ -98,9 +98,11 @@ Examples of setting the same options using meson configure:: meson configure -Dmax_lcores=8 -NOTE: once meson has been run to configure a build in a directory, it -cannot be run again on the same directory. Instead ``meson configure`` -should be used to change the build settings within the directory, and when -``ninja`` is called to do the build itself, it will trigger the necessary -re-scan from meson. +.. note:: + + once meson has been run to configure a build in a directory, it + cannot be run again on the same directory. Instead ``meson configure`` + should be used to change the build settings within the directory, and when + ``ninja`` is called to do the build itself, it will trigger the necessary + re-scan from meson. As well as those settings taken from ``meson configure``, other options @@ -110,7 +112,9 @@ example:: CC=clang meson clang-build -NOTE: for more comprehensive overriding of compilers or other environment -settings, the tools for cross-compilation may be considered. However, for -basic overriding of the compiler etc., the above form works as expected. +.. note:: + + for more comprehensive overriding of compilers or other environment + settings, the tools for cross-compilation may be considered. However, for + basic overriding of the compiler etc., the above form works as expected. -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-05 12:38:55.057244546 +0000 +++ 0042-doc-fix-formatting-of-notes-in-meson-guide.patch 2020-11-05 12:38:54.242896021 +0000 @@ -1 +1 @@ -From 1509ef9350671ee13381ce8e3c1741c2effc28b1 Mon Sep 17 00:00:00 2001 +From fb7bce81c5dbb7366764588d25130ac3f88a6f6c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1509ef9350671ee13381ce8e3c1741c2effc28b1 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -15,2 +16,2 @@ - doc/guides/prog_guide/build-sdk-meson.rst | 25 ++++++++++++++--------- - 1 file changed, 15 insertions(+), 10 deletions(-) + doc/build-sdk-meson.txt | 20 ++++++++++++-------- + 1 file changed, 12 insertions(+), 8 deletions(-) @@ -18,6 +19,6 @@ -diff --git a/doc/guides/prog_guide/build-sdk-meson.rst b/doc/guides/prog_guide/build-sdk-meson.rst -index 44d1cafdf0..d621bea565 100644 ---- a/doc/guides/prog_guide/build-sdk-meson.rst -+++ b/doc/guides/prog_guide/build-sdk-meson.rst -@@ -103,12 +103,15 @@ Examples of setting some of the same options using meson configure:: - meson configure -Denable_trace_fp=true +diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt +index 29a8bd387f..057734795e 100644 +--- a/doc/build-sdk-meson.txt ++++ b/doc/build-sdk-meson.txt +@@ -98,9 +98,11 @@ Examples of setting the same options using meson configure:: + meson configure -Dmax_lcores=8 @@ -31,3 +32 @@ - --NOTE: machine=default uses a config that works on all supported architectures --regardless of the capabilities of the machine where the build is happening. ++ @@ -39,4 +37,0 @@ -+ -+.. note:: -+ machine=default uses a config that works on all supported architectures -+ regardless of the capabilities of the machine where the build is happening. @@ -45 +40 @@ -@@ -118,7 +121,9 @@ example:: +@@ -110,7 +112,9 @@ example::