From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E312A0527 for ; Mon, 9 Nov 2020 19:42:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 36D886883; Mon, 9 Nov 2020 19:42:39 +0100 (CET) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by dpdk.org (Postfix) with ESMTP id E27207CAE for ; Mon, 9 Nov 2020 19:42:36 +0100 (CET) Received: by mail-wm1-f45.google.com with SMTP id c9so444566wml.5 for ; Mon, 09 Nov 2020 10:42:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GZYWV6CevRc/2BccUjI2uC8o4TkHl5PGa2TRSqkv6no=; b=NEzcuiEYHOW30PAri/5nZNnDVGeqnVeSV4T90i0om0Wek5FyWrznJXQ/1PRXsflwaW icw3+SAYdrQ7Wmd09HpSG+gC2Fcc/svYiZWcYe5xVZSGk3V4QkDwseAEGbWKDZIL9n+z eF4urzNhuLGYd9ul1OqwIBWjfKddo8pCkCFV1jjLr5w19Hmkd6cFDtTksA7hJTFLTGot /6/ljGKpqe/2NvtfeYhSA4M8q6bs5lAqi1+3Vq5bR22VQxwXDDTltyubERfEIEr5DK7N g5b3fxA7yQPCavwn3f3CKJ+xZf6fTKRo0+vQNwwP5IT9eKSra49VwwpWlMIeImblYfyu 9Kfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GZYWV6CevRc/2BccUjI2uC8o4TkHl5PGa2TRSqkv6no=; b=M0tHamUtcYLyBD6psJli1U6CaqTV3ULA2gQ/5gUimkuHbw5oM1OlBQ+to490+kgJXt GRf9TU430FzCjC3TK01YzJ71dBk4J1AncXI64nHLtKPcyTGwz3oRzLQGMBc34lqeSkF1 mymQdnKE+WC5EtZ3xlzh79ujlg1jRQ+aAwC+9nTzRS0LCMfolUvyHqjT+K6WpiS3coG3 IOzRpQjIkm+3FO/sPFnJIN6Ee09aQsTnbBd7hAIKw7jVd3yZWhITYGHye1hn1WY1atfj BqbN3P0WJvWBFDthVMU7jfgno6ni/tBXWuNLc1Pa9XJsjM/iMNCRef7e8quZ6lhkTsXG DnSQ== X-Gm-Message-State: AOAM531u+7rt658czpZqUTAqLr/vDe5cN+GKsl1X4PBls95T7jSjDk0u 4StmsuXo3c2l//W/i5SR8c/bA05XDPBVcw== X-Google-Smtp-Source: ABdhPJzTbw5bVaOXvHjh3RFr+FdRrMgwKVP8WUgaAcA4l+yAR8mHHYmb9S3RlHkJ7IGDSOY39m7iEA== X-Received: by 2002:a1c:2ec6:: with SMTP id u189mr548186wmu.85.1604947356717; Mon, 09 Nov 2020 10:42:36 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 35sm12334051wro.71.2020.11.09.10.42.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 10:42:35 -0800 (PST) From: luca.boccassi@gmail.com To: Leyi Rong Cc: Qi Zhang , dpdk stable Date: Mon, 9 Nov 2020 18:40:13 +0000 Message-Id: <20201109184111.3463090-25-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201109184111.3463090-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-207-luca.boccassi@gmail.com> <20201109184111.3463090-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/iavf: fix unchecked Tx cleanup error' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/11/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/590b5f4242a8663df7d755011e80056e08c53d85 Thanks. Luca Boccassi --- >From 590b5f4242a8663df7d755011e80056e08c53d85 Mon Sep 17 00:00:00 2001 From: Leyi Rong Date: Mon, 19 Oct 2020 13:42:53 +0800 Subject: [PATCH] net/iavf: fix unchecked Tx cleanup error [ upstream commit fd0dd9b3cfc02b15842092a229be5d3988a79c2a ] Coverity complains of unchecked return value warning of iavf_xmit_cleanup, while this cleanup is opportunistic and will not cause problems if it fails. So instead of checking the return value of iavf_xmit_cleanup and return in case of cleanup failure, we directly cast it to void function to make the Coverity happy. Coverity issue: 363045 Fixes: 02d212ca3125 ("net/iavf: rename remaining avf strings") Signed-off-by: Leyi Rong Acked-by: Qi Zhang --- drivers/net/iavf/iavf_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 88f79ba379..6aafc72e24 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -1506,7 +1506,7 @@ iavf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) /* Check if the descriptor ring needs to be cleaned. */ if (txq->nb_free < txq->free_thresh) - iavf_xmit_cleanup(txq); + (void)iavf_xmit_cleanup(txq); for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) { td_cmd = 0; -- 2.27.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-09 18:40:12.206629097 +0000 +++ 0025-net-iavf-fix-unchecked-Tx-cleanup-error.patch 2020-11-09 18:40:11.103310846 +0000 @@ -1 +1 @@ -From fd0dd9b3cfc02b15842092a229be5d3988a79c2a Mon Sep 17 00:00:00 2001 +From 590b5f4242a8663df7d755011e80056e08c53d85 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fd0dd9b3cfc02b15842092a229be5d3988a79c2a ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index edb2dc3ca4..7d4f4ed485 100644 +index 88f79ba379..6aafc72e24 100644 @@ -26 +27 @@ -@@ -1891,7 +1891,7 @@ iavf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) +@@ -1506,7 +1506,7 @@ iavf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)