From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C678A0527 for ; Mon, 9 Nov 2020 19:44:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8E76D69A4; Mon, 9 Nov 2020 19:44:17 +0100 (CET) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by dpdk.org (Postfix) with ESMTP id 6F06C6883 for ; Mon, 9 Nov 2020 19:44:16 +0100 (CET) Received: by mail-wm1-f42.google.com with SMTP id a65so451385wme.1 for ; Mon, 09 Nov 2020 10:44:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O6okTlwOVO8KcpgHzz31DBz5bJqUnPn/10yxoaMwAPI=; b=iiVGF6TyYqUdgGuSai/cBr+yy1XUe7oA1/kGQuA1+vXp7zgUd5xXJQ8txnLkle2x8Y BeIDTeaRGqcNlTHSbdg2wMGlUSjQagWil6rbTI8NP0ZTDHdP0QuYvNEFKdfgkxe2ToYS iYCHKpZBXw9pqZQsCQpSCLtbNBc44R3G5goQZ+awUpbJFBO1ljpVjj6H4YHqRVbUXgyD uSbRnO7yy/OnHJqLYTzzdarnGo2K9FGMhObcxVNpByg6QMCHEz6qbukmJ0AtftF6Qw1H ExaxfzwVr1dtwDeqatiBKSA3uuC7uyTDpusyDKH7E7WnZiKRgcOocoURTomW4Iyjgga7 TTWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O6okTlwOVO8KcpgHzz31DBz5bJqUnPn/10yxoaMwAPI=; b=ZVVa5n8C+cIPkB5xk5U8HYYZhDIE43eacWWZSwCsLbhY+1kYZDeIvKxDzG4hXrFoXJ fY6yPgvuFaYZEEjmmIbK5V6PgCyXMWRYxO7SNkNU0c6kK3462MA/f7vnqWBvm8pQaerF Fc+RQKPGJKQxeTdlelrbxRrWtzyZvzLiHLF3oqucn6EnxRk7/UkTmw2SFONrQxElMGXt VTNidhMRefjXZgomJoTdiZc9a0CFqwlAfz+HWnVWcEe/CL2Y1fAjOq0pp4T/f3Lq6NdA t2djnRNQOuVucclm3feKFcdZ8xTsT6hLcULDhx1hNf+mrvBzkQm5MPK3vJ72wukkF1oi IBlg== X-Gm-Message-State: AOAM532jj4hO82rJseduovLw/e/VaXtinTH8sEUG1ONVPGEviRFebB0A PpkASBF3b0WQvH1yKAsE2oFtqMULyqNmXgt5 X-Google-Smtp-Source: ABdhPJwhgB2rOtiqpCPRihqudxS1cgI+zsNMsF3wGDJsdDWsz89KDaPpQXQW+M0zhqgY2K/gsokRlQ== X-Received: by 2002:a1c:7dc8:: with SMTP id y191mr593241wmc.118.1604947455167; Mon, 09 Nov 2020 10:44:15 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id v12sm15031920wro.72.2020.11.09.10.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 10:44:14 -0800 (PST) From: luca.boccassi@gmail.com To: Jesse Brandeburg Cc: Brian Johnson , Qi Zhang , dpdk stable Date: Mon, 9 Nov 2020 18:40:40 +0000 Message-Id: <20201109184111.3463090-52-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201109184111.3463090-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-207-luca.boccassi@gmail.com> <20201109184111.3463090-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/ice: update writeback policy to reduce latency' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/11/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/d97dce73be24d6a4bdb1959cb24740a14a71e335 Thanks. Luca Boccassi --- >From d97dce73be24d6a4bdb1959cb24740a14a71e335 Mon Sep 17 00:00:00 2001 From: Jesse Brandeburg Date: Fri, 23 Oct 2020 13:22:00 -0700 Subject: [PATCH] net/ice: update writeback policy to reduce latency [ upstream commit 8b20510a042aee6681c33c20bb076b53cb354708 ] Just like iavf, setting the value to 2us allows for generally good streaming packet performance while keeping latency down, and generally keeps the performance of the PF and VF interfaces similar. The previous value of 0x10 was making latency on a single packet receive be as much as 16us. Fixes: 65dfc889d86b ("net/ice: support Rx queue interruption") Reported-by: Brian Johnson Signed-off-by: Jesse Brandeburg Acked-by: Qi Zhang --- drivers/net/ice/ice_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index cb71d7bfd4..8acfce00aa 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -2633,7 +2633,7 @@ __vsi_queues_bind_intr(struct ice_vsi *vsi, uint16_t msix_vect, PMD_DRV_LOG(INFO, "queue %d is binding to vect %d", base_queue + i, msix_vect); /* set ITR0 value */ - ICE_WRITE_REG(hw, GLINT_ITR(0, msix_vect), 0x10); + ICE_WRITE_REG(hw, GLINT_ITR(0, msix_vect), 0x2); ICE_WRITE_REG(hw, QINT_RQCTL(base_queue + i), val); ICE_WRITE_REG(hw, QINT_TQCTL(base_queue + i), val_tx); } -- 2.27.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-09 18:40:13.207144288 +0000 +++ 0052-net-ice-update-writeback-policy-to-reduce-latency.patch 2020-11-09 18:40:11.183312091 +0000 @@ -1 +1 @@ -From 8b20510a042aee6681c33c20bb076b53cb354708 Mon Sep 17 00:00:00 2001 +From d97dce73be24d6a4bdb1959cb24740a14a71e335 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8b20510a042aee6681c33c20bb076b53cb354708 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 51b99c6506..3483f99897 100644 +index cb71d7bfd4..8acfce00aa 100644 @@ -27 +28 @@ -@@ -3345,7 +3345,7 @@ __vsi_queues_bind_intr(struct ice_vsi *vsi, uint16_t msix_vect, +@@ -2633,7 +2633,7 @@ __vsi_queues_bind_intr(struct ice_vsi *vsi, uint16_t msix_vect,