From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79E19A0527 for ; Mon, 9 Nov 2020 19:45:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7349972E9; Mon, 9 Nov 2020 19:45:31 +0100 (CET) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by dpdk.org (Postfix) with ESMTP id E820672E9 for ; Mon, 9 Nov 2020 19:45:28 +0100 (CET) Received: by mail-wm1-f41.google.com with SMTP id 10so465891wml.2 for ; Mon, 09 Nov 2020 10:45:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MILkwnretQ2A3lUsvXW3UG5Rt5m1Mz88MsIYG954Zzk=; b=ZLHySF6S6HqTTDvv1GfTzCDOkr9uqRF+70BMHEvzdz/zDeZnfSjm2BN0aehUxu0E+v vtuEcTOj4+HD9IH90e+2rLLU/s8nzXH8+Wm0bgoriByvFy8anxCVBwUmcWt9/Ang3St0 p86GIzZjHvvD6cYO0YuqPD4uT4G9JaVQjQtnSDKGOKXw+OS1AvpyjpKFRAkjY+RAA7Mp uAEiVoZT7vj69DeTZqQZkBWjuJpUn7Wr8DxOtqi8BRq3UWhbAdcmvHu+k0CehG1edBf6 s5kmeJVH6pmpiQrt4GMxz5pkn6P3m6iu2Zs4vCH/NXSbHCKBbPOkx47MNyuUIjqCxBrX /HrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MILkwnretQ2A3lUsvXW3UG5Rt5m1Mz88MsIYG954Zzk=; b=pom6mCUdkV+ukKUg/8uiPIboXCQVcwjZSVEpPQeFggJcBJs+xjHr9eH1PtKPLJpFT6 iDpPJdCGE/R7O+BeFHIL6TNFYJwvGMTI0+ep60vQlWro58lSUrd+3MUVh7YcSz0GYYnu MQKix4jjkOs8RCdXXSxsS0i7Zh8+ryay7I5LjBjlgKhFBOZ3iD2nT7avmmiuCRVBmT0h nzd/Pd12tDVOm0912xyFVhwqzyqlxomSuWKeSMPiwgwV21cqSG3xq4DtMKlX7CFSWst5 2nqmwDE+W8qTDfhvgiXj1pstGe4d2PrEBX2mupw3ki+6XhM5FyD9eiZ8u7M4I+Mc2lnm uTPw== X-Gm-Message-State: AOAM533Pa2DFPHiIDjSMHnbi5UtNzrfwqRRB/tL457yiO20LlVi464n9 hS5i6Qbv+x7NyNA+vdlggx0= X-Google-Smtp-Source: ABdhPJy9tIkypJPipL4JalMs64yE1xyRGIX+pYclqhe1gD8GTOm9MjbXPAERfrtOL7xfSGJcnZldWA== X-Received: by 2002:a1c:230e:: with SMTP id j14mr505279wmj.187.1604947527740; Mon, 09 Nov 2020 10:45:27 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id a12sm13965293wrr.31.2020.11.09.10.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 10:45:27 -0800 (PST) From: luca.boccassi@gmail.com To: Zhenghua Zhou Cc: Ferruh Yigit , dpdk stable Date: Mon, 9 Nov 2020 18:41:02 +0000 Message-Id: <20201109184111.3463090-74-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201109184111.3463090-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-207-luca.boccassi@gmail.com> <20201109184111.3463090-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/testpmd: do not allow dynamic change of core number' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/11/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/d7b6b8697739e82bca65380b43bf4c1975c6f589 Thanks. Luca Boccassi --- >From d7b6b8697739e82bca65380b43bf4c1975c6f589 Mon Sep 17 00:00:00 2001 From: Zhenghua Zhou Date: Tue, 27 Oct 2020 06:42:52 +0000 Subject: [PATCH] app/testpmd: do not allow dynamic change of core number [ upstream commit 653c6ed4a12ad40e476a8936b4f463e01acfbf78 ] When the number of forwarding cores changed in runtime, the issue may be encountered: If the nbcore set little than current nbcore, the forwarding thread will still running on the extra cores. Therefore, trying to stop forwarding will hang testpmd, since it will wait for the extra cores to stop. So do not allow to change nbcore number when forwarding is running. Fixes: 0c0db76f42ed ("app/testpmd: separate forward config setup from display") Signed-off-by: Zhenghua Zhou Acked-by: Ferruh Yigit --- app/test-pmd/config.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 124a6b8c57..5f8905c06a 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2681,6 +2681,10 @@ set_fwd_lcores_mask(uint64_t lcoremask) void set_fwd_lcores_number(uint16_t nb_lc) { + if (test_done == 0) { + printf("Please stop forwarding first\n"); + return; + } if (nb_lc > nb_cfg_lcores) { printf("nb fwd cores %u > %u (max. number of configured " "lcores) - ignored\n", -- 2.27.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-09 18:40:13.923162038 +0000 +++ 0074-app-testpmd-do-not-allow-dynamic-change-of-core-numb.patch 2020-11-09 18:40:11.219312651 +0000 @@ -1 +1 @@ -From 653c6ed4a12ad40e476a8936b4f463e01acfbf78 Mon Sep 17 00:00:00 2001 +From d7b6b8697739e82bca65380b43bf4c1975c6f589 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 653c6ed4a12ad40e476a8936b4f463e01acfbf78 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 136f4e5dbe..755d1dfc9c 100644 +index 124a6b8c57..5f8905c06a 100644 @@ -28 +29 @@ -@@ -3504,6 +3504,10 @@ set_fwd_lcores_mask(uint64_t lcoremask) +@@ -2681,6 +2681,10 @@ set_fwd_lcores_mask(uint64_t lcoremask)