From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26383A09E0 for ; Thu, 12 Nov 2020 03:14:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDE575AB9; Thu, 12 Nov 2020 03:14:22 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A690F569B; Thu, 12 Nov 2020 03:14:18 +0100 (CET) IronPort-SDR: AchGhiJg+f1tKz1jBJV4cr8f4cD4RbGYkP6L2pLDjTZekyh4oz9BBpMMtax7ra74SaBH0sf231 dywetjXPk4pQ== X-IronPort-AV: E=McAfee;i="6000,8403,9802"; a="170413847" X-IronPort-AV: E=Sophos;i="5.77,471,1596524400"; d="scan'208";a="170413847" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 18:14:12 -0800 IronPort-SDR: FG5VJena1tLLNcROBV1bYZleVsYmyqZPUbrmEbi7ZE1fLJ47ATQq51nag0WrIEqCPOF0vhwcmM 8saeRsETa+YQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,471,1596524400"; d="scan'208";a="542055782" Received: from npg-dpdk-haiyue-3.sh.intel.com ([10.67.119.27]) by orsmga005.jf.intel.com with ESMTP; 11 Nov 2020 18:14:09 -0800 From: Haiyue Wang To: dev@dpdk.org Cc: ferruh.yigit@intel.com, qi.z.zhang@intel.com, Haiyue Wang , stable@dpdk.org, Jeff Guo , Wei Zhao , Beilei Xing , Wei Dai , Wenzhuo Lu Date: Thu, 12 Nov 2020 10:00:06 +0800 Message-Id: <20201112020006.739838-1-haiyue.wang@intel.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] [PATCH v1] net/ixgbe: remove the redundant MAC flag check X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" The flag of RTE_ETHTYPE_FLAGS_MAC has been checked twice, so remove the first error message "Not supported by ethertype filter" which is not so specific, and keep the error message "mac compare is unsupported" which aligns to the definition of RTE_ETHTYPE_FLAGS_MAC. Fixes: eb3539fc8550 ("net/ixgbe: parse ethertype filter") Cc: stable@dpdk.org Signed-off-by: Haiyue Wang --- drivers/net/ixgbe/ixgbe_flow.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c index dff04c462c..39f6ed73f6 100644 --- a/drivers/net/ixgbe/ixgbe_flow.c +++ b/drivers/net/ixgbe/ixgbe_flow.c @@ -870,15 +870,6 @@ ixgbe_parse_ethertype_filter(struct rte_eth_dev *dev, if (ret) return ret; - /* Ixgbe doesn't support MAC address. */ - if (filter->flags & RTE_ETHTYPE_FLAGS_MAC) { - memset(filter, 0, sizeof(struct rte_eth_ethertype_filter)); - rte_flow_error_set(error, EINVAL, - RTE_FLOW_ERROR_TYPE_ITEM, - NULL, "Not supported by ethertype filter"); - return -rte_errno; - } - if (filter->queue >= dev->data->nb_rx_queues) { memset(filter, 0, sizeof(struct rte_eth_ethertype_filter)); rte_flow_error_set(error, EINVAL, -- 2.29.2