From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C43A3A04DB for ; Tue, 17 Nov 2020 12:15:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BCD3D592C; Tue, 17 Nov 2020 12:15:02 +0100 (CET) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by dpdk.org (Postfix) with ESMTP id 45BC35916 for ; Tue, 17 Nov 2020 12:15:00 +0100 (CET) Received: by mail-wm1-f52.google.com with SMTP id d142so2842755wmd.4 for ; Tue, 17 Nov 2020 03:15:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vxdHVq0CcvYEEz79dGK8cISk3aPMFjSEY2RyaQXkG/o=; b=C6ZMgGcPLtl1QCot54kOH38oitpjyUzLRqwZAeP35JRV45STNQTij5Wz/q4fYAQ81z aE5ipaAVSXYxLmCajJ7IBHxXh5UWe/ydLZYLfQKdk8ICQRn2t82os5Kgh99Hh+0iTnaH yQUeM5WwQpIZK4h2rsEPVjOug5vFa38G0iOMgFP8QyVtfIzNyl0lm7Z9BFrMfJ2WEMq1 93Z5ftpX6rM3lUzmwFXW0P6npYS0hqyZRYdyUqNnNEx6u+Wrrm954vYa5ghQTd2AYcIv Pedt6FIF8mALTTOSbDrhByU6o3j8Nt05788fy9g10WZF7INMjzKHaSm5KztDqkfTTqm9 QQsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vxdHVq0CcvYEEz79dGK8cISk3aPMFjSEY2RyaQXkG/o=; b=qQ5K18ALQ/OMhgvKFy9k3PP40hk795aaY7zyhmeUZy7KlpWmRyrujhakOLwSA87J19 sT7URIg+rmswts4Iusf+tWXOKl6j4uuLSQgf6bSWmEjsu5cad/m24TIo+ecTds0+bENo g08kokRtGISCf9xKqIPtY4TFIvFI6MgS7y+R5bv5zh9RRrXf0o4vtWuJkYjJ2DIkilbt WffIgnYot9+IWHuT++WvFy4pbjUugcj177MHMciVPR2bVLsDiqrLpttuICxEgqNX1mF6 k2pwmik6rHoWKQXx6lrlANcu+sZPQF8UIvX6P3amIdy3+aPvI4AHWpikNP+5iwcfTs/t riqA== X-Gm-Message-State: AOAM533SsEaYN66EtHVGWUY6i+IM1EcyT2DTb3YOG7J0kjywZ7xH6HIS nXjqMK2BQRAvHQ4kqIFulU0= X-Google-Smtp-Source: ABdhPJw1sc2baZJDtgWv+2I4+MjyzYFuhneb2fNyJo6BXLxDnVY5tacXu07fpwK0dfVfcWIVBOQgCg== X-Received: by 2002:a1c:61c5:: with SMTP id v188mr3612619wmb.141.1605611700041; Tue, 17 Nov 2020 03:15:00 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id r9sm29124569wrg.59.2020.11.17.03.14.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 03:14:59 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Lance Richardson , Ajit Khaparde , dpdk stable Date: Tue, 17 Nov 2020 11:13:47 +0000 Message-Id: <20201117111416.1961049-13-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201117111416.1961049-1-luca.boccassi@gmail.com> References: <20201109185030.3478760-2-luca.boccassi@gmail.com> <20201117111416.1961049-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: remove useless prefetches' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/19/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/59e5c312456c883711f0f629beb818779b6912a7 Thanks. Luca Boccassi --- >From 59e5c312456c883711f0f629beb818779b6912a7 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 4 Nov 2020 09:03:10 -0800 Subject: [PATCH] net/bnxt: remove useless prefetches [ upstream commit 1ef8c6290c86caef6cc588c8737450383a59338a ] Prefetching only helps performance if it is done several 100 instructions before the actual use. The purpose of the prefetch is to read ahead, it doesn't help if the next instruction will block. The code in the bnxt driver was doing these unnecessary prefetches. Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code") Signed-off-by: Stephen Hemminger Acked-by: Lance Richardson Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index 136f0a2742..5271d02366 100644 --- a/drivers/net/bnxt/bnxt_rxr.c +++ b/drivers/net/bnxt/bnxt_rxr.c @@ -301,7 +301,6 @@ static inline struct rte_mbuf *bnxt_tpa_end( mbuf = tpa_info->mbuf; RTE_ASSERT(mbuf != NULL); - rte_prefetch0(mbuf); if (agg_bufs) { bnxt_rx_pages(rxq, mbuf, raw_cp_cons, agg_bufs, tpa_info); } @@ -475,8 +474,6 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt, if (mbuf == NULL) return -EBUSY; - rte_prefetch0(mbuf); - mbuf->data_off = RTE_PKTMBUF_HEADROOM; mbuf->nb_segs = 1; mbuf->next = NULL; @@ -625,7 +622,6 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, /* Handle RX burst request */ while (1) { cons = RING_CMP(cpr->cp_ring_struct, raw_cons); - rte_prefetch0(&cpr->cp_desc_ring[cons]); rxcmp = (struct rx_pkt_cmpl *)&cpr->cp_desc_ring[cons]; if (!CMP_VALID(rxcmp, raw_cons, cpr->cp_ring_struct)) -- 2.27.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-17 11:13:13.527322715 +0000 +++ 0013-net-bnxt-remove-useless-prefetches.patch 2020-11-17 11:13:12.877115723 +0000 @@ -1 +1 @@ -From 1ef8c6290c86caef6cc588c8737450383a59338a Mon Sep 17 00:00:00 2001 +From 59e5c312456c883711f0f629beb818779b6912a7 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1ef8c6290c86caef6cc588c8737450383a59338a ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index e375b31ed8..fdbe6f71ea 100644 +index 136f0a2742..5271d02366 100644 @@ -27 +28 @@ -@@ -306,7 +306,6 @@ static inline struct rte_mbuf *bnxt_tpa_end( +@@ -301,7 +301,6 @@ static inline struct rte_mbuf *bnxt_tpa_end( @@ -35 +36 @@ -@@ -734,8 +733,6 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt, +@@ -475,8 +474,6 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt, @@ -44 +45 @@ -@@ -867,7 +864,6 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, +@@ -625,7 +622,6 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,