From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A56EA04DB for ; Tue, 17 Nov 2020 12:15:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 14674C8B0; Tue, 17 Nov 2020 12:15:38 +0100 (CET) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 15D96C8B6 for ; Tue, 17 Nov 2020 12:15:37 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id r17so22794423wrw.1 for ; Tue, 17 Nov 2020 03:15:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=siQfUVtNsmG9sOEXz7H4u9cXWt5rRMnNCHxKi1z2LII=; b=dVAMYA8Fvb9fvY1qI400r6jUHaov7BhHOsyOURBWjXTocThPqYnFwM2xmcBeBle+ze qCDUwr7UhTJjr/u4dy3aUMr4zMhyJleKDy570oVGlzhV1MeAy4yQNFX2Fi5pceVJy50+ vc+z9ysqdnaI6fS7qHWcFU1jJgbStFTywa1Jw3IzedJRO9KkH+S33RJprriTKzhIobYb KJjpwfbrskh2/eaw1sDmP/HMJhHJ0HLTv8PBY0sTKvl+PoID9z+DRZrZFYkgKu5IZewU uTC363QBwrvJj1UvVXLmWHh0+mjTzZ5CUZpluzH9G7HkwEzSdV0dta/louWtmLsCgYeQ 4CHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=siQfUVtNsmG9sOEXz7H4u9cXWt5rRMnNCHxKi1z2LII=; b=GA7/adKWvDh8COTarTRQh6khBT/AJakCi86kbIzNh4oCHj7tTeZ0D0btqQlGpdqJRY IlBc5jegmWzfOHfGR5jzF0xA1/EgeunV+sheJ2VdXmyN/nDa1rKdeXWIkf5mdePAgBzx drCGOO+Ve9cwQZ6KFLm7oFf91x7RRv2EJ5758bY5tPC1o6oJjzap/3nlCRz7t2j5/CaD aLlgcA1xy3YrNiLZZWStpX0Ig0FNltziL+JTdWAEhbIMtIV67/WVWj4i5eIi/fF3EX8l i3gIxegcijswvLPmLsfHqGNYX3r72hyiIV1YiNFR4I1XNIxf43H+IvbX2i+1oljHG+Ot s+HQ== X-Gm-Message-State: AOAM530fd3ZNCDveC+DPcVVoMRs6M/ud4RXxmrExhJ9/e7s1Tb2/3HRG a9LvR3kV1KjUYbC5YvEZQktctAU27xZbJEeB X-Google-Smtp-Source: ABdhPJyW2tiLNNo1MtsrB+OfeXp3tW+y97FPdoVhK7jp8sM3V17PV+Hir1Rj6lFLu3CX376N609zhw== X-Received: by 2002:adf:c50e:: with SMTP id q14mr23345105wrf.270.1605611735872; Tue, 17 Nov 2020 03:15:35 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id c17sm3039892wml.14.2020.11.17.03.15.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 03:15:35 -0800 (PST) From: luca.boccassi@gmail.com To: Leyi Rong Cc: Qi Zhang , dpdk stable Date: Tue, 17 Nov 2020 11:13:59 +0000 Message-Id: <20201117111416.1961049-25-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201117111416.1961049-1-luca.boccassi@gmail.com> References: <20201109185030.3478760-2-luca.boccassi@gmail.com> <20201117111416.1961049-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/iavf: fix performance drop after port reset' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/19/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/ba72266c10ae7e8b9bf9ecbc9fc807b1ae7e861b Thanks. Luca Boccassi --- >From ba72266c10ae7e8b9bf9ecbc9fc807b1ae7e861b Mon Sep 17 00:00:00 2001 From: Leyi Rong Date: Thu, 12 Nov 2020 13:51:54 +0800 Subject: [PATCH] net/iavf: fix performance drop after port reset [ upstream commit 63b7be7870c1eef53808f796f815b9b34ba36325 ] Needs to reset rxq->rxrearm_start to 0 when reset_rx_queue(), otherwise, the random value of rxrearm_start will cause performance drop due to L3 contested accesses. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Signed-off-by: Leyi Rong Acked-by: Qi Zhang --- drivers/net/iavf/iavf_rxtx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 9672666567..ae43eb49a6 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -168,6 +168,7 @@ reset_rx_queue(struct iavf_rx_queue *rxq) rxq->pkt_first_seg = NULL; rxq->pkt_last_seg = NULL; rxq->rxrearm_nb = 0; + rxq->rxrearm_start = 0; } static inline void -- 2.27.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-17 11:13:14.041004865 +0000 +++ 0025-net-iavf-fix-performance-drop-after-port-reset.patch 2020-11-17 11:13:12.921116609 +0000 @@ -1 +1 @@ -From 63b7be7870c1eef53808f796f815b9b34ba36325 Mon Sep 17 00:00:00 2001 +From ba72266c10ae7e8b9bf9ecbc9fc807b1ae7e861b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 63b7be7870c1eef53808f796f815b9b34ba36325 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 8f43208c80..21d508b3f4 100644 +index 9672666567..ae43eb49a6 100644 @@ -23 +24 @@ -@@ -195,6 +195,7 @@ reset_rx_queue(struct iavf_rx_queue *rxq) +@@ -168,6 +168,7 @@ reset_rx_queue(struct iavf_rx_queue *rxq)