From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00364A04DD for ; Wed, 18 Nov 2020 17:38:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9E36FC96C; Wed, 18 Nov 2020 17:37:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 73038C958 for ; Wed, 18 Nov 2020 17:37:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605717452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PNDeEdKYnuFnlzJDO34qDpyTCZbTlEcs7ZCSxhN/ZP8=; b=WxIjr1DtWhf/KvxBesrS/TQTF/aXwEKaBaLuH7ksZpVBn6rF9oZiYZc+1xSbPnTYFa8GBt CEiEUFG9b1WuW9Xhf3DHaogGjyIZhY5eFX9F3RZk1uvAiBOBMjaUoB4BKhuXeJpDlXnyAT HJLV2G+HV7Z3ItWzDjpHAapIVpIwiZA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-IVhmALRFPNCiJX3OUg-AmQ-1; Wed, 18 Nov 2020 11:37:27 -0500 X-MC-Unique: IVhmALRFPNCiJX3OUg-AmQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E4FC1190B2A0; Wed, 18 Nov 2020 16:37:09 +0000 (UTC) Received: from rh.redhat.com (ovpn-113-249.ams2.redhat.com [10.36.113.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id C38E75C1A3; Wed, 18 Nov 2020 16:37:08 +0000 (UTC) From: Kevin Traynor To: Lukasz Wojciechowski Cc: Honnappa Nagarahalli , dpdk stable Date: Wed, 18 Nov 2020 16:35:18 +0000 Message-Id: <20201118163558.1101823-32-ktraynor@redhat.com> In-Reply-To: <20201118163558.1101823-1-ktraynor@redhat.com> References: <20201118163558.1101823-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'test/distributor: fix quitting workers in burst mode' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/159e26b128ea69ca55e387ef541e70f4c261924a Thanks. Kevin. --- >From 159e26b128ea69ca55e387ef541e70f4c261924a Mon Sep 17 00:00:00 2001 From: Lukasz Wojciechowski Date: Sat, 17 Oct 2020 05:07:01 +0200 Subject: [PATCH] test/distributor: fix quitting workers in burst mode [ upstream commit f72bff0ec2723b7d7bfc9c655419030b1c8fffad ] Sending number of packets equal to number of workers isn't enough to stop all workers in burst version of distributor as more than one packet can be matched and consumed by a single worker. This way some of workers might not be awaken from rte_distributor_get_pkt(). This patch fixes it by sending packets one by one. Each sent packet causes exactly one worker to quit. Fixes: 775003ad2f96 ("distributor: add new burst-capable library") Signed-off-by: Lukasz Wojciechowski Reviewed-by: Honnappa Nagarahalli --- test/test/test_distributor.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/test/test_distributor.c b/test/test/test_distributor.c index 459f75b96a..e00966366d 100644 --- a/test/test/test_distributor.c +++ b/test/test/test_distributor.c @@ -612,7 +612,8 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p) zero_quit = 0; quit = 1; - for (i = 0; i < num_workers; i++) + for (i = 0; i < num_workers; i++) { bufs[i]->hash.usr = i << 1; - rte_distributor_process(d, bufs, num_workers); + rte_distributor_process(d, &bufs[i], 1); + } rte_distributor_process(d, NULL, 0); -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-18 16:33:38.555745692 +0000 +++ 0032-test-distributor-fix-quitting-workers-in-burst-mode.patch 2020-11-18 16:33:37.934215065 +0000 @@ -1 +1 @@ -From f72bff0ec2723b7d7bfc9c655419030b1c8fffad Mon Sep 17 00:00:00 2001 +From 159e26b128ea69ca55e387ef541e70f4c261924a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f72bff0ec2723b7d7bfc9c655419030b1c8fffad ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ - app/test/test_distributor.c | 5 +++-- + test/test/test_distributor.c | 5 +++-- @@ -23,5 +24,5 @@ -diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c -index a4af0a39c6..e0cb698e1c 100644 ---- a/app/test/test_distributor.c -+++ b/app/test/test_distributor.c -@@ -770,7 +770,8 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p) +diff --git a/test/test/test_distributor.c b/test/test/test_distributor.c +index 459f75b96a..e00966366d 100644 +--- a/test/test/test_distributor.c ++++ b/test/test/test_distributor.c +@@ -612,7 +612,8 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p)