From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25413A04DD for ; Wed, 18 Nov 2020 17:36:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1F96B160; Wed, 18 Nov 2020 17:36:39 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 0FC03160 for ; Wed, 18 Nov 2020 17:36:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605717396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KgZpSqQRlsOfXNfIQokPQQLqqmmeqIqB3xMkHwmfG24=; b=fMPtQtb6zMrgdjZ0XDXZe8Xa+IZvAkiz7gNKHWGouHZhe3Gp+dbT8BoQGVPYVlKQzhoudU OKGn5qWfyqdPxYhGUBRtS6aPWq1ggQadzax7vAODDqdLEKkVnDzF4JCMnuKmCzSIBVZaoH 0pdZx8YtuldNpCrXf+v8U2rOdfXSXis= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-281-ZAuVD6Y8MMqXvq8duUMf3w-1; Wed, 18 Nov 2020 11:36:32 -0500 X-MC-Unique: ZAuVD6Y8MMqXvq8duUMf3w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 031DECEC69; Wed, 18 Nov 2020 16:36:26 +0000 (UTC) Received: from rh.redhat.com (ovpn-113-249.ams2.redhat.com [10.36.113.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id BFC845F9DB; Wed, 18 Nov 2020 16:36:20 +0000 (UTC) From: Kevin Traynor To: Yunjian Wang Cc: Nipun Gupta , dpdk stable Date: Wed, 18 Nov 2020 16:34:50 +0000 Message-Id: <20201118163558.1101823-4-ktraynor@redhat.com> In-Reply-To: <20201118163558.1101823-1-ktraynor@redhat.com> References: <20201118163558.1101823-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'event/dpaa2: fix dereference before null check' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/09979638d692146300b1626c39142506c56cc2a0 Thanks. Kevin. --- >From 09979638d692146300b1626c39142506c56cc2a0 Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Wed, 26 Aug 2020 21:07:40 +0800 Subject: [PATCH] event/dpaa2: fix dereference before null check [ upstream commit db5e0e7aea5e256c43489a3b272a4318b6ddca9f ] Coverity flags that 'portal' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 323516 Fixes: 4ab57b042e7c ("event/dpaa2: affine portal at runtime during I/O") Signed-off-by: Yunjian Wang Acked-by: Nipun Gupta --- drivers/event/dpaa2/dpaa2_eventdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index f647430b26..1cf9e659e3 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/drivers/event/dpaa2/dpaa2_eventdev.c @@ -554,12 +554,12 @@ dpaa2_eventdev_port_release(void *port) EVENTDEV_INIT_FUNC_TRACE(); + if (portal == NULL) + return; + /* TODO: Cleanup is required when ports are in linked state. */ if (portal->is_port_linked) DPAA2_EVENTDEV_WARN("Event port must be unlinked before release"); - if (portal) - rte_free(portal); - - portal = NULL; + rte_free(portal); } -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-18 16:33:38.071515697 +0000 +++ 0004-event-dpaa2-fix-dereference-before-null-check.patch 2020-11-18 16:33:37.898215042 +0000 @@ -1 +1 @@ -From db5e0e7aea5e256c43489a3b272a4318b6ddca9f Mon Sep 17 00:00:00 2001 +From 09979638d692146300b1626c39142506c56cc2a0 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit db5e0e7aea5e256c43489a3b272a4318b6ddca9f ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 3ae4441ee3..f7383ca738 100644 +index f647430b26..1cf9e659e3 100644 @@ -23 +24 @@ -@@ -570,12 +570,12 @@ dpaa2_eventdev_port_release(void *port) +@@ -554,12 +554,12 @@ dpaa2_eventdev_port_release(void *port)