From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8ECF3A04DD for ; Wed, 18 Nov 2020 17:37:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 52BDAC954; Wed, 18 Nov 2020 17:37:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 9948BC954 for ; Wed, 18 Nov 2020 17:37:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605717451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4YalaQdORtG9lGYn6J4nJC1OkUwbeHKf30zoQ8Tsx9A=; b=JBBfjYITN6MFN2jgSyo2yxBl+x/adwdUf5MGDON7XMsQzLV7xjnnRinOXhVaL5ew+PA0Yk 0MvDJPBuap0V1ZXK3derain7iC4kwPb0bfGb30oY1xO+eulmhB41G4y4PTu8xRjdTKd0tI aXJ1Jt9GCHGoQnvc8VoTxVX+70CS5/Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-465-rN_myYe2MmG2JUMNv0FE-w-1; Wed, 18 Nov 2020 11:37:28 -0500 X-MC-Unique: rN_myYe2MmG2JUMNv0FE-w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8D12B1075653; Wed, 18 Nov 2020 16:37:24 +0000 (UTC) Received: from rh.redhat.com (ovpn-113-249.ams2.redhat.com [10.36.113.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id E3EEE5C1A3; Wed, 18 Nov 2020 16:37:22 +0000 (UTC) From: Kevin Traynor To: Yunjian Wang Cc: Jeff Guo , David Marchand , dpdk stable Date: Wed, 18 Nov 2020 16:35:26 +0000 Message-Id: <20201118163558.1101823-40-ktraynor@redhat.com> In-Reply-To: <20201118163558.1101823-1-ktraynor@redhat.com> References: <20201118163558.1101823-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'eal: fix leak on device event callback unregister' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/fc06dbfb1cffe80a4cbc960197baae92415a2632 Thanks. Kevin. --- >From fc06dbfb1cffe80a4cbc960197baae92415a2632 Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Wed, 21 Oct 2020 19:19:03 +0800 Subject: [PATCH] eal: fix leak on device event callback unregister [ upstream commit c78bd27d4b74a74261b180cb8d5421b919c1ab9a ] The event_cb->dev_name is not freed when freeing event_cb, and this causes a memory leak. Fixes: a753e53d517b ("eal: add device event monitor framework") Signed-off-by: Yunjian Wang Acked-by: Jeff Guo Acked-by: David Marchand --- lib/librte_eal/common/eal_common_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c index dc2bc0c984..e0fabd3c12 100644 --- a/lib/librte_eal/common/eal_common_dev.c +++ b/lib/librte_eal/common/eal_common_dev.c @@ -527,4 +527,5 @@ rte_dev_event_callback_unregister(const char *device_name, if (event_cb->active == 0) { TAILQ_REMOVE(&dev_event_cbs, event_cb, next); + free(event_cb->dev_name); free(event_cb); ret++; -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-18 16:33:38.692864186 +0000 +++ 0040-eal-fix-leak-on-device-event-callback-unregister.patch 2020-11-18 16:33:37.939215068 +0000 @@ -1 +1 @@ -From c78bd27d4b74a74261b180cb8d5421b919c1ab9a Mon Sep 17 00:00:00 2001 +From fc06dbfb1cffe80a4cbc960197baae92415a2632 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c78bd27d4b74a74261b180cb8d5421b919c1ab9a ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 9e4f09d83e..363a2ca95e 100644 +index dc2bc0c984..e0fabd3c12 100644