From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F4B2A04DD for ; Wed, 18 Nov 2020 17:36:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 35F6B160; Wed, 18 Nov 2020 17:36:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 41B4E160 for ; Wed, 18 Nov 2020 17:36:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605717402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b09yPk+Igou/hFVXNr/iKGuLXiLdm4FRAeAkI3d44/g=; b=RZSCnadoXiXnzr0Dl3s0sR37ye83fEXUYUKiDprckOJB36FGo5E04tagw51Ipq7ntV9jHM wRrMyLbUNhE1lP4vqSjbilDQBzR3TFRqO3rdxKd8WY/XOJEQSgCELUOeCOQWBkriu4znDo H1f+wMd4pViQN6DAcW2cOBjOppOR9mg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-256-2AR-mkvOM1C03wlNAFYecQ-1; Wed, 18 Nov 2020 11:36:39 -0500 X-MC-Unique: 2AR-mkvOM1C03wlNAFYecQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 416DE6D258; Wed, 18 Nov 2020 16:36:27 +0000 (UTC) Received: from rh.redhat.com (ovpn-113-249.ams2.redhat.com [10.36.113.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3305368D89; Wed, 18 Nov 2020 16:36:26 +0000 (UTC) From: Kevin Traynor To: Yunjian Wang Cc: Jerin Jacob , dpdk stable Date: Wed, 18 Nov 2020 16:34:51 +0000 Message-Id: <20201118163558.1101823-5-ktraynor@redhat.com> In-Reply-To: <20201118163558.1101823-1-ktraynor@redhat.com> References: <20201118163558.1101823-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'eventdev: fix adapter leak in error path' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/f7e487f1bc95b74acf81cc4ccdfcc58acf73c38e Thanks. Kevin. --- >From f7e487f1bc95b74acf81cc4ccdfcc58acf73c38e Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Tue, 29 Sep 2020 21:46:33 +0800 Subject: [PATCH] eventdev: fix adapter leak in error path [ upstream commit b7b09dab5e9507541222d1d2ce86f55e9eb32b9e ] In rte_event_crypto_adapter_create_ext() allocated memory for adapter, we should free it when error happens, otherwise it will lead to memory leak. Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") Signed-off-by: Yunjian Wang Acked-by: Jerin Jacob --- lib/librte_eventdev/rte_event_crypto_adapter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c b/lib/librte_eventdev/rte_event_crypto_adapter.c index 5faf3c900c..7e48bc619f 100644 --- a/lib/librte_eventdev/rte_event_crypto_adapter.c +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c @@ -241,4 +241,5 @@ rte_event_crypto_adapter_create_ext(uint8_t id, uint8_t dev_id, RTE_EDEV_LOG_ERR("Failed to get info for eventdev %d: %s!", dev_id, dev_info.driver_name); + rte_free(adapter); return ret; } -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-18 16:33:38.087948812 +0000 +++ 0005-eventdev-fix-adapter-leak-in-error-path.patch 2020-11-18 16:33:37.899215043 +0000 @@ -1 +1 @@ -From b7b09dab5e9507541222d1d2ce86f55e9eb32b9e Mon Sep 17 00:00:00 2001 +From f7e487f1bc95b74acf81cc4ccdfcc58acf73c38e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b7b09dab5e9507541222d1d2ce86f55e9eb32b9e ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 8f25933163..b04312128a 100644 +index 5faf3c900c..7e48bc619f 100644 @@ -23 +24 @@ -@@ -242,4 +242,5 @@ rte_event_crypto_adapter_create_ext(uint8_t id, uint8_t dev_id, +@@ -241,4 +241,5 @@ rte_event_crypto_adapter_create_ext(uint8_t id, uint8_t dev_id,