From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E18D9A04DD for ; Wed, 18 Nov 2020 17:39:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A035C928; Wed, 18 Nov 2020 17:38:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 504C9C904 for ; Wed, 18 Nov 2020 17:38:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605717511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jaS8PPl0lObUW1QAlxf/OHlSXhCvjje4zU72Er8tTWo=; b=ETEtxhs1SYorFcKHViA6MMtpP7t4OHHoUCJmVTcIp1IqhJEkfsIW5DgkuVxTYyjxSH6N1j lQmNVThgGLx8ita0oH/rbKfXFcpfRipAD9blToH2CNS2lRvG67QE87hoRHu5D1Vqpykade kFnHA9H9FkpWWTHTRbI1J7pVldzQv+8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-216-1ZcBmq3fMHyqzeRxEsM7cw-1; Wed, 18 Nov 2020 11:38:28 -0500 X-MC-Unique: 1ZcBmq3fMHyqzeRxEsM7cw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 036AACEC60; Wed, 18 Nov 2020 16:38:27 +0000 (UTC) Received: from rh.redhat.com (ovpn-113-249.ams2.redhat.com [10.36.113.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id 01B675C1A3; Wed, 18 Nov 2020 16:38:25 +0000 (UTC) From: Kevin Traynor To: Zhenghua Zhou Cc: Ferruh Yigit , dpdk stable Date: Wed, 18 Nov 2020 16:35:54 +0000 Message-Id: <20201118163558.1101823-68-ktraynor@redhat.com> In-Reply-To: <20201118163558.1101823-1-ktraynor@redhat.com> References: <20201118163558.1101823-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'app/testpmd: do not allow dynamic change of core number' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/266047e5921bb30d4f60ffa3c746f81453bf62b9 Thanks. Kevin. --- >From 266047e5921bb30d4f60ffa3c746f81453bf62b9 Mon Sep 17 00:00:00 2001 From: Zhenghua Zhou Date: Tue, 27 Oct 2020 06:42:52 +0000 Subject: [PATCH] app/testpmd: do not allow dynamic change of core number [ upstream commit 653c6ed4a12ad40e476a8936b4f463e01acfbf78 ] When the number of forwarding cores changed in runtime, the issue may be encountered: If the nbcore set little than current nbcore, the forwarding thread will still running on the extra cores. Therefore, trying to stop forwarding will hang testpmd, since it will wait for the extra cores to stop. So do not allow to change nbcore number when forwarding is running. Fixes: 0c0db76f42ed ("app/testpmd: separate forward config setup from display") Signed-off-by: Zhenghua Zhou Acked-by: Ferruh Yigit --- app/test-pmd/config.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index e60f5db33b..7750fe4191 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2507,4 +2507,8 @@ void set_fwd_lcores_number(uint16_t nb_lc) { + if (test_done == 0) { + printf("Please stop forwarding first\n"); + return; + } if (nb_lc > nb_cfg_lcores) { printf("nb fwd cores %u > %u (max. number of configured " -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-18 16:33:39.207639086 +0000 +++ 0068-app-testpmd-do-not-allow-dynamic-change-of-core-numb.patch 2020-11-18 16:33:37.996215105 +0000 @@ -1 +1 @@ -From 653c6ed4a12ad40e476a8936b4f463e01acfbf78 Mon Sep 17 00:00:00 2001 +From 266047e5921bb30d4f60ffa3c746f81453bf62b9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 653c6ed4a12ad40e476a8936b4f463e01acfbf78 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 136f4e5dbe..755d1dfc9c 100644 +index e60f5db33b..7750fe4191 100644 @@ -28 +29 @@ -@@ -3505,4 +3505,8 @@ void +@@ -2507,4 +2507,8 @@ void