From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8AD3A04B1 for ; Mon, 23 Nov 2020 18:13:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 20BFFC900; Mon, 23 Nov 2020 18:13:11 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id CA6AAA3 for ; Mon, 23 Nov 2020 18:13:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606151586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HBnrjNzkJdgBVuoTXbEQ0GDeZdJIUAjSq8xH4cc2TMU=; b=DT0l53SGWfl9Cy36p/w6eUTtjoymBuFUb2OYhlZa5HYymu02LH3ty70ho9YqaDXtOmTl6j qpqiLax3sQmq9hyTLxq5EbL8O4UnDYNKIJokOS0VPSliMMVDwNlgKnSHuWMFMCX21nAx5q tVo1L/CXeBK0AgmnEt1ubmzFeCQ1iEQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-90-ZPQh5ED1NiimzXa8CuwrYA-1; Mon, 23 Nov 2020 12:13:00 -0500 X-MC-Unique: ZPQh5ED1NiimzXa8CuwrYA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CB8901034B20; Mon, 23 Nov 2020 17:12:59 +0000 (UTC) Received: from rh.redhat.com (ovpn-112-19.ams2.redhat.com [10.36.112.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id D50F260C04; Mon, 23 Nov 2020 17:12:58 +0000 (UTC) From: Kevin Traynor To: Leyi Rong Cc: Qi Zhang , dpdk stable Date: Mon, 23 Nov 2020 17:12:03 +0000 Message-Id: <20201123171222.79398-11-ktraynor@redhat.com> In-Reply-To: <20201123171222.79398-1-ktraynor@redhat.com> References: <20201123171222.79398-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'net/avf: fix performance drop after port reset' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/27/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/82d2e03c1e709217c4a11d179ad9b1a7ff4dce71 Thanks. Kevin. --- >From 82d2e03c1e709217c4a11d179ad9b1a7ff4dce71 Mon Sep 17 00:00:00 2001 From: Leyi Rong Date: Thu, 12 Nov 2020 13:51:54 +0800 Subject: [PATCH] net/avf: fix performance drop after port reset [ upstream commit 63b7be7870c1eef53808f796f815b9b34ba36325 ] Needs to reset rxq->rxrearm_start to 0 when reset_rx_queue(), otherwise, the random value of rxrearm_start will cause performance drop due to L3 contested accesses. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Signed-off-by: Leyi Rong Acked-by: Qi Zhang --- drivers/net/avf/avf_rxtx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c index 33670fdb1c..79ab94513c 100644 --- a/drivers/net/avf/avf_rxtx.c +++ b/drivers/net/avf/avf_rxtx.c @@ -171,4 +171,5 @@ reset_rx_queue(struct avf_rx_queue *rxq) rxq->pkt_last_seg = NULL; rxq->rxrearm_nb = 0; + rxq->rxrearm_start = 0; } -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-23 17:10:14.254152670 +0000 +++ 0011-net-avf-fix-performance-drop-after-port-reset.patch 2020-11-23 17:10:13.978061568 +0000 @@ -1 +1 @@ -From 63b7be7870c1eef53808f796f815b9b34ba36325 Mon Sep 17 00:00:00 2001 +From 82d2e03c1e709217c4a11d179ad9b1a7ff4dce71 Mon Sep 17 00:00:00 2001 @@ -4 +4,3 @@ -Subject: [PATCH] net/iavf: fix performance drop after port reset +Subject: [PATCH] net/avf: fix performance drop after port reset + +[ upstream commit 63b7be7870c1eef53808f796f815b9b34ba36325 ] @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -16 +17 @@ - drivers/net/iavf/iavf_rxtx.c | 1 + + drivers/net/avf/avf_rxtx.c | 1 + @@ -19,5 +20,5 @@ -diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c -index 8f43208c80..21d508b3f4 100644 ---- a/drivers/net/iavf/iavf_rxtx.c -+++ b/drivers/net/iavf/iavf_rxtx.c -@@ -196,4 +196,5 @@ reset_rx_queue(struct iavf_rx_queue *rxq) +diff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c +index 33670fdb1c..79ab94513c 100644 +--- a/drivers/net/avf/avf_rxtx.c ++++ b/drivers/net/avf/avf_rxtx.c +@@ -171,4 +171,5 @@ reset_rx_queue(struct avf_rx_queue *rxq)