From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B09BA04B1 for ; Mon, 23 Nov 2020 18:13:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 528EBC90C; Mon, 23 Nov 2020 18:13:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id E5F15C910 for ; Mon, 23 Nov 2020 18:13:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606151611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WrgAxMrl/6HUQQFC6Ydy3A4fzgg4yJ0yoUdVCck7LRM=; b=UCpb/UfW1YVL8A0fzDlj+fG3Bir314yD6Wa7kH9WRyewnnurPX+cRVHzfuYddA4yiEJWqf FqE7cEUyko0QKy8P0uaLD4ehnqu2R3YoU20sBLjehWw98dEzplhBEf/QTvRu5VfaXlVau6 oc//ubINouDegAEznCriVxOXabKhoCk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-40-9fyDNjwnN9K34DB2at0P1A-1; Mon, 23 Nov 2020 12:13:28 -0500 X-MC-Unique: 9fyDNjwnN9K34DB2at0P1A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C416D1868406; Mon, 23 Nov 2020 17:13:26 +0000 (UTC) Received: from rh.redhat.com (ovpn-112-19.ams2.redhat.com [10.36.112.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id A047960C04; Mon, 23 Nov 2020 17:13:25 +0000 (UTC) From: Kevin Traynor To: Ferruh Yigit Cc: Bo Chen , dpdk stable Date: Mon, 23 Nov 2020 17:12:17 +0000 Message-Id: <20201123171222.79398-25-ktraynor@redhat.com> In-Reply-To: <20201123171222.79398-1-ktraynor@redhat.com> References: <20201123171222.79398-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'app/testpmd: revert setting MTU explicitly after configure' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/27/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/6326a29a056706db93e58067626eb2a3340a3a4c Thanks. Kevin. --- >From 6326a29a056706db93e58067626eb2a3340a3a4c Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Mon, 16 Nov 2020 19:03:54 +0000 Subject: [PATCH] app/testpmd: revert setting MTU explicitly after configure [ upstream commit 56f0534311d4c61c63e2455169749ae440278122 ] Setting MTU after each 'rte_eth_dev_configure()' prevents using "--max-pkt-len=N" parameter and "port config all max-pkt-len #" command This is breaking DTS scatter test case which is using "--max-pkt-len=9000" testpmd parameter. Reverting workaround to recover the DTS testcase. Fixes: 1c21ee95cf52 ("app/testpmd: fix MTU after device configure") Signed-off-by: Ferruh Yigit Tested-by: Bo Chen --- app/test-pmd/testpmd.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 21eb315983..018bd32ec6 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1969,6 +1969,4 @@ start_port(portid_t pid) if (port->need_reconfig > 0) { - uint16_t mtu = RTE_ETHER_MTU; - port->need_reconfig = 0; @@ -1997,21 +1995,4 @@ start_port(portid_t pid) return -1; } - - /* - * Workaround for rte_eth_dev_configure(), max_rx_pkt_len - * set MTU wrong for the PMDs that have frame overhead - * bigger than RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN. - * For a PMD that has 26 bytes overhead, rte_eth_dev_configure() - * can set MTU to max 1492, not to expected 1500 bytes. - * Using rte_eth_dev_set_mtu() to be able to set MTU correctly, - * default MTU value is 1500. - */ - diag = rte_eth_dev_get_mtu(pi, &mtu); - if (diag) - printf("Failed to get MTU for port %d\n", pi); - diag = rte_eth_dev_set_mtu(pi, mtu); - if (diag != 0 && diag != -ENOTSUP) - printf("Failed to set MTU to %u for port %d\n", - mtu, pi); } if (port->need_reconfig_queues > 0) { -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-23 17:10:14.583915439 +0000 +++ 0025-app-testpmd-revert-setting-MTU-explicitly-after-conf.patch 2020-11-23 17:10:14.012061606 +0000 @@ -1 +1 @@ -From 56f0534311d4c61c63e2455169749ae440278122 Mon Sep 17 00:00:00 2001 +From 6326a29a056706db93e58067626eb2a3340a3a4c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 56f0534311d4c61c63e2455169749ae440278122 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 48e9647fc7..33fc0fddf5 100644 +index 21eb315983..018bd32ec6 100644 @@ -27 +28 @@ -@@ -2538,6 +2538,4 @@ start_port(portid_t pid) +@@ -1969,6 +1969,4 @@ start_port(portid_t pid) @@ -34 +35 @@ -@@ -2573,21 +2571,4 @@ start_port(portid_t pid) +@@ -1997,21 +1995,4 @@ start_port(portid_t pid)