From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29074A04DB for ; Mon, 30 Nov 2020 12:50:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B47E0C966; Mon, 30 Nov 2020 12:50:38 +0100 (CET) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by dpdk.org (Postfix) with ESMTP id 700455928 for ; Mon, 30 Nov 2020 12:50:36 +0100 (CET) Received: by mail-wr1-f45.google.com with SMTP id u12so15828279wrt.0 for ; Mon, 30 Nov 2020 03:50:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iW74+60ltffMsFBl1cKfiOYlTCau/XR2J1gMHaV3t1c=; b=RXbZ8NuGqHrKWw940JsJ3d5nWqTOMy2oclv/DO8ZquXSPxirNvUyg4S+X0ntmxr7UF mbf//RuHApglN5u2XQFigHutrmWAQUt/IgOnV92sk4m0EUKVrB5Q2oxJiSHLkFbZFR3i qYvjgpEh0RUQq/0sN+N5OJ4nYwSRa7in3gKlPwHCEmC+NbxXBTiAbRWcbNzb0au8lJ27 eiofBG58nZJy3NhzEjup8P3ATmXjxkMHbzDwxF9fsIpA77/lN4l0+hYxnyooB+2TfpTg Rk0kF6E4YXLcoX7ikglAdGbAwg+0131agEIlp8PjYt92VsM5SLFp8jujifjl6FX5AMo1 6+xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iW74+60ltffMsFBl1cKfiOYlTCau/XR2J1gMHaV3t1c=; b=AVqeEyAE5CXpE0BUN43UI6sCpa/0CnZcj/xGyCQEznegXlxkUt6JIkiGVraw+AMXGI K1rikzZRjsAXu9WoZTJUoeH+xj2oSDj/QgGwf4OaRPc77DAmj/Ih3fpx6kSQLTiLaWSZ 9PSERARlVTfI8huu74ow05rRLzR86mhtm5b3IaSW7nKi8ZOY3RnXSvaRFFLOTe3Cn5FE TgkC1r3kIw4yy/0qlunZKuwoEEVF6b2ds3L0UlRsnlXuYPac2nRxOOF6qNHA37sMb2jy PTlWHndVSuMfrK944RKiZuoMjr3p2Nac69LzgZjwNzz8garDZndjosAyUcVtuSxI7kHo dx5g== X-Gm-Message-State: AOAM531BwHgEP0Yzk3wgM0NUMi5TtkcXws+QOYG+6GRbjYsxfyzxYN3+ tgfstZ2eyUN2VbOr3ooYhu0= X-Google-Smtp-Source: ABdhPJx+EosWcY2P5FJyrMj9+yuyhlG8tPnQQ4Kg5weLpFgK8IL61kFyGcwNr7w3xr8o4PQXxqYT4Q== X-Received: by 2002:adf:9e4d:: with SMTP id v13mr26700224wre.135.1606737036207; Mon, 30 Nov 2020 03:50:36 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id o203sm18285137wmb.0.2020.11.30.03.50.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 03:50:35 -0800 (PST) From: luca.boccassi@gmail.com To: Sarosh Arif Cc: David Marchand , dpdk stable Date: Mon, 30 Nov 2020 11:50:22 +0000 Message-Id: <20201130115027.64046-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201130115027.64046-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> <20201130115027.64046-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'doc: fix grammar' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/d91d1aa17e33d647bc582336ada1d3538e395cb9 Thanks. Luca Boccassi --- >From d91d1aa17e33d647bc582336ada1d3538e395cb9 Mon Sep 17 00:00:00 2001 From: Sarosh Arif Date: Wed, 16 Sep 2020 16:14:38 +0500 Subject: [PATCH] doc: fix grammar [ upstream commit c053d9e9629b2337093dfd344eb904f0aff703bd ] This patch corrects a grammatical error by changing 'an DPDK' to 'a DPDK', so that the sentences can become grammatically accurate. Fixes: 2e486e26328c ("doc: remove Intel references from linux guide") Fixes: 48624fd96e7c ("doc: remove Intel references from prog guide") Fixes: e0c7c4731957 ("doc: remove Intel references from sample apps guide") Signed-off-by: Sarosh Arif Reviewed-by: David Marchand --- doc/guides/linux_gsg/build_sample_apps.rst | 4 ++-- doc/guides/linux_gsg/enable_func.rst | 2 +- doc/guides/linux_gsg/linux_drivers.rst | 2 +- doc/guides/linux_gsg/sys_reqs.rst | 2 +- doc/guides/prog_guide/multi_proc_support.rst | 2 +- doc/guides/sample_app_ug/l3_forward_power_man.rst | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/guides/linux_gsg/build_sample_apps.rst b/doc/guides/linux_gsg/build_sample_apps.rst index 2f606535c3..2c2f5faec5 100644 --- a/doc/guides/linux_gsg/build_sample_apps.rst +++ b/doc/guides/linux_gsg/build_sample_apps.rst @@ -4,7 +4,7 @@ Compiling and Running Sample Applications ========================================= -The chapter describes how to compile and run applications in an DPDK environment. +The chapter describes how to compile and run applications in a DPDK environment. It also provides a pointer to where sample applications are stored. .. note:: @@ -185,7 +185,7 @@ Each bit of the mask corresponds to the equivalent logical core number as report Since these logical core numbers, and their mapping to specific cores on specific NUMA sockets, can vary from platform to platform, it is recommended that the core layout for each platform be considered when choosing the coremask/corelist to use in each case. -On initialization of the EAL layer by an DPDK application, the logical cores to be used and their socket location are displayed. +On initialization of the EAL layer by a DPDK application, the logical cores to be used and their socket location are displayed. This information can also be determined for all cores on the system by examining the ``/proc/cpuinfo`` file, for example, by running cat ``/proc/cpuinfo``. The physical id attribute listed for each processor indicates the CPU socket to which it belongs. This can be useful when using other processors to understand the mapping of the logical cores to the sockets. diff --git a/doc/guides/linux_gsg/enable_func.rst b/doc/guides/linux_gsg/enable_func.rst index b2bda80bb7..ad11bc9e4e 100644 --- a/doc/guides/linux_gsg/enable_func.rst +++ b/doc/guides/linux_gsg/enable_func.rst @@ -112,7 +112,7 @@ In addition, C3 and C6 should be enabled as well for power management. The path Using Linux Core Isolation to Reduce Context Switches ----------------------------------------------------- -While the threads used by an DPDK application are pinned to logical cores on the system, +While the threads used by a DPDK application are pinned to logical cores on the system, it is possible for the Linux scheduler to run other tasks on those cores also. To help prevent additional workloads from running on those cores, it is possible to use the ``isolcpus`` Linux kernel parameter to isolate them from the general Linux scheduler. diff --git a/doc/guides/linux_gsg/linux_drivers.rst b/doc/guides/linux_gsg/linux_drivers.rst index e0816f996e..96817e78cd 100644 --- a/doc/guides/linux_gsg/linux_drivers.rst +++ b/doc/guides/linux_gsg/linux_drivers.rst @@ -120,7 +120,7 @@ Binding and Unbinding Network Ports to/from the Kernel Modules PMDs Which use the bifurcated driver should not be unbind from their kernel drivers. this section is for PMDs which use the UIO or VFIO drivers. As of release 1.4, DPDK applications no longer automatically unbind all supported network ports from the kernel driver in use. -Instead, in case the PMD being used use the UIO or VFIO drivers, all ports that are to be used by an DPDK application must be bound to the +Instead, in case the PMD being used use the UIO or VFIO drivers, all ports that are to be used by a DPDK application must be bound to the ``uio_pci_generic``, ``igb_uio`` or ``vfio-pci`` module before the application is run. For such PMDs, any network ports under Linux* control will be ignored and cannot be used by the application. diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst index 7c47ec04ce..cf760a6c67 100644 --- a/doc/guides/linux_gsg/sys_reqs.rst +++ b/doc/guides/linux_gsg/sys_reqs.rst @@ -107,7 +107,7 @@ e.g. :doc:`../nics/index` Running DPDK Applications ------------------------- -To run an DPDK application, some customization may be required on the target machine. +To run a DPDK application, some customization may be required on the target machine. System Software ~~~~~~~~~~~~~~~ diff --git a/doc/guides/prog_guide/multi_proc_support.rst b/doc/guides/prog_guide/multi_proc_support.rst index a84083b96c..1a4a9e2d4d 100644 --- a/doc/guides/prog_guide/multi_proc_support.rst +++ b/doc/guides/prog_guide/multi_proc_support.rst @@ -75,7 +75,7 @@ and point to the same objects, in both processes. The EAL also supports an auto-detection mode (set by EAL ``--proc-type=auto`` flag ), -whereby an DPDK process is started as a secondary instance if a primary instance is already running. +whereby a DPDK process is started as a secondary instance if a primary instance is already running. Deployment Models ----------------- diff --git a/doc/guides/sample_app_ug/l3_forward_power_man.rst b/doc/guides/sample_app_ug/l3_forward_power_man.rst index 6ec24f4ad8..dbdaa743dd 100644 --- a/doc/guides/sample_app_ug/l3_forward_power_man.rst +++ b/doc/guides/sample_app_ug/l3_forward_power_man.rst @@ -49,7 +49,7 @@ to set the CPUFreq governor and set the frequency of specific cores. This application includes a P-state power management algorithm to generate a frequency hint to be sent to CPUFreq. The algorithm uses the number of received and available Rx packets on recent polls to make a heuristic decision to scale frequency up/down. -Specifically, some thresholds are checked to see whether a specific core running an DPDK polling thread needs to increase frequency +Specifically, some thresholds are checked to see whether a specific core running a DPDK polling thread needs to increase frequency a step up based on the near to full trend of polled Rx queues. Also, it decreases frequency a step if packet processed per loop is far less than the expected threshold or the thread's sleeping time exceeds a threshold. -- 2.27.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-30 11:49:30.523523444 +0000 +++ 0004-doc-fix-grammar.patch 2020-11-30 11:49:30.398271670 +0000 @@ -1 +1 @@ -From c053d9e9629b2337093dfd344eb904f0aff703bd Mon Sep 17 00:00:00 2001 +From d91d1aa17e33d647bc582336ada1d3538e395cb9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c053d9e9629b2337093dfd344eb904f0aff703bd ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index 043a1dcee1..994db4b6a0 100644 +index 2f606535c3..2c2f5faec5 100644 @@ -30,2 +31,2 @@ - Running Sample Applications - =========================== + Compiling and Running Sample Applications + ========================================= @@ -38 +39 @@ -@@ -136,7 +136,7 @@ Each bit of the mask corresponds to the equivalent logical core number as report +@@ -185,7 +185,7 @@ Each bit of the mask corresponds to the equivalent logical core number as report @@ -48 +49 @@ -index aab32252ea..a2339a877b 100644 +index b2bda80bb7..ad11bc9e4e 100644 @@ -51 +52 @@ -@@ -114,7 +114,7 @@ In addition, C3 and C6 should be enabled as well for power management. The path +@@ -112,7 +112,7 @@ In addition, C3 and C6 should be enabled as well for power management. The path @@ -61 +62 @@ -index ef8798569a..2d750b4c33 100644 +index e0816f996e..96817e78cd 100644 @@ -64 +65 @@ -@@ -148,7 +148,7 @@ Binding and Unbinding Network Ports to/from the Kernel Modules +@@ -120,7 +120,7 @@ Binding and Unbinding Network Ports to/from the Kernel Modules @@ -74 +75 @@ -index 6ecdc04aa9..dadb23fc89 100644 +index 7c47ec04ce..cf760a6c67 100644 @@ -77 +78 @@ -@@ -97,7 +97,7 @@ e.g. :doc:`../nics/index` +@@ -107,7 +107,7 @@ e.g. :doc:`../nics/index` @@ -87 +88 @@ -index 57fd7425a1..6b0ac30c5b 100644 +index a84083b96c..1a4a9e2d4d 100644 @@ -100 +101 @@ -index 831f2bf58f..85a78a5c1e 100644 +index 6ec24f4ad8..dbdaa743dd 100644