From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69159A04DB for ; Mon, 30 Nov 2020 12:50:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 52A08C966; Mon, 30 Nov 2020 12:50:54 +0100 (CET) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by dpdk.org (Postfix) with ESMTP id CC535C936 for ; Mon, 30 Nov 2020 12:50:52 +0100 (CET) Received: by mail-wr1-f50.google.com with SMTP id t4so15746292wrr.12 for ; Mon, 30 Nov 2020 03:50:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pSTxycIGCNjOxKeta1PiVIMhi1XGYN/JzwSRXTRlptA=; b=ddVJwnoGG1iLTGldMkzpymo7k3SBQeqpVrBXwidkjPsbv4jQwV2L+EoTgpTD9eDR1s mM3AhWBNiCtv3yAHNHrAiiEZ2icXjGIfdYyoghrRKS8m6rvYGzPwk7mAsr02rgYhRxLb 3bidjMTK/ppxtxalFMl3I70+/Y2supaTFG1o+vOSKy5TV3HIAfO7WXchjV8qFsdsKGwA Ny0OQAxS8oeyQhItm0RBYtVmTwFyXFu2m853C9a+QJiId0wPoS3VphL0nCXrweFAS/bE CxZdD1sV/aeE25C7GSXYdXvDjHh0BfMMvUf+pqWtWakx8yilbQtAjQuReagK/NYA0vuv ybXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pSTxycIGCNjOxKeta1PiVIMhi1XGYN/JzwSRXTRlptA=; b=nSuQiH9CtacbjXfAki+v280c9EY0h+t7hfUShBDkHxF1Cienl5WYSWScQzneVOcxbK FIE9C2VdbrrTXhGoWqM/k4GhgWh/zQ4B/HrQkPNsetKd9Uigvfgr6hn7VB440LmndeBj hcFtIrblrJKdCObLT+GP9xjAXBLj/155IVVEkeG40X1QKdyuaTcAmbFEpgNCaERtKSMP NZf1XW451g5W51NgXXqurkXbWsXLt/6Fe3kS7mfkTUSG8u6O+4G9c261oTuL0/IIYXeU 7onPMrNB5WU98zxNaEhAtVMP/0uk9kjcmyswcWDWH5gFfrl/6mQMpvHizRg2cehUfbYz l30A== X-Gm-Message-State: AOAM532TuN3IQbEZKreN9cpA2Yw76HoafEkWtyZNhGU4fheMJ588+UA3 5xNVr18G4hsHJMm5EcCr0q0= X-Google-Smtp-Source: ABdhPJwy1b0LXOtUTyae0dss3rgYBbySmiyz2n2M3ax6R5ZRQcRjbepRjgkdCC0PlhHybBE7HcA81Q== X-Received: by 2002:a5d:4349:: with SMTP id u9mr27140433wrr.319.1606737052597; Mon, 30 Nov 2020 03:50:52 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id r13sm21492798wrm.25.2020.11.30.03.50.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 03:50:51 -0800 (PST) From: luca.boccassi@gmail.com To: Ruifeng Wang Cc: Feifei Wang , Jerin Jacob , dpdk stable Date: Mon, 30 Nov 2020 11:50:27 +0000 Message-Id: <20201130115027.64046-9-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201130115027.64046-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> <20201130115027.64046-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'eal/arm: fix build with gcc optimization level 0' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/3b2bbd4988be1d3531b80bdf3d50fd358e52c1cc Thanks. Luca Boccassi --- >From 3b2bbd4988be1d3531b80bdf3d50fd358e52c1cc Mon Sep 17 00:00:00 2001 From: Ruifeng Wang Date: Fri, 27 Nov 2020 16:09:02 +0800 Subject: [PATCH] eal/arm: fix build with gcc optimization level 0 [ upstream commit d123fd111a161cd4f320ffb551a832cc4ce8c3ab ] GCC build with '-O0' on platforms with RTE_ARM_FEATURE_ATOMICS set failed for: ../lib/librte_efd/rte_efd.c Assembler messages: 3866: Error: selected processor does not support `crc32cb w0,w0,w1' 3890: Error: selected processor does not support `crc32ch w0,w0,w1' 3914: Error: selected processor does not support `crc32cw w0,w0,w1' 3938: Error: selected processor does not support `crc32cx w0,w0,x1' This was caused by an architecture specifier added for Clang. Unlike Clang, GCC considers each inline assembly block to be dependent and therefore, the architecture specifier impacts assemble of some blocks require certain extension support. Removed the architecture for GCC to fix the issue. Fixes: 8fce34cd0a6a ("eal/arm: fix clang build of native target") Reported-by: Feifei Wang Signed-off-by: Ruifeng Wang Acked-by: Jerin Jacob --- lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h index 07d0ce91d8..8da989dcca 100644 --- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h +++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h @@ -47,7 +47,11 @@ extern "C" { /*------------------------ 128 bit atomic operations -------------------------*/ #if defined(__ARM_FEATURE_ATOMICS) || defined(RTE_ARM_FEATURE_ATOMICS) +#if defined(RTE_CC_CLANG) #define __LSE_PREAMBLE ".arch armv8-a+lse\n" +#else +#define __LSE_PREAMBLE "" +#endif #define __ATOMIC128_CAS_OP(cas_op_name, op_string) \ static __rte_noinline rte_int128_t \ -- 2.27.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-30 11:49:30.668991102 +0000 +++ 0009-eal-arm-fix-build-with-gcc-optimization-level-0.patch 2020-11-30 11:49:30.402271747 +0000 @@ -1 +1 @@ -From d123fd111a161cd4f320ffb551a832cc4ce8c3ab Mon Sep 17 00:00:00 2001 +From 3b2bbd4988be1d3531b80bdf3d50fd358e52c1cc Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d123fd111a161cd4f320ffb551a832cc4ce8c3ab ] + @@ -23 +24,0 @@ -Cc: stable@dpdk.org @@ -29 +30 @@ - lib/librte_eal/arm/include/rte_atomic_64.h | 4 ++++ + lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 4 ++++ @@ -32,5 +33,5 @@ -diff --git a/lib/librte_eal/arm/include/rte_atomic_64.h b/lib/librte_eal/arm/include/rte_atomic_64.h -index 7fcd174661..467d32a455 100644 ---- a/lib/librte_eal/arm/include/rte_atomic_64.h -+++ b/lib/librte_eal/arm/include/rte_atomic_64.h -@@ -46,7 +46,11 @@ rte_atomic_thread_fence(int memorder) +diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h +index 07d0ce91d8..8da989dcca 100644 +--- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h ++++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h +@@ -47,7 +47,11 @@ extern "C" {