From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AF16A09E9 for ; Tue, 8 Dec 2020 21:12:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8931AC9CE; Tue, 8 Dec 2020 21:11:54 +0100 (CET) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id EFF53C996 for ; Tue, 8 Dec 2020 21:11:47 +0100 (CET) Received: by mail-pf1-f193.google.com with SMTP id c12so7870266pfo.10 for ; Tue, 08 Dec 2020 12:11:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=j7QUeAxqKh8pgpbrwx2OfftVRlP4lK/H1yKCAKmlPGI=; b=I2khzrJDNqGSgwRFbMRe4U1oy9A3y60L6wPF9H7cD3c07oXFPteEA+4jr3grB5/z5f XHqiq1Zr90xtmd8NO5MVX6kddoo500kNupMt6VV71fbRnKhKg0j1tpL6F6jIYC4CKE+z KkqV8wxXvKcLaCnj4mdd6oWdyI37a1Z4w6H7o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=j7QUeAxqKh8pgpbrwx2OfftVRlP4lK/H1yKCAKmlPGI=; b=PvdB4g7GV5QU1Ak0MYE86Rsc/+G5TQzP7ZIQkrecGF/kirDbHfTbsnkeAc8vGeSQMB 98R4GRa0Jlp6G6SakjpRRZN4saww69ndqEBuNf5vkQUnuTtEJpQsrQpXBmBPuCB4LuST /ixDKqg+brH2ZXvi+v7KI5qjKC15zQ1SaIXVz181LgC8MtRUD2ZQ4nAu1y1x5pzeUvL0 p8CVxMh+TM0WPC/d+uNEw4EIrej+IZwP5hCYnzoHw3KxacIBEkHtCqr9uDQXoIeE6pRe sKMtYYElVuTSf6JMxkYF3ArNybkG9P05FE7oJWpU+zZ52VxakA+8VLXYDLZWwPnXn0yx yojg== X-Gm-Message-State: AOAM5308NqhiIWB13/gQA1U1ZS63NgYyWOZbSe0BuIN77GCbtThP523s /PRyUcLm6jKOEljCxm9jY5SuBavo74J6jT0cEQyzLIVZx+GcdUteLJO7qWBBVZak0Ojw+H07ACw o39Uy2FZ2 X-Google-Smtp-Source: ABdhPJyH+ZpWGK0hPPIkVkSOMMcsuEi5JPy2+UBAEOOl99CMwesKogbcPrhd9qvFPV5/U44y5wDLfg== X-Received: by 2002:a65:5b8e:: with SMTP id i14mr24113042pgr.198.1607458307160; Tue, 08 Dec 2020 12:11:47 -0800 (PST) Received: from localhost.localdomain ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id x10sm5729187pfc.157.2020.12.08.12.11.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Dec 2020 12:11:46 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Kalesh AP , stable@dpdk.org, Somnath Kotur Date: Tue, 8 Dec 2020 12:11:23 -0800 Message-Id: <20201208201134.47844-7-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20201208201134.47844-1-ajit.khaparde@broadcom.com> References: <20201208201134.47844-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-stable] [PATCH 06/17] net/bnxt: fix to return error when fw command fails X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" From: Kalesh AP In bnxt_reta_update_op() and bnxt_rss_hash_update_op(), driver does not propagate the error back to the application when the fw command fails. Fixes: 378ab645bb0b ("net/bnxt: fix RSS RETA indirection table ops") Fixes: fcc0aa1edc10 ("net/bnxt: add RSS hash configuration") Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 8047b0b5d..33358779b 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1843,8 +1843,8 @@ static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev, } } - bnxt_hwrm_vnic_rss_cfg(bp, vnic); - return 0; + rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic); + return rc; } static int bnxt_reta_query_op(struct rte_eth_dev *eth_dev, @@ -1949,8 +1949,8 @@ static int bnxt_rss_hash_update_op(struct rte_eth_dev *eth_dev, memcpy(vnic->rss_hash_key, rss_conf->rss_key, rss_conf->rss_key_len); rss_config: - bnxt_hwrm_vnic_rss_cfg(bp, vnic); - return 0; + rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic); + return rc; } static int bnxt_rss_hash_conf_get_op(struct rte_eth_dev *eth_dev, -- 2.21.1 (Apple Git-122.3) -- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.