From: Thomas Monjalon <thomas@monjalon.net>
To: Richael Zhuang <richael.zhuang@arm.com>
Cc: dev@dpdk.org, stable@dpdk.org, David Hunt <david.hunt@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1 1/1] test/power: fix several bugs in cpufreq autotest
Date: Tue, 06 Apr 2021 10:59:44 +0200 [thread overview]
Message-ID: <2020878.rH1OUNIyh5@thomas> (raw)
In-Reply-To: <20210406083006.45702-1-richael.zhuang@arm.com>
Hi,
When sending a new version, please upgrade the version number.
Would be good to cleanup patchwork as well,
by setting old versions as superseded.
06/04/2021 10:30, Richael Zhuang:
> 1. Sleep for 1s before checking the newly updated value from
> "/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_cur_freq", because
> for some systems it may not be effective immediately.
>
> 2. The value in "/sys/.../cpuinfo_cur_freq" may not be exactly the
> same as what we set. For example, we write "2400000" to
> "/sys/.../cpufreq/scaling_setspeed" to set the frequency, then the
> value in "/sys/.../cpuinfo_cur_freq" may be "2401222". So need to
> round the value.
If there are multiple bugs, they should be adressed in multiple patches.
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
I won't process a confidential patch.
prev parent reply other threads:[~2021-04-06 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 3:33 [dpdk-stable] " Richael Zhuang
2021-04-06 6:39 ` Richael Zhuang
2021-04-06 7:45 ` Richael Zhuang
2021-04-06 8:30 ` Richael Zhuang
2021-04-06 8:59 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2020878.rH1OUNIyh5@thomas \
--to=thomas@monjalon.net \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=richael.zhuang@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).