From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0334DA0A01 for ; Wed, 6 Jan 2021 14:20:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA77F160978; Wed, 6 Jan 2021 14:20:21 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 6396C16096D; Wed, 6 Jan 2021 14:20:19 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 106DArCe019995; Wed, 6 Jan 2021 05:20:18 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0220; bh=SvYTjojk1K5iVM8n5S1FLofzfdkNIjLmJGjx2xUOTTU=; b=KFSo6MOjDk0HUiUoEvAlNaEcOHFtyzwCSkS2PQLstGXky/zXvTIia1wTOIAxmAxFhcm7 XhvC+aI9oK+QGZTM9rXdr/T6PRAz/JbUjrlHrxIeCqzt8dgZOEfV5PKGfNtJ2NoiZdxt eLUzJeGK3PuGWPV0ODngVANPyQE/+7Y3DlRig7cDg1MZ16Sfpac2dLqxgM7S774BnAgi CRC3dbxP6VYmRoZF7fjCKVttDN9rREUwyjkG8pl7zzpO2GyF8l5UTkV5dyJ5ZnvMzSBy hfoM1hnVGa8oUR+AQ+u+QPBs9IWSSCJGe/+83tdjstOyWBfEbLZpXK6V2Ym2rcVJNxwC gg== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com with ESMTP id 35tq2uhnjs-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 06 Jan 2021 05:20:18 -0800 Received: from SC-EXCH04.marvell.com (10.93.176.84) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 Jan 2021 05:20:17 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 Jan 2021 05:20:16 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 6 Jan 2021 05:20:16 -0800 Received: from ahp-smb-share.punelab.qlogic.com (unknown [10.30.45.239]) by maili.marvell.com (Postfix) with ESMTP id 223053F7048; Wed, 6 Jan 2021 05:20:13 -0800 (PST) From: Devendra Singh Rawat To: , , CC: , , , , Devendra Singh Rawat , Date: Wed, 6 Jan 2021 18:50:07 +0530 Message-ID: <20210106132007.197468-1-dsinghrawat@marvell.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20201203133023.4060250-1-dsinghrawat@marvell.com> References: <20201203133023.4060250-1-dsinghrawat@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2021-01-06_06:2021-01-06, 2021-01-06 signatures=0 Subject: [dpdk-stable] [PATCH v2] net/qede: change driver's default load parameter X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Loading ecore clients (PMD or linux kernel driver) having different ecore versions concurrently, is problematic from device's init/config perspective. This fix changes driver's default load parameter to have ecore version validated by MFW. All ecore clients having matching ecore version should be allowed to load, otherwise MFW should fail the load request. Fixes: c5e1108920 ("alter driver's force load behavior") Cc: stable@dpdk.org Signed-off-by: Devendra Singh Rawat Signed-off-by: Manish Chopra Signed-off-by: Igor Russkikh --- doc/guides/nics/qede.rst | 5 ++++- drivers/net/qede/qede_main.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst index bb127ca21..201678401 100644 --- a/doc/guides/nics/qede.rst +++ b/doc/guides/nics/qede.rst @@ -63,11 +63,14 @@ Co-existence considerations - When SR-IOV is enabled on the adapter, Linux kernel drivers (qed, qede, qedr, qedi and qedf) can be bound to the PFs of a given adapter and either qede PMD or Linux drivers - (qed and qede) can be bound to the VFs of the adapter. + (qed and qede) can be bound to the VFs of the adapter provided that + ecore version of Linux kernel driver and qede PMD driver is same. - For sharing an adapter between DPDK and Linux drivers, SRIOV needs to be enabled. Bind all the PFs to Linux Drivers(qed/qede). Create a VF on PFs where DPDK is desired and bind these VFs to qede_pmd. + Make sure that ecore version of Linux Driver and qede PMD driver + is same. Binding of PFs simultaneously to DPDK and Linux drivers on a given adapter is not supported. diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c index caa9d1d4f..d208d276a 100644 --- a/drivers/net/qede/qede_main.c +++ b/drivers/net/qede/qede_main.c @@ -300,7 +300,7 @@ static int qed_slowpath_start(struct ecore_dev *edev, memset(&drv_load_params, 0, sizeof(drv_load_params)); drv_load_params.mfw_timeout_val = ECORE_LOAD_REQ_LOCK_TO_DEFAULT; drv_load_params.avoid_eng_reset = false; - drv_load_params.override_force_load = ECORE_OVERRIDE_FORCE_LOAD_ALWAYS; + drv_load_params.override_force_load = ECORE_OVERRIDE_FORCE_LOAD_NONE; hw_init_params.avoid_eng_affin = false; hw_init_params.p_drv_load_params = &drv_load_params; -- 2.18.2