From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64195A09EF for ; Sun, 10 Jan 2021 09:39:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57C1C140E55; Sun, 10 Jan 2021 09:39:43 +0100 (CET) Received: from m15113.mail.126.com (m15113.mail.126.com [220.181.15.113]) by mails.dpdk.org (Postfix) with ESMTP id CA994140E3D; Sun, 10 Jan 2021 09:39:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=vEase 58VdtyT/BK394giUw9j1I8esydkJ49e9m/dFGQ=; b=oKq3qQmhawxlXS3DbkIPu 2lyptv2DRVYTGB7ch4vYTzTo7WvblQHAldlOI5l250hbKPQ2IYVojeHmEVqSiH3Y /zbtoiFxEibbS5hjnfiiHGlb38tZ7sqtzBTeIiBrDf/HtuV5J9TcH8mERpoc4Y2B hZh53f+xVgz/mfinPsjqC8= Received: from localhost.localdomain (unknown [115.199.180.177]) by smtp3 (Coremail) with SMTP id DcmowABHTOg3vfpfltIQNw--.51239S2; Sun, 10 Jan 2021 16:39:36 +0800 (CST) From: Weifeng Li To: beilei.xing@intel.com, jia.guo@intel.com Cc: dev@dpdk.org, Weifeng Li , stable@dpdk.org Date: Sun, 10 Jan 2021 16:34:17 +0800 Message-Id: <20210110083417.1276-1-liweifeng96@126.com> X-Mailer: git-send-email 2.27.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: DcmowABHTOg3vfpfltIQNw--.51239S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7GryxKw4fWw1kJryDXF17Awb_yoW8Jryxpr 4DGa4Yvry5t3W293y8XFW09rWfWa1fG3y5GFW3Aa4vgwsxtFy7KFy7tas8Ww1DArWSyF4q vFWqq3s7Xay5ZaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRpnQUUUUUU= X-Originating-IP: [115.199.180.177] X-CM-SenderInfo: 5olzvx5ihqwmaw6rjloofrz/1tbipAgW-lpECik0SwAAsG Subject: [dpdk-stable] [PATCH] net/i40e: fix SFP I X722 with FW4.16 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" When NVM API version is 1.7 or above adminq operation to set TPID is set as supported. This cause using adminq instead of registers. For SFP_I_X722 FW4.16, reported NVM API version is 1.8, and this cause adminq operation to set as supported but it is not supported on FW4.16 Additional check added for SFP_I_X722 to not enable adminq operation. Fixes: 9efa8d28b4da ("net/i40e: fix SFP X722 with FW4.16") Cc: stable@dpdk.org Signed-off-by: Weifeng Li --- drivers/net/i40e/i40e_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 1462248..a07879c 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -1550,7 +1550,8 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void *init_params __rte_unused) return -EIO; } /* Firmware of SFP x722 does not support adminq option */ - if (hw->device_id == I40E_DEV_ID_SFP_X722) + if (hw->device_id == I40E_DEV_ID_SFP_X722 || + hw->device_id == I40E_DEV_ID_SFP_I_X722) hw->flags &= ~I40E_HW_FLAG_802_1AD_CAPABLE; PMD_INIT_LOG(INFO, "FW %d.%d API %d.%d NVM %02d.%02d.%02d eetrack %04x", -- 2.9.5