From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84F00A04B5 for ; Tue, 12 Jan 2021 19:19:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74A74140F28; Tue, 12 Jan 2021 19:19:18 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 069A3140F06; Tue, 12 Jan 2021 19:19:15 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 10CIFUkp012101; Tue, 12 Jan 2021 10:19:14 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0220; bh=Nf8y53xec0PT550zXZagZkmQJ+PsYDTD6XCv8+005h4=; b=WWiUTY3XxKIZkjNc+u6K4Ci7hEuuvSry0J1uHwHqrziLvFCV6vKGIz4ZdysLVHYlKMuP P/CMoTRliD1an05TgKbXn8H1RQNRZwYzfjMwjD4itRD5OvBm2jAgTaSkjhjHUykHu6qL G3jvZEx0k6TkKH+uUPi1Wb0IkkP7X3viGAuhwGTt3HJujYGcrrfhJ7VfwnoKFS5sRGAf YZTgNWoT5vxfpzWDhTBaOhrm3cv7pk8kCr5S26uuNppT1BISfVZ3j7xFFuCB7MuyEkMY 8s54KL7XVzv8+0+F8cleaWbZM1wlbBndBVe2rhb2G9k7ns1GnYjztd7eRipKbFAJYYC1 0w== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com with ESMTP id 35yaqss73g-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 12 Jan 2021 10:19:14 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 12 Jan 2021 10:19:13 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 12 Jan 2021 10:19:13 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 12 Jan 2021 10:19:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WgixESsFjff38ALRjqRyBWOOc0z2BJOdUcaIToOLc1DZByDZEV9c9bVpheZ85Owe21dpJZdxuF2kTtO9VU7YLhW1sHtuhc6UpRAPsWtYTPP8MTL/gj/4rqBKcbw31MsGZC7IWKScwIgNcxrvd7arBB09TRfq50LX5yRSIH45BIo/Hv3gig5qd60YyVYQyaM+jiWMf8PWKao2MpWfHFb4oUJfQmAqeVhtZYNr18L+vmHqXAcNb7xIUD8tCwscOwCGBwFfYJugWkt+JHGChFQ0H7HWS1EgKvWJQTF5RF0bYCiVimXxjfoUTu5EYGH5YmuLBFH2FUvBZzVI808qrdc9BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nf8y53xec0PT550zXZagZkmQJ+PsYDTD6XCv8+005h4=; b=SGKpcvEJc8AdL/7ZqgyADvS6PzSN+1SY0D0o9lFHtJ/vPfvuW3VwLsHIpDXnHmzUDg3EvzOrllwhdXrisscHq8noCVq0ivzXEH2VAuzczxb/TkXNcYuKn2fcCCs7u3DUDFe0KoSUlhHxE4w/jGWTdtoWuHrK9uyOCwR+ioj8SJcb9FpHxtdsIR/QtJx3YLYIYcbeavOz1sRYrwlSsIjSdeEzXKh6QGO4qQugBMg7DzMqiA/Yobk27bvttFW163+MC3SmbCPGifuHXNu9x6OiB8FkQJ5pn5n4+kCdPqoz0KkoFvLzqd0Ibngw7cMkBnKmdxG745gfmF/nrs3v5k+BEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nf8y53xec0PT550zXZagZkmQJ+PsYDTD6XCv8+005h4=; b=oyVvbTj7l5vsYOZpQibUETpr2qgp9p12N5FRr9KUdRseRxsZlwnvLBS6yIa0xfmtrcltEqq3ZhJrkpQRht3wkynTfP9GemcRmwbUP6tKrfPuehxXIKLB6vNzuxWt4xbX5SClXe+A954YiIndEpssJscZlM4B6UTHArPUaXxg8o0= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=marvell.com; Received: from CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) by MW2PR18MB2105.namprd18.prod.outlook.com (2603:10b6:907:10::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.9; Tue, 12 Jan 2021 18:19:11 +0000 Received: from CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::444a:e47f:bdc:370c]) by CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::444a:e47f:bdc:370c%7]) with mapi id 15.20.3742.012; Tue, 12 Jan 2021 18:19:11 +0000 Date: Tue, 12 Jan 2021 23:48:43 +0530 From: Harman Kalra To: David Marchand CC: Stephen Hemminger , Ravi Kerur , Thomas Monjalon , dev , dpdk stable Message-ID: <20210112181807.GA27843@outlook.office365.com> References: <20201214190255.16429-1-hkalra@marvell.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [1.6.215.26] X-ClientProxiedBy: MA1PR01CA0144.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:71::14) To CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (1.6.215.26) by MA1PR01CA0144.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:71::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.9 via Frontend Transport; Tue, 12 Jan 2021 18:19:09 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a659b46f-c9fa-49dd-9cdf-08d8b7268f50 X-MS-TrafficTypeDiagnostic: MW2PR18MB2105: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:962; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FcsMcJUI/bKgfmNiPD3bdqCDBRxIFYe4hLlJ+Afj1ARSuMiMg0VY5UHWkrnwN4rQR63mY1YJyA6AcTCSwxh+K9Lu9vPATJo9SIeRZGGY41Au3aqzGtvOay711KoT6RjiTrsCanHckvny2QdL2UwfIVCCe98e5Bp68wnt4JlnT1Vp+tcA9Eji2JHW5gBDli7NsQCWinTQZqyMctK6e5HwOJb0RWIGG+cZqHq2lVh9lpUN9FZpDrc9Gi2EbmTRe7Il2VzJWnbNOtxuQrkXbHuT+GkO5pUGv0L2XlsafRhHdSyu8OzShv+xhsXC2uailPhbmP/NIgvd/eDcjvyHaNw18lnIuaVJmdWoQ3JeIoy4zK13aevosw0ZuZpoLW5CQYMYatiFzp6piT9mw/b1SZEmJKSWbSF/8PSYtuipMosoSe0YT9DJOfMn9ZHfrK9xfMdaGivOG0DysENeFKaK5wtcqA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3842.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(39850400004)(346002)(366004)(376002)(956004)(8676002)(83380400001)(6506007)(53546011)(66476007)(478600001)(6916009)(33656002)(8936002)(26005)(66556008)(86362001)(66946007)(7696005)(16526019)(52116002)(316002)(4326008)(5660300002)(1076003)(186003)(2906002)(6666004)(1006002)(54906003)(55016002)(9686003)(36456004)(42976004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?hxJa0IRwPLLOtHisJpE/C6cmjLT/8K925RWDSo9hhC9pRC463YpflDKCvD93?= =?us-ascii?Q?1j59hM2P2mVVPXS0GENe2KKLiWovu958T8zJELsV93QeIuE/GSiKVZ/UqCWI?= =?us-ascii?Q?fNC9bNYIRyU6z9/cQY0ndUGAfiuhSxDvb8nmwSJTX/zNDL2/PbsK5Sg4erlL?= =?us-ascii?Q?3CckxWSsz6Wbv1iWTuYtAeKUN3SPaVYTSdAb6KBd6j0VpN1cs4qyVO6mId71?= =?us-ascii?Q?qymHloChL1oAKX3cnrxADg6Zf0QxJYN8+pOe9fOYNzaIbVF/d7ohJfbeJm0q?= =?us-ascii?Q?cJ7/9V5csO7a0DcPE3ezM/9jWnK7jdqm19A3yZq+qS72pxM/6T7J7/FYZ4cz?= =?us-ascii?Q?JUWokpqRZTdhWG0i6j/CbtJhsSay5AH09Yg/7xyHssgLiRBcorhGJ6ajTUP0?= =?us-ascii?Q?KLLuLTT273p/nbw/Bdx+Qr6iPTzSyhaD4djzBt3NHr9e2IUZ+WvzQeap5Yzx?= =?us-ascii?Q?xkq1W3GaCzj2QyDS3OUE1bt9T0RSBNac4wMIn3bpJ31DGRC0xhGCb3ePwWmg?= =?us-ascii?Q?ueeqjPMVtF7obymqLYw3ai2Q0FcXVU+65K5cqGyWag5CQERFkr0QaAMmcAxJ?= =?us-ascii?Q?8KMDLDt08OiWOeOFdp7x26VhpPriQqsc4JQSpsOtDka7fajsIOGvljhFDtok?= =?us-ascii?Q?tEK2+Y3oIFVKbk/XrEVT38bq07FhaBlxJYD8VLWe4opg3N1uqCQ++ySMIH+L?= =?us-ascii?Q?yFaXNnPWiGWOFx4g5cVsNjOeahXhhgQ9+12akFG7/DLm8gUFK7PK4cLQU6OA?= =?us-ascii?Q?aj9wN1Xu5sI5+V9w1u/vvNSJ9LZhU0/aTY3ftLuHablFkqqDSyQVW6xaVlQq?= =?us-ascii?Q?hAjoX67z6HvJOJhib8V5gcZ5i9Bge5yaF35qg+APdYZtw3XMiNSyIOR5zZV2?= =?us-ascii?Q?kfnapvTI8mB75QFbjyuVYe2wAUHV++9KY+s4tV9Vk5hU9+fPjfQb84xmE+BC?= =?us-ascii?Q?UBroexTyWSj1pvKns8NvC8QRkD8ao4h5CHfrSRaHzXE=3D?= X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3842.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2021 18:19:11.2606 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-Network-Message-Id: a659b46f-c9fa-49dd-9cdf-08d8b7268f50 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kaolTxbBodU/VReNTVC6Pc9QzJA/qD1cXSXhx1Vgrf6UUv9KRCRB9hagpdJptbWljejgMpuHK3sccYj9nHG5ag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2105 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2021-01-12_15:2021-01-12, 2021-01-12 signatures=0 Subject: Re: [dpdk-stable] [EXT] Re: [PATCH] examples/l3fwd: fix max Tx queue count X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Jan 12, 2021 at 09:58:06AM +0100, David Marchand wrote: > External Email > > ---------------------------------------------------------------------- > On Mon, Dec 14, 2020 at 8:03 PM Harman Kalra wrote: > > > > In l3fwd no of transmit queues is calculated based on no of > > lcores with which it is launched. Hence maximum no of tx > > queues possible per port should depend on RTE_MAX_LCORE value. > > For the title, we are not "fixing" the Tx queue count. > WDYT of: > examples/l3fwd: remove limitation on Tx queue count Hi David Thanks for reviewing, I will push V2 with the required changes. > > > > > Fixes: 268888b5b020 ("examples/l3fwd: modularize") > > This commit simply moves code around, so it is unlikely to be the origin. > Afaiu, this behavior has been present since the start. > I'd rather flag > > Fixes: af75078fece3 ("first public release") > > > Cc: stable@dpdk.org > > > > Signed-off-by: Harman Kalra > > --- > > examples/l3fwd/main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > > index d62dec434..bb49e5faf 100644 > > --- a/examples/l3fwd/main.c > > +++ b/examples/l3fwd/main.c > > @@ -48,7 +48,7 @@ > > #include "l3fwd.h" > > #include "l3fwd_event.h" > > > > -#define MAX_TX_QUEUE_PER_PORT RTE_MAX_ETHPORTS > > +#define MAX_TX_QUEUE_PER_PORT RTE_MAX_LCORE > > #define MAX_RX_QUEUE_PER_PORT 128 > > > > #define MAX_LCORE_PARAMS 1024 > > Later in the code, the associated check on nb_lcores > RTE_MAX_LCORE > does not make much sense. > But keeping this MAX_TX_QUEUE_PER_PORT macro is a way to document how > the txq are allocated. > So this change lgtm. > > Reviewed-by: David Marchand > > > -- > David Marchand >