* [dpdk-stable] [PATCH 1/4] test/cryptodev: fix latency test csv output [not found] <20201211173114.1924772-1-ciara.power@intel.com> @ 2020-12-11 17:31 ` Ciara Power [not found] ` <20210114104125.2890107-1-ciara.power@intel.com> [not found] ` <20210120172931.3135778-1-ciara.power@intel.com> 2 siblings, 0 replies; 7+ messages in thread From: Ciara Power @ 2020-12-11 17:31 UTC (permalink / raw) To: dev Cc: declan.doherty, akhil.goyal, Ciara Power, pablo.de.lara.guarch, stable The csv output for the latency performance test had an extra header, "Packet Size", which is a duplicate of "Buffer Size", and had no corresponding value in the output. This is now removed. Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") Cc: pablo.de.lara.guarch@intel.com Cc: stable@dpdk.org Signed-off-by: Ciara Power <ciara.power@intel.com> --- app/test-crypto-perf/cperf_test_latency.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-crypto-perf/cperf_test_latency.c b/app/test-crypto-perf/cperf_test_latency.c index 0e4d0e1538..c2590a4dcf 100644 --- a/app/test-crypto-perf/cperf_test_latency.c +++ b/app/test-crypto-perf/cperf_test_latency.c @@ -310,7 +310,7 @@ cperf_latency_test_runner(void *arg) if (ctx->options->csv) { if (rte_atomic16_test_and_set(&display_once)) printf("\n# lcore, Buffer Size, Burst Size, Pakt Seq #, " - "Packet Size, cycles, time (us)"); + "cycles, time (us)"); for (i = 0; i < ctx->options->total_ops; i++) { -- 2.25.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20210114104125.2890107-1-ciara.power@intel.com>]
* [dpdk-stable] [PATCH v2 1/4] test/cryptodev: fix latency test csv output [not found] ` <20210114104125.2890107-1-ciara.power@intel.com> @ 2021-01-14 10:41 ` Ciara Power 2021-01-15 9:42 ` Dybkowski, AdamX 2021-01-14 10:41 ` [dpdk-stable] [PATCH v2 2/4] test/cryptodev: fix csv output format Ciara Power 1 sibling, 1 reply; 7+ messages in thread From: Ciara Power @ 2021-01-14 10:41 UTC (permalink / raw) To: dev Cc: declan.doherty, akhil.goyal, stephen, adamx.dybkowski, Ciara Power, pablo.de.lara.guarch, stable The csv output for the latency performance test had an extra header, "Packet Size", which is a duplicate of "Buffer Size", and had no corresponding value in the output. This is now removed. Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") Cc: pablo.de.lara.guarch@intel.com Cc: stable@dpdk.org Signed-off-by: Ciara Power <ciara.power@intel.com> --- app/test-crypto-perf/cperf_test_latency.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-crypto-perf/cperf_test_latency.c b/app/test-crypto-perf/cperf_test_latency.c index 0e4d0e1538..c2590a4dcf 100644 --- a/app/test-crypto-perf/cperf_test_latency.c +++ b/app/test-crypto-perf/cperf_test_latency.c @@ -310,7 +310,7 @@ cperf_latency_test_runner(void *arg) if (ctx->options->csv) { if (rte_atomic16_test_and_set(&display_once)) printf("\n# lcore, Buffer Size, Burst Size, Pakt Seq #, " - "Packet Size, cycles, time (us)"); + "cycles, time (us)"); for (i = 0; i < ctx->options->total_ops; i++) { -- 2.25.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [PATCH v2 1/4] test/cryptodev: fix latency test csv output 2021-01-14 10:41 ` [dpdk-stable] [PATCH v2 " Ciara Power @ 2021-01-15 9:42 ` Dybkowski, AdamX 0 siblings, 0 replies; 7+ messages in thread From: Dybkowski, AdamX @ 2021-01-15 9:42 UTC (permalink / raw) To: Power, Ciara, dev Cc: Doherty, Declan, akhil.goyal, stephen, De Lara Guarch, Pablo, stable > -----Original Message----- > From: Power, Ciara <ciara.power@intel.com> > Sent: Thursday, 14 January, 2021 11:41 > To: dev@dpdk.org > Cc: Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com; > stephen@networkplumber.org; Dybkowski, AdamX > <adamx.dybkowski@intel.com>; Power, Ciara <ciara.power@intel.com>; De > Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; stable@dpdk.org > Subject: [PATCH v2 1/4] test/cryptodev: fix latency test csv output > > The csv output for the latency performance test had an extra header, "Packet > Size", which is a duplicate of "Buffer Size", and had no corresponding value in > the output. This is now removed. > > Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") > Cc: pablo.de.lara.guarch@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Ciara Power <ciara.power@intel.com> Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-stable] [PATCH v2 2/4] test/cryptodev: fix csv output format [not found] ` <20210114104125.2890107-1-ciara.power@intel.com> 2021-01-14 10:41 ` [dpdk-stable] [PATCH v2 " Ciara Power @ 2021-01-14 10:41 ` Ciara Power 2021-01-15 9:42 ` Dybkowski, AdamX 1 sibling, 1 reply; 7+ messages in thread From: Ciara Power @ 2021-01-14 10:41 UTC (permalink / raw) To: dev Cc: declan.doherty, akhil.goyal, stephen, adamx.dybkowski, Ciara Power, anatoly.burakov, pablo.de.lara.guarch, stable The csv output for each ptest type used ";" instead of ",". This has now been fixed to use the comma format that is used in the csv headers. Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") Fixes: 96dfeb609be1 ("app/crypto-perf: add new PMD benchmarking mode") Fixes: da40ebd6d383 ("app/crypto-perf: display results in test runner") Cc: anatoly.burakov@intel.com Cc: pablo.de.lara.guarch@intel.com Cc: stable@dpdk.org Signed-off-by: Ciara Power <ciara.power@intel.com> --- v2: - Reduced changes to only fix csv format. --- app/test-crypto-perf/cperf_test_latency.c | 2 +- app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 2 +- app/test-crypto-perf/cperf_test_throughput.c | 4 ++-- app/test-crypto-perf/cperf_test_verify.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/test-crypto-perf/cperf_test_latency.c b/app/test-crypto-perf/cperf_test_latency.c index c2590a4dcf..159fe8492b 100644 --- a/app/test-crypto-perf/cperf_test_latency.c +++ b/app/test-crypto-perf/cperf_test_latency.c @@ -314,7 +314,7 @@ cperf_latency_test_runner(void *arg) for (i = 0; i < ctx->options->total_ops; i++) { - printf("\n%u;%u;%u;%"PRIu64";%"PRIu64";%.3f", + printf("\n%u,%u,%u,%"PRIu64",%"PRIu64",%.3f", ctx->lcore_id, ctx->options->test_buffer_size, test_burst_size, i + 1, ctx->res[i].tsc_end - ctx->res[i].tsc_start, diff --git a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c index 4e67d3aebd..844659aeca 100644 --- a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c +++ b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c @@ -16,7 +16,7 @@ #define PRETTY_HDR_FMT "%12s%12s%12s%12s%12s%12s%12s%12s%12s%12s\n\n" #define PRETTY_LINE_FMT "%12u%12u%12u%12u%12u%12u%12u%12.0f%12.0f%12.0f\n" #define CSV_HDR_FMT "%s,%s,%s,%s,%s,%s,%s,%s,%s,%s\n" -#define CSV_LINE_FMT "%10u;%10u;%u;%u;%u;%u;%u;%.3f;%.3f;%.3f\n" +#define CSV_LINE_FMT "%10u,%10u,%u,%u,%u,%u,%u,%.3f,%.3f,%.3f\n" struct cperf_pmd_cyclecount_ctx { uint8_t dev_id; diff --git a/app/test-crypto-perf/cperf_test_throughput.c b/app/test-crypto-perf/cperf_test_throughput.c index f30f7d5c2c..f6eb8cf259 100644 --- a/app/test-crypto-perf/cperf_test_throughput.c +++ b/app/test-crypto-perf/cperf_test_throughput.c @@ -299,8 +299,8 @@ cperf_throughput_test_runner(void *test_ctx) "Failed Deq,Ops(Millions),Throughput(Gbps)," "Cycles/Buf\n\n"); - printf("%u;%u;%u;%"PRIu64";%"PRIu64";%"PRIu64";%"PRIu64";" - "%.3f;%.3f;%.3f\n", + printf("%u,%u,%u,%"PRIu64",%"PRIu64",%"PRIu64",%"PRIu64"," + "%.3f,%.3f,%.3f\n", ctx->lcore_id, ctx->options->test_buffer_size, test_burst_size, diff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c index 833bc9a552..2939aeaa93 100644 --- a/app/test-crypto-perf/cperf_test_verify.c +++ b/app/test-crypto-perf/cperf_test_verify.c @@ -406,7 +406,7 @@ cperf_verify_test_runner(void *test_ctx) "Burst Size,Enqueued,Dequeued,Failed Enq," "Failed Deq,Failed Ops\n"); - printf("%10u;%10u;%u;%"PRIu64";%"PRIu64";%"PRIu64";%"PRIu64";" + printf("%10u,%10u,%u,%"PRIu64",%"PRIu64",%"PRIu64",%"PRIu64"," "%"PRIu64"\n", ctx->lcore_id, ctx->options->max_buffer_size, -- 2.25.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [PATCH v2 2/4] test/cryptodev: fix csv output format 2021-01-14 10:41 ` [dpdk-stable] [PATCH v2 2/4] test/cryptodev: fix csv output format Ciara Power @ 2021-01-15 9:42 ` Dybkowski, AdamX 0 siblings, 0 replies; 7+ messages in thread From: Dybkowski, AdamX @ 2021-01-15 9:42 UTC (permalink / raw) To: Power, Ciara, dev Cc: Doherty, Declan, akhil.goyal, stephen, Burakov, Anatoly, De Lara Guarch, Pablo, stable > -----Original Message----- > From: Power, Ciara <ciara.power@intel.com> > Sent: Thursday, 14 January, 2021 11:41 > To: dev@dpdk.org > Cc: Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com; > stephen@networkplumber.org; Dybkowski, AdamX > <adamx.dybkowski@intel.com>; Power, Ciara <ciara.power@intel.com>; > Burakov, Anatoly <anatoly.burakov@intel.com>; De Lara Guarch, Pablo > <pablo.de.lara.guarch@intel.com>; stable@dpdk.org > Subject: [PATCH v2 2/4] test/cryptodev: fix csv output format > > The csv output for each ptest type used ";" instead of ",". > This has now been fixed to use the comma format that is used in the csv > headers. > > Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") > Fixes: 96dfeb609be1 ("app/crypto-perf: add new PMD benchmarking mode") > Fixes: da40ebd6d383 ("app/crypto-perf: display results in test runner") > Cc: anatoly.burakov@intel.com > Cc: pablo.de.lara.guarch@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Ciara Power <ciara.power@intel.com> Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20210120172931.3135778-1-ciara.power@intel.com>]
* [dpdk-stable] [PATCH v3 1/4] test/cryptodev: fix latency test csv output [not found] ` <20210120172931.3135778-1-ciara.power@intel.com> @ 2021-01-20 17:29 ` Ciara Power 2021-01-20 17:29 ` [dpdk-stable] [PATCH v3 2/4] test/cryptodev: fix csv output format Ciara Power 1 sibling, 0 replies; 7+ messages in thread From: Ciara Power @ 2021-01-20 17:29 UTC (permalink / raw) To: dev Cc: declan.doherty, akhil.goyal, stephen, adamx.dybkowski, thomas, Ciara Power, pablo.de.lara.guarch, stable The csv output for the latency performance test had an extra header, "Packet Size", which is a duplicate of "Buffer Size", and had no corresponding value in the output. This is now removed. Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") Cc: pablo.de.lara.guarch@intel.com Cc: stable@dpdk.org Signed-off-by: Ciara Power <ciara.power@intel.com> Acked-by: Declan Doherty <declan.doherty@intel.com> Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com> --- app/test-crypto-perf/cperf_test_latency.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-crypto-perf/cperf_test_latency.c b/app/test-crypto-perf/cperf_test_latency.c index 0e4d0e1538..c2590a4dcf 100644 --- a/app/test-crypto-perf/cperf_test_latency.c +++ b/app/test-crypto-perf/cperf_test_latency.c @@ -310,7 +310,7 @@ cperf_latency_test_runner(void *arg) if (ctx->options->csv) { if (rte_atomic16_test_and_set(&display_once)) printf("\n# lcore, Buffer Size, Burst Size, Pakt Seq #, " - "Packet Size, cycles, time (us)"); + "cycles, time (us)"); for (i = 0; i < ctx->options->total_ops; i++) { -- 2.25.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-stable] [PATCH v3 2/4] test/cryptodev: fix csv output format [not found] ` <20210120172931.3135778-1-ciara.power@intel.com> 2021-01-20 17:29 ` [dpdk-stable] [PATCH v3 1/4] test/cryptodev: fix latency test csv output Ciara Power @ 2021-01-20 17:29 ` Ciara Power 1 sibling, 0 replies; 7+ messages in thread From: Ciara Power @ 2021-01-20 17:29 UTC (permalink / raw) To: dev Cc: declan.doherty, akhil.goyal, stephen, adamx.dybkowski, thomas, Ciara Power, anatoly.burakov, pablo.de.lara.guarch, stable The csv output for each ptest type used ";" instead of ",". This has now been fixed to use the comma format that is used in the csv headers. Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") Fixes: 96dfeb609be1 ("app/crypto-perf: add new PMD benchmarking mode") Fixes: da40ebd6d383 ("app/crypto-perf: display results in test runner") Cc: anatoly.burakov@intel.com Cc: pablo.de.lara.guarch@intel.com Cc: stable@dpdk.org Signed-off-by: Ciara Power <ciara.power@intel.com> Acked-by: Declan Doherty <declan.doherty@intel.com> Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com> --- v2: - Reduced changes to only fix csv format. --- app/test-crypto-perf/cperf_test_latency.c | 2 +- app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 2 +- app/test-crypto-perf/cperf_test_throughput.c | 4 ++-- app/test-crypto-perf/cperf_test_verify.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/test-crypto-perf/cperf_test_latency.c b/app/test-crypto-perf/cperf_test_latency.c index c2590a4dcf..159fe8492b 100644 --- a/app/test-crypto-perf/cperf_test_latency.c +++ b/app/test-crypto-perf/cperf_test_latency.c @@ -314,7 +314,7 @@ cperf_latency_test_runner(void *arg) for (i = 0; i < ctx->options->total_ops; i++) { - printf("\n%u;%u;%u;%"PRIu64";%"PRIu64";%.3f", + printf("\n%u,%u,%u,%"PRIu64",%"PRIu64",%.3f", ctx->lcore_id, ctx->options->test_buffer_size, test_burst_size, i + 1, ctx->res[i].tsc_end - ctx->res[i].tsc_start, diff --git a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c index 4e67d3aebd..844659aeca 100644 --- a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c +++ b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c @@ -16,7 +16,7 @@ #define PRETTY_HDR_FMT "%12s%12s%12s%12s%12s%12s%12s%12s%12s%12s\n\n" #define PRETTY_LINE_FMT "%12u%12u%12u%12u%12u%12u%12u%12.0f%12.0f%12.0f\n" #define CSV_HDR_FMT "%s,%s,%s,%s,%s,%s,%s,%s,%s,%s\n" -#define CSV_LINE_FMT "%10u;%10u;%u;%u;%u;%u;%u;%.3f;%.3f;%.3f\n" +#define CSV_LINE_FMT "%10u,%10u,%u,%u,%u,%u,%u,%.3f,%.3f,%.3f\n" struct cperf_pmd_cyclecount_ctx { uint8_t dev_id; diff --git a/app/test-crypto-perf/cperf_test_throughput.c b/app/test-crypto-perf/cperf_test_throughput.c index f30f7d5c2c..f6eb8cf259 100644 --- a/app/test-crypto-perf/cperf_test_throughput.c +++ b/app/test-crypto-perf/cperf_test_throughput.c @@ -299,8 +299,8 @@ cperf_throughput_test_runner(void *test_ctx) "Failed Deq,Ops(Millions),Throughput(Gbps)," "Cycles/Buf\n\n"); - printf("%u;%u;%u;%"PRIu64";%"PRIu64";%"PRIu64";%"PRIu64";" - "%.3f;%.3f;%.3f\n", + printf("%u,%u,%u,%"PRIu64",%"PRIu64",%"PRIu64",%"PRIu64"," + "%.3f,%.3f,%.3f\n", ctx->lcore_id, ctx->options->test_buffer_size, test_burst_size, diff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c index 833bc9a552..2939aeaa93 100644 --- a/app/test-crypto-perf/cperf_test_verify.c +++ b/app/test-crypto-perf/cperf_test_verify.c @@ -406,7 +406,7 @@ cperf_verify_test_runner(void *test_ctx) "Burst Size,Enqueued,Dequeued,Failed Enq," "Failed Deq,Failed Ops\n"); - printf("%10u;%10u;%u;%"PRIu64";%"PRIu64";%"PRIu64";%"PRIu64";" + printf("%10u,%10u,%u,%"PRIu64",%"PRIu64",%"PRIu64",%"PRIu64"," "%"PRIu64"\n", ctx->lcore_id, ctx->options->max_buffer_size, -- 2.25.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-01-20 17:30 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20201211173114.1924772-1-ciara.power@intel.com> 2020-12-11 17:31 ` [dpdk-stable] [PATCH 1/4] test/cryptodev: fix latency test csv output Ciara Power [not found] ` <20210114104125.2890107-1-ciara.power@intel.com> 2021-01-14 10:41 ` [dpdk-stable] [PATCH v2 " Ciara Power 2021-01-15 9:42 ` Dybkowski, AdamX 2021-01-14 10:41 ` [dpdk-stable] [PATCH v2 2/4] test/cryptodev: fix csv output format Ciara Power 2021-01-15 9:42 ` Dybkowski, AdamX [not found] ` <20210120172931.3135778-1-ciara.power@intel.com> 2021-01-20 17:29 ` [dpdk-stable] [PATCH v3 1/4] test/cryptodev: fix latency test csv output Ciara Power 2021-01-20 17:29 ` [dpdk-stable] [PATCH v3 2/4] test/cryptodev: fix csv output format Ciara Power
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).