From: Bruce Richardson <bruce.richardson@intel.com>
To: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com, stable@dpdk.org,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [dpdk-stable] [PATCH v2 09/19] ipsec: fix missing header include
Date: Fri, 15 Jan 2021 11:49:10 +0000
Message-ID: <20210115114910.GA1487@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <5b7fd1d6-eee6-e468-65fd-5f9163614b57@intel.com>
On Fri, Jan 15, 2021 at 11:45:11AM +0000, Medvedkin, Vladimir wrote:
> Hi Bruce,
>
> Just a one nit, please put <stdint.h> before rte_ includes.
>
Good point, I'll fix if I do a V3.
> On 15/01/2021 11:37, Medvedkin, Vladimir wrote:
> >
> >
> > On 15/01/2021 11:10, Bruce Richardson wrote:
> > > The rte_ipsec_sad.h header used the standard uintXX_t types, but did not
> > > include stdint.h header for them.
> > >
> > > Fixes: 401633d9c112 ("ipsec: add inbound SAD API")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > ---
> > > lib/librte_ipsec/rte_ipsec_sad.h | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/lib/librte_ipsec/rte_ipsec_sad.h
> > > b/lib/librte_ipsec/rte_ipsec_sad.h
> > > index 3e67ab1e4b..66c703ff3a 100644
> > > --- a/lib/librte_ipsec/rte_ipsec_sad.h
> > > +++ b/lib/librte_ipsec/rte_ipsec_sad.h
> > > @@ -7,6 +7,7 @@
> > > #define _RTE_IPSEC_SAD_H_
> > > #include <rte_compat.h>
> > > +#include <stdint.h>
> > > /**
> > > * @file rte_ipsec_sad.h
> > >
> >
> > Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> >
>
> --
> Regards,
> Vladimir
next prev parent reply other threads:[~2021-01-15 11:49 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210114110606.21142-1-bruce.richardson@intel.com>
2021-01-14 11:05 ` [dpdk-stable] [PATCH 01/20] eal: fix missing header inclusion Bruce Richardson
2021-01-14 11:05 ` [dpdk-stable] [PATCH 02/20] telemetry: fix missing header include Bruce Richardson
2021-01-14 11:05 ` [dpdk-stable] [PATCH 03/20] ethdev: " Bruce Richardson
2021-01-14 11:05 ` [dpdk-stable] [PATCH 04/20] ring: fix missing includes for c11 model header Bruce Richardson
2021-01-14 12:57 ` [dpdk-stable] [dpdk-dev] " David Marchand
2021-01-14 13:54 ` Ananyev, Konstantin
2021-01-14 11:05 ` [dpdk-stable] [PATCH 05/20] net: fix missing header include Bruce Richardson
2021-01-14 11:05 ` [dpdk-stable] [PATCH 06/20] mbuf: " Bruce Richardson
2021-01-14 11:05 ` [dpdk-stable] [PATCH 07/20] bitratestats: " Bruce Richardson
2021-01-14 11:05 ` [dpdk-stable] [PATCH 08/20] rib: fix missing header includes Bruce Richardson
2021-01-14 11:05 ` [dpdk-stable] [PATCH 09/20] vhost: " Bruce Richardson
2021-01-14 11:05 ` [dpdk-stable] [PATCH 10/20] ipsec: fix missing header include Bruce Richardson
2021-01-14 11:05 ` [dpdk-stable] [PATCH 11/20] fib: fix missing header includes Bruce Richardson
2021-01-14 11:05 ` [dpdk-stable] [PATCH 12/20] table: fix missing header include Bruce Richardson
2021-01-14 11:05 ` [dpdk-stable] [PATCH 13/20] pipeline: fix missing header includes Bruce Richardson
2021-01-14 11:06 ` [dpdk-stable] [PATCH 14/20] metrics: fix variable declaration in header Bruce Richardson
2021-01-14 11:06 ` [dpdk-stable] [PATCH 15/20] node: fix missing header include Bruce Richardson
2021-01-14 11:06 ` [dpdk-stable] [PATCH 16/20] app: fix extra include paths for app builds Bruce Richardson
2021-01-14 11:06 ` [dpdk-stable] [PATCH 18/20] eal: add missing include to mcslock Bruce Richardson
[not found] ` <20210115111052.16437-1-bruce.richardson@intel.com>
2021-01-15 11:10 ` [dpdk-stable] [PATCH v2 01/19] eal: fix missing header inclusion Bruce Richardson
2021-01-15 11:10 ` [dpdk-stable] [PATCH v2 02/19] telemetry: fix missing header include Bruce Richardson
2021-01-15 11:10 ` [dpdk-stable] [PATCH v2 03/19] ethdev: " Bruce Richardson
2021-01-15 15:38 ` Andrew Rybchenko
2021-01-15 11:10 ` [dpdk-stable] [PATCH v2 04/19] net: " Bruce Richardson
2021-01-16 12:10 ` Ophir Munk
2021-01-15 11:10 ` [dpdk-stable] [PATCH v2 05/19] mbuf: " Bruce Richardson
2021-01-15 15:40 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2021-01-15 11:10 ` [dpdk-stable] [PATCH v2 06/19] bitratestats: " Bruce Richardson
2021-01-15 11:10 ` [dpdk-stable] [PATCH v2 07/19] rib: fix missing header includes Bruce Richardson
2021-01-15 11:37 ` Medvedkin, Vladimir
2021-01-15 11:10 ` [dpdk-stable] [PATCH v2 08/19] vhost: " Bruce Richardson
2021-01-21 8:38 ` Maxime Coquelin
2021-01-15 11:10 ` [dpdk-stable] [PATCH v2 09/19] ipsec: fix missing header include Bruce Richardson
2021-01-15 11:35 ` Ananyev, Konstantin
2021-01-15 11:37 ` Medvedkin, Vladimir
2021-01-15 11:45 ` Medvedkin, Vladimir
2021-01-15 11:49 ` Bruce Richardson [this message]
2021-01-15 11:10 ` [dpdk-stable] [PATCH v2 10/19] fib: fix missing header includes Bruce Richardson
2021-01-15 11:37 ` Medvedkin, Vladimir
2021-01-15 11:10 ` [dpdk-stable] [PATCH v2 11/19] table: fix missing header include Bruce Richardson
2021-01-15 11:10 ` [dpdk-stable] [PATCH v2 12/19] pipeline: fix missing header includes Bruce Richardson
2021-01-15 11:10 ` [dpdk-stable] [PATCH v2 13/19] metrics: fix variable declaration in header Bruce Richardson
2021-01-15 11:10 ` [dpdk-stable] [PATCH v2 14/19] node: fix missing header include Bruce Richardson
2021-01-15 11:10 ` [dpdk-stable] [PATCH v2 15/19] app: fix extra include paths for app builds Bruce Richardson
2021-01-15 11:10 ` [dpdk-stable] [PATCH v2 17/19] eal: add missing include to mcslock Bruce Richardson
2021-01-15 13:25 ` Honnappa Nagarahalli
[not found] ` <20210125141115.573122-1-bruce.richardson@intel.com>
2021-01-25 14:11 ` [dpdk-stable] [PATCH v3 1/4] " Bruce Richardson
[not found] ` <20210126141857.1029916-1-bruce.richardson@intel.com>
2021-01-26 14:18 ` [dpdk-stable] [PATCH v4 1/7] " Bruce Richardson
[not found] ` <20210126213809.1479893-1-bruce.richardson@intel.com>
2021-01-26 21:38 ` [dpdk-stable] [PATCH v5 1/8] " Bruce Richardson
[not found] ` <20210127173330.1671341-1-bruce.richardson@intel.com>
2021-01-27 17:33 ` [dpdk-stable] [PATCH v6 " Bruce Richardson
[not found] ` <20210129164823.3205861-1-bruce.richardson@intel.com>
2021-01-29 16:48 ` [dpdk-stable] [PATCH v7 01/10] " Bruce Richardson
2021-01-29 16:48 ` [dpdk-stable] [PATCH v7 02/10] eal: fix error attribute use for clang Bruce Richardson
2021-01-29 16:48 ` [dpdk-stable] [PATCH v7 04/10] rib: fix missing header include Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115114910.GA1487@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
patches for DPDK stable branches
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
stable@dpdk.org
public-inbox-index stable
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://inbox.dpdk.org/inbox.dpdk.stable
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git