* [dpdk-stable] [PATCH v2 03/44] net/virtio: fix getting old status on reconnect [not found] <20210119212507.1043636-1-maxime.coquelin@redhat.com> @ 2021-01-19 21:24 ` Maxime Coquelin 2021-01-21 7:12 ` Xia, Chenbo 0 siblings, 1 reply; 2+ messages in thread From: Maxime Coquelin @ 2021-01-19 21:24 UTC (permalink / raw) To: dev, chenbo.xia, olivier.matz, amorenoz, david.marchand Cc: Maxime Coquelin, stable This patch fixes getting reset status from the restarted vhost-user backend in case of reconnection, instead of the status at the time of the disconnection. This issue was not spotted earlier because Vhost-user protocol status feature was disabled in server mode. Fixes: 47235f16505f ("net/virtio-user: set status on socket reconnect") Cc: stable@dpdk.org Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> --- drivers/net/virtio/virtio_user_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index 241808cd8f..7abba1f1ee 100644 --- a/drivers/net/virtio/virtio_user_ethdev.c +++ b/drivers/net/virtio/virtio_user_ethdev.c @@ -77,7 +77,7 @@ virtio_user_server_reconnect(struct virtio_user_dev *dev) return -1; dev->vhostfd = connectfd; - old_status = vtpci_get_status(hw); + old_status = dev->status; vtpci_reset(hw); -- 2.29.2 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH v2 03/44] net/virtio: fix getting old status on reconnect 2021-01-19 21:24 ` [dpdk-stable] [PATCH v2 03/44] net/virtio: fix getting old status on reconnect Maxime Coquelin @ 2021-01-21 7:12 ` Xia, Chenbo 0 siblings, 0 replies; 2+ messages in thread From: Xia, Chenbo @ 2021-01-21 7:12 UTC (permalink / raw) To: Maxime Coquelin, dev, olivier.matz, amorenoz, david.marchand; +Cc: stable > -----Original Message----- > From: Maxime Coquelin <maxime.coquelin@redhat.com> > Sent: Wednesday, January 20, 2021 5:24 AM > To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; olivier.matz@6wind.com; > amorenoz@redhat.com; david.marchand@redhat.com > Cc: Maxime Coquelin <maxime.coquelin@redhat.com>; stable@dpdk.org > Subject: [PATCH v2 03/44] net/virtio: fix getting old status on reconnect > > This patch fixes getting reset status from the restarted > vhost-user backend in case of reconnection, instead of the > status at the time of the disconnection. > > This issue was not spotted earlier because Vhost-user > protocol status feature was disabled in server mode. > > Fixes: 47235f16505f ("net/virtio-user: set status on socket reconnect") > Cc: stable@dpdk.org > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > --- > drivers/net/virtio/virtio_user_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_user_ethdev.c > b/drivers/net/virtio/virtio_user_ethdev.c > index 241808cd8f..7abba1f1ee 100644 > --- a/drivers/net/virtio/virtio_user_ethdev.c > +++ b/drivers/net/virtio/virtio_user_ethdev.c > @@ -77,7 +77,7 @@ virtio_user_server_reconnect(struct virtio_user_dev *dev) > return -1; > > dev->vhostfd = connectfd; > - old_status = vtpci_get_status(hw); > + old_status = dev->status; > > vtpci_reset(hw); > > -- > 2.29.2 Reviewed-by: Chenbo Xia <chenbo.xia@intel.com> ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-21 7:12 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20210119212507.1043636-1-maxime.coquelin@redhat.com> 2021-01-19 21:24 ` [dpdk-stable] [PATCH v2 03/44] net/virtio: fix getting old status on reconnect Maxime Coquelin 2021-01-21 7:12 ` Xia, Chenbo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).