From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4C1BA0524 for ; Thu, 4 Feb 2021 12:38:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DF722407A2; Thu, 4 Feb 2021 12:38:11 +0100 (CET) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 07C10240757 for ; Thu, 4 Feb 2021 12:38:10 +0100 (CET) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l7cxd-0005j7-AU; Thu, 04 Feb 2021 11:38:09 +0000 From: Christian Ehrhardt To: Ido Segev Cc: Michal Krawczyk , Igor Chauskin , dpdk stable Date: Thu, 4 Feb 2021 12:29:35 +0100 Message-Id: <20210204112954.2488123-120-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210204112954.2488123-1-christian.ehrhardt@canonical.com> References: <20210204112954.2488123-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/ena: flush Rx buffers memory pool cache' has been queued to stable release 19.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/06/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/5d475f9e0128151bf9614a46434b4c0784fd8859 Thanks. Christian Ehrhardt --- >From 5d475f9e0128151bf9614a46434b4c0784fd8859 Mon Sep 17 00:00:00 2001 From: Ido Segev Date: Tue, 26 Jan 2021 19:32:22 +0100 Subject: [PATCH] net/ena: flush Rx buffers memory pool cache [ upstream commit 4387e81c94f4702ec2eb2037df2bfa19927309d7 ] As the refill called as part of ena_start(), we end up the refill progress with stuck buffers at the caller core cache. Calling to flush the cache results with invalidate this cache and free those stuck buffers. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Signed-off-by: Ido Segev Reviewed-by: Michal Krawczyk Reviewed-by: Igor Chauskin --- drivers/net/ena/ena_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 2c19f6459f..d098387a8c 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1182,6 +1182,10 @@ static int ena_queue_start(struct ena_ring *ring) PMD_INIT_LOG(ERR, "Failed to populate rx ring !"); return ENA_COM_FAULT; } + /* Flush per-core RX buffers pools cache as they can be used on other + * cores as well. + */ + rte_mempool_cache_flush(NULL, ring->mb_pool); return 0; } -- 2.30.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-04 12:04:32.943691325 +0100 +++ 0120-net-ena-flush-Rx-buffers-memory-pool-cache.patch 2021-02-04 12:04:28.178789872 +0100 @@ -1 +1 @@ -From 4387e81c94f4702ec2eb2037df2bfa19927309d7 Mon Sep 17 00:00:00 2001 +From 5d475f9e0128151bf9614a46434b4c0784fd8859 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4387e81c94f4702ec2eb2037df2bfa19927309d7 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index c796af4aa7..dde6e9ce8b 100644 +index 2c19f6459f..d098387a8c 100644 @@ -26 +27 @@ -@@ -1246,6 +1246,10 @@ static int ena_queue_start(struct ena_ring *ring) +@@ -1182,6 +1182,10 @@ static int ena_queue_start(struct ena_ring *ring)