From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 123C3A0524 for ; Thu, 4 Feb 2021 12:38:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A9912407A4; Thu, 4 Feb 2021 12:38:46 +0100 (CET) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id CC02C24077B for ; Thu, 4 Feb 2021 12:38:43 +0100 (CET) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l7cyB-0005lT-Kk; Thu, 04 Feb 2021 11:38:43 +0000 From: Christian Ehrhardt To: Chengchang Tang Cc: Lijun Ou , dpdk stable Date: Thu, 4 Feb 2021 12:29:48 +0100 Message-Id: <20210204112954.2488123-133-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210204112954.2488123-1-christian.ehrhardt@canonical.com> References: <20210204112954.2488123-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/hns3: fix dump register out of range' has been queued to stable release 19.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/06/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/4ae7e3069a58554d0ddf8ef2b3a3c31ff11b31f3 Thanks. Christian Ehrhardt --- >From 4ae7e3069a58554d0ddf8ef2b3a3c31ff11b31f3 Mon Sep 17 00:00:00 2001 From: Chengchang Tang Date: Thu, 14 Jan 2021 21:33:36 +0800 Subject: [PATCH] net/hns3: fix dump register out of range [ upstream commit acb3260fac5c93d953876172ce322e9f2801a33c ] Currently, when dump the queue interrupt registers, the number of registers that should be dumped is calculated from num_msi. But the value of num_msi includes the number of misc interrupts. So, for some hardware version, like kupeng930, it will lead to an illegal access. This patch replace num_msi with intr_tqps_num which indicate the number of interrupts used by the tqps. Fixes: 936eda25e8da ("net/hns3: support dump register") Signed-off-by: Chengchang Tang Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_regs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_regs.c b/drivers/net/hns3/hns3_regs.c index 277404e692..2f34357d48 100644 --- a/drivers/net/hns3/hns3_regs.c +++ b/drivers/net/hns3/hns3_regs.c @@ -314,7 +314,7 @@ hns3_direct_access_regs(struct hns3_hw *hw, uint32_t *data) } reg_num = sizeof(tqp_intr_reg_addrs) / sizeof(uint32_t); - for (j = 0; j < hw->num_msi; j++) { + for (j = 0; j < hw->intr_tqps_num; j++) { reg_offset = HNS3_TQP_INTR_REG_SIZE * j; for (i = 0; i < reg_num; i++) *data++ = hns3_read_dev(hw, tqp_intr_reg_addrs[i] + -- 2.30.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-04 12:04:33.412998273 +0100 +++ 0133-net-hns3-fix-dump-register-out-of-range.patch 2021-02-04 12:04:28.202789895 +0100 @@ -1 +1 @@ -From acb3260fac5c93d953876172ce322e9f2801a33c Mon Sep 17 00:00:00 2001 +From 4ae7e3069a58554d0ddf8ef2b3a3c31ff11b31f3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit acb3260fac5c93d953876172ce322e9f2801a33c ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 775e0965f7..f2cb465eed 100644 +index 277404e692..2f34357d48 100644 @@ -27 +28 @@ -@@ -300,7 +300,7 @@ hns3_direct_access_regs(struct hns3_hw *hw, uint32_t *data) +@@ -314,7 +314,7 @@ hns3_direct_access_regs(struct hns3_hw *hw, uint32_t *data)