From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AD68A0524 for ; Thu, 4 Feb 2021 12:35:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4388E24074E; Thu, 4 Feb 2021 12:35:05 +0100 (CET) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 07FA024072B for ; Thu, 4 Feb 2021 12:35:04 +0100 (CET) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l7cud-0005NI-R3; Thu, 04 Feb 2021 11:35:03 +0000 From: Christian Ehrhardt To: Leyi Rong Cc: Qi Zhang , dpdk stable Date: Thu, 4 Feb 2021 12:28:15 +0100 Message-Id: <20210204112954.2488123-40-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210204112954.2488123-1-christian.ehrhardt@canonical.com> References: <20210204112954.2488123-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/ice: enlarge Rx queue rearm threshold to 64' has been queued to stable release 19.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/06/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/f5d4f7382f9143f92ae32cdd93571fa8d9ea57fd Thanks. Christian Ehrhardt --- >From f5d4f7382f9143f92ae32cdd93571fa8d9ea57fd Mon Sep 17 00:00:00 2001 From: Leyi Rong Date: Wed, 6 Jan 2021 13:35:48 +0800 Subject: [PATCH] net/ice: enlarge Rx queue rearm threshold to 64 [ upstream commit 295906ffaad9bd8e730248fb24be8fb437df1769 ] We observe performance drop on ice AVX512 data path after stop and start by using testpmd. As CPU polling is faster in AVX512 path, L3 contested accesses is intensified when rxrearm_start is a random value after testpmd stop/start. Enlarge ICE_RXQ_REARM_THRESH to 64 to ease the contested accesses and fix the performance drop issue. Signed-off-by: Leyi Rong Acked-by: Qi Zhang --- drivers/net/ice/ice_rxtx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_rxtx.h b/drivers/net/ice/ice_rxtx.h index 041f00970d..f80fdc1d6b 100644 --- a/drivers/net/ice/ice_rxtx.h +++ b/drivers/net/ice/ice_rxtx.h @@ -31,7 +31,7 @@ #define ICE_VPMD_RX_BURST 32 #define ICE_VPMD_TX_BURST 32 -#define ICE_RXQ_REARM_THRESH 32 +#define ICE_RXQ_REARM_THRESH 64 #define ICE_MAX_RX_BURST ICE_RXQ_REARM_THRESH #define ICE_TX_MAX_FREE_BUF_SZ 64 #define ICE_DESCS_PER_LOOP 4 -- 2.30.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-04 12:04:29.794411436 +0100 +++ 0040-net-ice-enlarge-Rx-queue-rearm-threshold-to-64.patch 2021-02-04 12:04:27.950789652 +0100 @@ -1 +1 @@ -From 295906ffaad9bd8e730248fb24be8fb437df1769 Mon Sep 17 00:00:00 2001 +From f5d4f7382f9143f92ae32cdd93571fa8d9ea57fd Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 295906ffaad9bd8e730248fb24be8fb437df1769 ] + @@ -16,2 +17,0 @@ -Cc: stable@dpdk.org - @@ -25 +25 @@ -index 6b16716063..adfae016a9 100644 +index 041f00970d..f80fdc1d6b 100644