From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4429A0524 for ; Thu, 4 Feb 2021 12:30:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE0A024071B; Thu, 4 Feb 2021 12:30:23 +0100 (CET) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id F0C2224071A for ; Thu, 4 Feb 2021 12:30:21 +0100 (CET) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l7cq5-00053H-PR; Thu, 04 Feb 2021 11:30:21 +0000 From: Christian Ehrhardt To: Ferruh Yigit Cc: Fan Zhang , dpdk stable Date: Thu, 4 Feb 2021 12:27:43 +0100 Message-Id: <20210204112954.2488123-8-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210204112954.2488123-1-christian.ehrhardt@canonical.com> References: <20210204112954.2488123-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/crypto-perf: remove always true condition' has been queued to stable release 19.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/06/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/6c0a0f5e578eb67c9947d237eb5445f2c32511f8 Thanks. Christian Ehrhardt --- >From 6c0a0f5e578eb67c9947d237eb5445f2c32511f8 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Thu, 19 Nov 2020 11:58:59 +0000 Subject: [PATCH] app/crypto-perf: remove always true condition [ upstream commit 427ec3b7285d8e8b939f7e5db4976476c931c005 ] This is already 'else' leg of the opposite comparison, simple 'else' will be logically same. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Ferruh Yigit Acked-by: Fan Zhang --- app/test-crypto-perf/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index 7bb286ccbe..b065ab2acb 100644 --- a/app/test-crypto-perf/main.c +++ b/app/test-crypto-perf/main.c @@ -380,7 +380,7 @@ cperf_check_test_vector(struct cperf_options *opts, if (opts->cipher_algo == RTE_CRYPTO_CIPHER_NULL) { if (test_vec->plaintext.data == NULL) return -1; - } else if (opts->cipher_algo != RTE_CRYPTO_CIPHER_NULL) { + } else { if (test_vec->plaintext.data == NULL) return -1; if (test_vec->plaintext.length < opts->max_buffer_size) @@ -430,7 +430,7 @@ cperf_check_test_vector(struct cperf_options *opts, return -1; if (test_vec->plaintext.length < opts->max_buffer_size) return -1; - } else if (opts->cipher_algo != RTE_CRYPTO_CIPHER_NULL) { + } else { if (test_vec->plaintext.data == NULL) return -1; if (test_vec->plaintext.length < opts->max_buffer_size) -- 2.30.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-04 12:04:28.540974655 +0100 +++ 0008-app-crypto-perf-remove-always-true-condition.patch 2021-02-04 12:04:27.802789508 +0100 @@ -1 +1 @@ -From 427ec3b7285d8e8b939f7e5db4976476c931c005 Mon Sep 17 00:00:00 2001 +From 6c0a0f5e578eb67c9947d237eb5445f2c32511f8 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 427ec3b7285d8e8b939f7e5db4976476c931c005 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 5f035519c3..99f86e9019 100644 +index 7bb286ccbe..b065ab2acb 100644 @@ -22 +23 @@ -@@ -390,7 +390,7 @@ cperf_check_test_vector(struct cperf_options *opts, +@@ -380,7 +380,7 @@ cperf_check_test_vector(struct cperf_options *opts, @@ -31 +32 @@ -@@ -440,7 +440,7 @@ cperf_check_test_vector(struct cperf_options *opts, +@@ -430,7 +430,7 @@ cperf_check_test_vector(struct cperf_options *opts,