From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BE58A0524 for ; Fri, 5 Feb 2021 12:30:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25EE0188742; Fri, 5 Feb 2021 12:30:31 +0100 (CET) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mails.dpdk.org (Postfix) with ESMTP id 9A342188742 for ; Fri, 5 Feb 2021 12:30:30 +0100 (CET) Received: by mail-wr1-f54.google.com with SMTP id v15so7312926wrx.4 for ; Fri, 05 Feb 2021 03:30:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=umt4ZErBKLcBMfXjeCXOKxrv+tMIx0d36Uvo7gZ8qfg=; b=jBTVMwWVOmOzTV6qrjvJb+v3FD509kLuzjPcS0gfVO+nBrca/dVMSBvEfvys//E0uf BsVWLeGMMG1kNDfDjIA6wTh6fwqtgUOTi39dAHC8MKasHzXXBzS2Y59xY1C+K4Weor60 rXWRa6zQaZY1gBJS1RTw193vi7Otz6YgVe9rBQSea4/6S7sfOPJuwJKeQSWn/7KxWueW bEIObo+LBqzc+nmiSHbCC6GVSy95bxtbVklBSOtCAHIkxBkdeAf+F5tYpyhntR4alGUm 2d64Jk7EYMoONbn6scDzLIDhFUURayoUeG6RISxrnd6dnffZtzMqvJalp7k1xTROPh2z k+xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=umt4ZErBKLcBMfXjeCXOKxrv+tMIx0d36Uvo7gZ8qfg=; b=GzCBxZiDjeMx2WkTMyRHOmREmilIe26+s0VLTLeSrX7Cd9+fCIRhLqfVq68MSZV46M kCwOvTxsoO6vcLRtr6SmKk+1PqeYoFgH3/1PKN2BjdvbJb2kM6viM5nhf2mgIyQQz1pi yonyaE4FS7M1VlYlzm34by6SDBbZXp/Fe+M7DzgcC9axEpOFj5VdO2vNnGaYcOwrqt5G ZzUkMolb7sbeVrhSQsnfvIAu49lljxG9Qb6Dy6dM30t0WI0isWVgv0V5OLmDpsR/xR4C rftC3I2NCwrXT8HR+sSOkckGOm5V+F2l00vJJq+KSM9B8QV/9xDi3husY9Bv+oswdme+ dAMA== X-Gm-Message-State: AOAM5302x/6Z+lGyWeosCMhx90/e51gCYRhFFPMsaE/r77qzkeoReecC 8iMcSJL276zH5GxNmoeH7L5lxh/bywwJokdS X-Google-Smtp-Source: ABdhPJzB+EAxCjfHxBdQxqa+tw8oQZ+ZBLAO+YrjkeTfoqB4IFKj2YcgSk3c0jFcr+0hK+GEuJTxUg== X-Received: by 2002:a5d:4211:: with SMTP id n17mr4524599wrq.37.1612524630391; Fri, 05 Feb 2021 03:30:30 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id u206sm8734771wme.12.2021.02.05.03.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:30:29 -0800 (PST) From: luca.boccassi@gmail.com To: Alvin Zhang Cc: Wei Xie , Qi Zhang , dpdk stable Date: Fri, 5 Feb 2021 11:16:28 +0000 Message-Id: <20210205111920.1272063-102-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/ice: fix RSS lookup table initialization' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/746f4e243da19cf00443a44aca36841363811094 Thanks. Luca Boccassi --- >From 746f4e243da19cf00443a44aca36841363811094 Mon Sep 17 00:00:00 2001 From: Alvin Zhang Date: Fri, 8 Jan 2021 15:29:10 +0800 Subject: [PATCH] net/ice: fix RSS lookup table initialization [ upstream commit 7fe2fde05ac8766afaed4344659e39e8fc6b2514 ] RSS look-up table initialization is done incorrectly due to divide-by-zero error. Add a check to rx-queue count. Fixes: 50370662b727 ("net/ice: support device and queue ops") Signed-off-by: Alvin Zhang Tested-by: Wei Xie Acked-by: Qi Zhang --- drivers/net/ice/ice_ethdev.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index bbb8c14606..4dcaa87350 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3274,10 +3274,12 @@ ice_dev_configure(struct rte_eth_dev *dev) if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH; - ret = ice_init_rss(pf); - if (ret) { - PMD_DRV_LOG(ERR, "Failed to enable rss for PF"); - return ret; + if (dev->data->nb_rx_queues) { + ret = ice_init_rss(pf); + if (ret) { + PMD_DRV_LOG(ERR, "Failed to enable rss for PF"); + return ret; + } } return 0; -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:33.823063271 +0000 +++ 0102-net-ice-fix-RSS-lookup-table-initialization.patch 2021-02-05 11:18:28.954693930 +0000 @@ -1 +1 @@ -From 7fe2fde05ac8766afaed4344659e39e8fc6b2514 Mon Sep 17 00:00:00 2001 +From 746f4e243da19cf00443a44aca36841363811094 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7fe2fde05ac8766afaed4344659e39e8fc6b2514 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 587f485ee3..e2799a8eb2 100644 +index bbb8c14606..4dcaa87350 100644