From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FC92A0524 for ; Fri, 5 Feb 2021 12:31:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66CD740682; Fri, 5 Feb 2021 12:31:25 +0100 (CET) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id 4A63B1889A0 for ; Fri, 5 Feb 2021 12:31:23 +0100 (CET) Received: by mail-wm1-f53.google.com with SMTP id j21so2932962wmj.0 for ; Fri, 05 Feb 2021 03:31:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kC56DM168/9rgqP7MXTu7e34OUN2gOv3h0l2lJvGEzU=; b=arBQncdKAVF82g8F5hChXJOTdrAS0tV7/smyCFwzzBorBTVQQBJKxYZdiQpcHHtLxV PgsteiXzBMTA4YdtT+FxDxnsrAGombojPm23/XmeXyrGk/RTTAzxKjMfTxw9jOsaJNCq 6rrqkLGrT5iJ7P3mmKijTwCTdxD4VvtqjUCNFOwor0daNQVOnSVaaYd+JIiElp0mkGhb +gHKKdF2OI5istw0q+7hKRd6loyRlQ0XGGtzJICYj3uCLoCtRIUsceM4UOA5nxmUOsJ9 ySEvirl+xYcc+z/usUc4hENCyDPWOnT8+kezYQbBwm209aVDv39YK3ly4kiTNq3puQQX /HUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kC56DM168/9rgqP7MXTu7e34OUN2gOv3h0l2lJvGEzU=; b=WxPC2HXUhLdd+d5ixvd6BEvAajYM0Mw/v4z/bxKX0vXIlK9/eMxrBi7nijG+DC6mbI m3CW9rt/VtSj8rn+vfzfVlZc9m3j/bcpiv3GiN+yOOUw4AN43t5MI3lb7PcbWXiY3vJN 4+it6EoXF2wVYB5Vubo9cZN+m0mlImPISlTPLUfJg7IWOROs/8gFKREQO3wCV0vD0zkc aPXKfc/nvvsntA8X5aKFGBDNe4iLgBDINuehmVaz+rUmbaJEPdlnz5s2Jp4IUrRnFmZT EQhoHX5X/hz0xmLREynQwqDhsTm5/wYAuuzZx2pr+ja/sQacov9i9fvFbpVrAH4CWUS+ hpRg== X-Gm-Message-State: AOAM5335SFElCxTnkab9SZybLZBEymhB+se/ca1P+/pvsOYFxhCzCnTR wA7cdm6GMANT4Bqcjr0r4lM= X-Google-Smtp-Source: ABdhPJzAc+ZDFXGpVfrbrRar3UwWM7EufiyKda7v8yErW9UsCccnzqeGIrRS7BgUrry6ZkYvhoRHhA== X-Received: by 2002:a7b:c397:: with SMTP id s23mr3206727wmj.123.1612524683106; Fri, 05 Feb 2021 03:31:23 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id p18sm11983890wrx.84.2021.02.05.03.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:31:22 -0800 (PST) From: luca.boccassi@gmail.com To: Olivier Matz Cc: Honnappa Nagarahalli , dpdk stable Date: Fri, 5 Feb 2021 11:16:45 +0000 Message-Id: <20210205111920.1272063-119-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'test/mcslock: remove unneeded per lcore copy' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/a6e138519f022c7493317dafb8b32d92e7fbe32f Thanks. Luca Boccassi --- >From a6e138519f022c7493317dafb8b32d92e7fbe32f Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Wed, 4 Nov 2020 18:04:25 +0100 Subject: [PATCH] test/mcslock: remove unneeded per lcore copy [ upstream commit 5b3ada04f7d57b6770d41ccff4a2485e5616bc52 ] Each core already comes with its local storage for mcslock (in its stack), therefore there is no need to define an additional per-lcore mcslock. Fixes: 32dcb9fd2a22 ("test/mcslock: add MCS queued lock unit test") Signed-off-by: Olivier Matz Reviewed-by: Honnappa Nagarahalli --- app/test/test_mcslock.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/app/test/test_mcslock.c b/app/test/test_mcslock.c index fbca78707d..80eaecc90a 100644 --- a/app/test/test_mcslock.c +++ b/app/test/test_mcslock.c @@ -37,10 +37,6 @@ * lock multiple times. */ -RTE_DEFINE_PER_LCORE(rte_mcslock_t, _ml_me); -RTE_DEFINE_PER_LCORE(rte_mcslock_t, _ml_try_me); -RTE_DEFINE_PER_LCORE(rte_mcslock_t, _ml_perf_me); - rte_mcslock_t *p_ml; rte_mcslock_t *p_ml_try; rte_mcslock_t *p_ml_perf; @@ -53,7 +49,7 @@ static int test_mcslock_per_core(__rte_unused void *arg) { /* Per core me node. */ - rte_mcslock_t ml_me = RTE_PER_LCORE(_ml_me); + rte_mcslock_t ml_me; rte_mcslock_lock(&p_ml, &ml_me); printf("MCS lock taken on core %u\n", rte_lcore_id()); @@ -77,7 +73,7 @@ load_loop_fn(void *func_param) const unsigned int lcore = rte_lcore_id(); /**< Per core me node. */ - rte_mcslock_t ml_perf_me = RTE_PER_LCORE(_ml_perf_me); + rte_mcslock_t ml_perf_me; /* wait synchro */ while (rte_atomic32_read(&synchro) == 0) @@ -151,8 +147,8 @@ static int test_mcslock_try(__rte_unused void *arg) { /**< Per core me node. */ - rte_mcslock_t ml_me = RTE_PER_LCORE(_ml_me); - rte_mcslock_t ml_try_me = RTE_PER_LCORE(_ml_try_me); + rte_mcslock_t ml_me; + rte_mcslock_t ml_try_me; /* Locked ml_try in the main lcore, so it should fail * when trying to lock it in the worker lcore. @@ -178,8 +174,8 @@ test_mcslock(void) int i; /* Define per core me node. */ - rte_mcslock_t ml_me = RTE_PER_LCORE(_ml_me); - rte_mcslock_t ml_try_me = RTE_PER_LCORE(_ml_try_me); + rte_mcslock_t ml_me; + rte_mcslock_t ml_try_me; /* * Test mcs lock & unlock on each core -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:34.551189455 +0000 +++ 0119-test-mcslock-remove-unneeded-per-lcore-copy.patch 2021-02-05 11:18:28.994694692 +0000 @@ -1 +1 @@ -From 5b3ada04f7d57b6770d41ccff4a2485e5616bc52 Mon Sep 17 00:00:00 2001 +From a6e138519f022c7493317dafb8b32d92e7fbe32f Mon Sep 17 00:00:00 2001 @@ -4,0 +5,2 @@ + +[ upstream commit 5b3ada04f7d57b6770d41ccff4a2485e5616bc52 ]