From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 202FAA0524 for ; Fri, 5 Feb 2021 12:32:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A6D240682; Fri, 5 Feb 2021 12:32:28 +0100 (CET) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mails.dpdk.org (Postfix) with ESMTP id 4316B188A06 for ; Fri, 5 Feb 2021 12:32:26 +0100 (CET) Received: by mail-wr1-f53.google.com with SMTP id u14so7335681wri.3 for ; Fri, 05 Feb 2021 03:32:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gSv7WoABqlKCJPYLJC8sqx9v3EIhquuC+kCs7WhRekc=; b=AQzNgX3m224BEGFbZlCYEv3khbpx/Bx3CO4NvA1cQ1AWv/oiqr1QYbEglnmKXwtTRF qz8FO4WjOnOlQEdQ85PzMJhyFhl2aWF2jVUCiV514+VObWGJbs0neh0tN7llRgJ0zpxN LQhUdsgcQgoD7HfHqrB/ecM85zOdCHuJ/w+dPmseitfGNBGnukoEnjgm5GdNlsxBCJda 3fd2ltX827obcl1/QiKwyl5H/w6F6u/X+q5LQRzhF85+IlIq+RFi8BNe58BGpIXIZclJ RiyKXUF/InNajzmRsMwqmRsyreuvkbDdsnAn+kJoKrhPtenCm4Xevc8+0G+zIpTE31Du JIrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gSv7WoABqlKCJPYLJC8sqx9v3EIhquuC+kCs7WhRekc=; b=KmBZi4ftscqNNdJqItUkMtts/Hcv3g5Pl1hoIpkRBZdiT4RzOeJCIhfUX94Xww3Vu0 9CjHu7QUIwjm9BNJlZ5XvAoguBQ+sDwmcoWKWhf/ffdpjb69eg5+cpvafIk91PK8kfBn 8WzD9ThadCGOhTtiuyAjfEeWAxgF2H/YESWVM/E+yxEOCmD615NVQKLNEpGy/W7uKTFX DSRNpl1QGk4G25C14dqrJawcPr9qCfzIKHgZPvMUYPENmLpgmIZqkJW1EV1WURTKcdEk divH47wL3GcaalnZEFaL4lgxw4ZWm3mYw8m2uezo/hl0GjDhWg78EQ3BTliwgd8yP40D x10g== X-Gm-Message-State: AOAM530kVp5ysMxWnZ7Nd6Q9OLSUtDcMnKOsEXYzyO8XvXC//Hxl8VEV ysiOKeSiQg0B6YZsiAQvcTg= X-Google-Smtp-Source: ABdhPJzYG80Y1PW8bsnKJJSWvY/lLXvMTST3p2On/SdwP3/v0LvrSR7nKUEz0Q6DvZtVn+IjLyyDrg== X-Received: by 2002:adf:cd83:: with SMTP id q3mr4508396wrj.225.1612524746086; Fri, 05 Feb 2021 03:32:26 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id r15sm11969017wrq.1.2021.02.05.03.32.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:32:25 -0800 (PST) From: luca.boccassi@gmail.com To: Balazs Nemeth Cc: Rasesh Mody , dpdk stable Date: Fri, 5 Feb 2021 11:17:03 +0000 Message-Id: <20210205111920.1272063-137-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/qede: fix promiscuous enable' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/ff1e5f3b5ca227f77643aba4c01677cac714d7de Thanks. Luca Boccassi --- >From ff1e5f3b5ca227f77643aba4c01677cac714d7de Mon Sep 17 00:00:00 2001 From: Balazs Nemeth Date: Wed, 23 Dec 2020 15:15:49 +0100 Subject: [PATCH] net/qede: fix promiscuous enable [ upstream commit a91fb48a8c248293f1035cdd8b36ad712ae9478f ] When calling rte_eth_promiscuous_enable(port_id) followed by rte_eth_allmulticast_enable(port_id), the port is not in promisc mode anymore. This patch ensures that promisc mode takes precedence over allmulticast mode fixing the regression introduced by b10231aed1ed. Fixes: b10231aed1ed ("net/qede: fix multicast drop in promiscuous mode") Signed-off-by: Balazs Nemeth Acked-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 549013557c..3bec62d828 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1885,6 +1885,8 @@ static int qede_allmulticast_enable(struct rte_eth_dev *eth_dev) QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC; enum _ecore_status_t ecore_status; + if (rte_eth_promiscuous_get(eth_dev->data->port_id) == 1) + type = QED_FILTER_RX_MODE_TYPE_PROMISC; ecore_status = qed_configure_filter_rx_mode(eth_dev, type); return ecore_status >= ECORE_SUCCESS ? 0 : -EAGAIN; -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:35.291934194 +0000 +++ 0137-net-qede-fix-promiscuous-enable.patch 2021-02-05 11:18:29.018695148 +0000 @@ -1 +1 @@ -From a91fb48a8c248293f1035cdd8b36ad712ae9478f Mon Sep 17 00:00:00 2001 +From ff1e5f3b5ca227f77643aba4c01677cac714d7de Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a91fb48a8c248293f1035cdd8b36ad712ae9478f ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org